[FPEnv] clang should get from the AST the metadata for constrained FP builtins
ClosedPublic
Actions

Authored by kpn on Nov 25 2020, 12:05 PM.

Details

Reviewers

sepavloff
mibintc
rjmccall

Commits

rGabfbc5579bd4: [FPEnv] clang should get from the AST the metadata for constrained FP builtins

Summary

Currently clang is not correctly retrieving from the AST the metadata for constrained FP builtins. This patch fixes that for the non-target specific builtins.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kpn created this revision.Nov 25 2020, 12:05 PM

Herald added a subscriber: cfe-commits. · View Herald TranscriptNov 25 2020, 12:05 PM

kpn requested review of this revision.Nov 25 2020, 12:05 PM

Harbormaster completed remote builds in B80131: Diff 307675.Nov 25 2020, 12:41 PM

mibintc accepted this revision.Nov 30 2020, 6:28 AM

This revision is now accepted and ready to land.Nov 30 2020, 6:28 AM

Closed by commit rGabfbc5579bd4: [FPEnv] clang should get from the AST the metadata for constrained FP builtins (authored by kpn). · Explain WhyNov 30 2020, 8:59 AM

This revision was automatically updated to reflect the committed changes.

kpn added a commit: rGabfbc5579bd4: [FPEnv] clang should get from the AST the metadata for constrained FP builtins.

Thanks for the quick turnaround!

kpn mentioned this in D94186: [FPEnv][PowerPC] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.Wed, Jan 6, 11:53 AM

kpn mentioned this in D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins.Wed, Jan 13, 10:04 AM

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

CGBuiltin.cpp

17 lines

test/

CodeGen/

builtin_float_strictfp.c

19 lines

constrained-math-builtins.c

213 lines

strictfp_fpclassify.c

130 lines

Diff 308390

View Options

clang/lib/CodeGen/CGBuiltin.cpp

View Options

clang/test/CodeGen/builtin_float_strictfp.c

View Options

clang/test/CodeGen/constrained-math-builtins.c

View Options

clang/test/CodeGen/strictfp_fpclassify.c

[FPEnv] clang should get from the AST the metadata for constrained FP builtinsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 308390

clang/lib/CodeGen/CGBuiltin.cpp

clang/test/CodeGen/builtin_float_strictfp.c

clang/test/CodeGen/constrained-math-builtins.c

clang/test/CodeGen/strictfp_fpclassify.c

[FPEnv] clang should get from the AST the metadata for constrained FP builtins
ClosedPublic
Actions

Revision Contents
Changeset List