Page MenuHomePhabricator

[flang][openacc] Add more parsing/sema tests for init and shutdown directives
Needs ReviewPublic

Authored by clementval on Wed, Nov 4, 12:31 PM.

Details

Summary

This patch adds some positive and failure tests for init and shutdown directives.

Diff Detail

Event Timeline

clementval created this revision.Wed, Nov 4, 12:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Nov 4, 12:31 PM
clementval requested review of this revision.Wed, Nov 4, 12:31 PM
kiranktp added inline comments.Thu, Nov 5, 12:15 AM
flang/test/Semantics/acc-clause-validity.f90
65

I may be wrong here. but i do not see these restrictions in OpenACC 3.0 standard for SHUTDOWN and INIT directive.

clementval added inline comments.Thu, Nov 5, 7:11 AM
flang/test/Semantics/acc-clause-validity.f90
65

There is no written restriction about the if clause on most directives but this is kind of an implicit one since there is also no rule how two if condition would be combined together. Do you combined them with a logical OR or a logical AND. Since the clause takes a condition expression one can combined multiple conditions together in a single if clause.

Is there any conclusion on this ?

Is there any conclusion on this ?

I have discussed this point with some member of the spec committee and it is not really well defined currently. This will be addressed in future version of the spec but the intention is to allow only a single if clause on all directives.