This is an archive of the discontinued LLVM Phabricator instance.

[NFC][flang] Introduce new helper TODO macro for further development
ClosedPublic

Authored by schweitz on Oct 6 2020, 9:43 AM.

Details

Summary

The Todo.h header file allows flang developers to mark parts of the (lowering) project as "todo" holes in the implementation. Inputs that reach these holes will cause the compiler to exit rather than silently proceed and either crash later or produce incorrect code.

This file is being added to enable continued development and progress on the lowering of OpenMP, OpenACC, etc.

Diff Detail

Event Timeline

schweitz created this revision.Oct 6 2020, 9:43 AM
Herald added a project: Restricted Project. · View Herald Transcript
schweitz requested review of this revision.Oct 6 2020, 9:43 AM
schweitz edited the summary of this revision. (Show Details)Oct 6 2020, 9:44 AM
SouraVX accepted this revision.Oct 6 2020, 10:12 AM

Thanks for the patch!
NIT:
A more reasonable commit message could be:
[NFCI][flang] Introduce new helper TODO for further development
Or something similar(aligned to intent) :)

This revision is now accepted and ready to land.Oct 6 2020, 10:12 AM

Thanks for the patch!
NIT:
A more reasonable commit message could be:
[NFCI][flang] Introduce new helper TODO for further development
Or something similar(aligned to intent) :)

Good suggestion. I'll do that.

schweitz retitled this revision from add Todo.h to [NFC][flang] add Todo.h.Oct 6 2020, 10:22 AM
schweitz retitled this revision from [NFC][flang] add Todo.h to [NFC][flang] Introduce new helper TODO macro for further development.
This revision was landed with ongoing or failed builds.Oct 6 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.