Page MenuHomePhabricator

schweitz (Eric Schweitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2015, 10:25 AM (273 w, 2 d)

Recent Activity

Thu, Jan 7

schweitz added inline comments to D94017: [flang] Fix bogus message on internal subprogram with alternate return.
Thu, Jan 7, 3:45 PM · Restricted Project, Restricted Project
schweitz committed rG70b841ac3177: [mlir] Adds argument attributes for using LLVM's sret and byval attributes (authored by schweitz).
[mlir] Adds argument attributes for using LLVM's sret and byval attributes
Thu, Jan 7, 12:53 PM
schweitz committed rGbd78f4e93212: [mlir] revert 82f5ee3c3e601daad5 (authored by schweitz).
[mlir] revert 82f5ee3c3e601daad5
Thu, Jan 7, 9:39 AM
schweitz added a reverting change for rG82f5ee3c3e60: Adds argument attributes for using LLVM's sret and byval attributes to: rGbd78f4e93212: [mlir] revert 82f5ee3c3e601daad5.
Thu, Jan 7, 9:39 AM
schweitz added a reverting change for D94052: [mlir] Add sret and byval argument attribute support to LLVM-IR dialect: rGbd78f4e93212: [mlir] revert 82f5ee3c3e601daad5.
Thu, Jan 7, 9:39 AM · Restricted Project
schweitz committed rG82f5ee3c3e60: Adds argument attributes for using LLVM's sret and byval attributes to (authored by schweitz).
Adds argument attributes for using LLVM's sret and byval attributes to
Thu, Jan 7, 9:03 AM
schweitz closed D94052: [mlir] Add sret and byval argument attribute support to LLVM-IR dialect.
Thu, Jan 7, 9:03 AM · Restricted Project

Tue, Jan 5

schweitz updated the diff for D94052: [mlir] Add sret and byval argument attribute support to LLVM-IR dialect.

Changes requested in review.

Tue, Jan 5, 8:59 AM · Restricted Project
schweitz added a comment to D94052: [mlir] Add sret and byval argument attribute support to LLVM-IR dialect.

I have two requests:

  1. use UnitAttr instead of BoolAttr
  2. add tests for any user-visible error messages

(Potentially for a follow-up, we should check attributes in the op verifier, not in the translation, but I see there are other attributes checked in the translation).

Tue, Jan 5, 7:50 AM · Restricted Project

Mon, Jan 4

schweitz accepted D92065: [flang][openacc] Lower parallel loop combined construct.

LGTM.

Mon, Jan 4, 5:04 PM · Restricted Project, Restricted Project
schweitz accepted D92064: [flang][openacc] Remove duplicated code for clause lowering.

LGTM.

Mon, Jan 4, 4:59 PM · Restricted Project, Restricted Project
schweitz requested review of D94052: [mlir] Add sret and byval argument attribute support to LLVM-IR dialect.
Mon, Jan 4, 4:40 PM · Restricted Project

Dec 11 2020

schweitz added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 11 2020, 11:21 AM · Restricted Project

Nov 17 2020

schweitz accepted D91654: [flang] Fix FIR test failures.
Nov 17 2020, 12:12 PM · Restricted Project, Restricted Project

Nov 4 2020

schweitz accepted D90489: [flang][openacc] Lower wait directive.
Nov 4 2020, 10:08 AM · Restricted Project, Restricted Project
schweitz accepted D90488: [flang][openacc] Lower init and shutdown directive.
Nov 4 2020, 10:08 AM · Restricted Project, Restricted Project
schweitz accepted D90467: [flang][openacc] Lower exit data directive.
Nov 4 2020, 10:07 AM · Restricted Project, Restricted Project
schweitz accepted D90472: [flang][openacc] Lower update directive.
Nov 4 2020, 10:07 AM · Restricted Project, Restricted Project
schweitz accepted D90470: [flang][openacc] Lower enter data directive.
Nov 4 2020, 10:07 AM · Restricted Project, Restricted Project
schweitz accepted D90226: [flang] update ODS syntax to use OpBuidlerDAG instead of OpBuilder.

Looks good. Thanks for doing this.

Nov 4 2020, 9:47 AM · Restricted Project, Restricted Project

Oct 14 2020

schweitz committed rG3ea4ccd857c3: [mlir] expand the legal floating-point types in the LLVM IR dialect type check (authored by schweitz).
[mlir] expand the legal floating-point types in the LLVM IR dialect type check
Oct 14 2020, 6:56 AM
schweitz closed D89350: [mlir] expand the legal floating-point types in the LLVM IR dialect type check.
Oct 14 2020, 6:56 AM · Restricted Project
schweitz added inline comments to D89350: [mlir] expand the legal floating-point types in the LLVM IR dialect type check.
Oct 14 2020, 6:54 AM · Restricted Project

Oct 13 2020

schweitz requested review of D89350: [mlir] expand the legal floating-point types in the LLVM IR dialect type check.
Oct 13 2020, 4:50 PM · Restricted Project

Oct 6 2020

schweitz committed rG0f8294072fbc: [NFC][flang] Add the header file Todo.h. This file is being upstreamed to… (authored by schweitz).
[NFC][flang] Add the header file Todo.h. This file is being upstreamed to…
Oct 6 2020, 11:32 AM
schweitz closed D88909: [NFC][flang] Introduce new helper TODO macro for further development.
Oct 6 2020, 11:32 AM · Restricted Project, Restricted Project
schweitz retitled D88909: [NFC][flang] Introduce new helper TODO macro for further development from [NFC][flang] add Todo.h to [NFC][flang] Introduce new helper TODO macro for further development.
Oct 6 2020, 10:23 AM · Restricted Project, Restricted Project
schweitz retitled D88909: [NFC][flang] Introduce new helper TODO macro for further development from add Todo.h to [NFC][flang] add Todo.h.
Oct 6 2020, 10:22 AM · Restricted Project, Restricted Project
schweitz added a comment to D88909: [NFC][flang] Introduce new helper TODO macro for further development.

Thanks for the patch!
NIT:
A more reasonable commit message could be:
[NFCI][flang] Introduce new helper TODO for further development
Or something similar(aligned to intent) :)

Oct 6 2020, 10:21 AM · Restricted Project, Restricted Project
schweitz updated the summary of D88909: [NFC][flang] Introduce new helper TODO macro for further development.
Oct 6 2020, 9:44 AM · Restricted Project, Restricted Project
schweitz requested review of D88909: [NFC][flang] Introduce new helper TODO macro for further development.
Oct 6 2020, 9:43 AM · Restricted Project, Restricted Project

Oct 5 2020

schweitz added a comment to D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP.

fir.alloca ops should be hoisted to the entry block. Because Fortran is pass-by-reference, correctness will often simply require stack allocations. However, that said, in cases where alloca ops can be promoted to registers, they will be although that is disabled at the moment.

Oct 5 2020, 4:03 PM · Restricted Project, Restricted Project

Oct 1 2020

schweitz accepted D88692: [flang] Extend runtime API for PAUSE to allow a stop code.
Oct 1 2020, 2:06 PM · Restricted Project, Restricted Project
schweitz accepted D88685: [flang] Fix actions at end of output record.
Oct 1 2020, 2:04 PM · Restricted Project, Restricted Project
schweitz accepted D88612: flang] Fix buffering read->write transition.
Oct 1 2020, 2:03 PM · Restricted Project, Restricted Project
schweitz accepted D88253: [flang][openacc] Update loop construct lowering.
Oct 1 2020, 2:02 PM · Restricted Project, Restricted Project
schweitz accepted D88604: [flang] Readability improvement in binary->decimal conversion.
Oct 1 2020, 2:01 PM · Restricted Project, Restricted Project

Sep 25 2020

schweitz accepted D88221: [flang][OpenMP] Place the insertion point to the start of the block.
Sep 25 2020, 10:25 AM · Restricted Project, Restricted Project

Aug 21 2020

schweitz added a comment to D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings.

I'm fine with whatever numbering makes your development the easiest. My only ask is that if we still have a gap after this, please document what nodes are expected to go there, so there 1) won't be any future conflicts and 2) we don't pointlessly reserve space.

I'll have to re-confirm with our team. Making sure we don't break anything is priority for us.
@schweitz do you have any reservations WRT this ?

Aug 21 2020, 1:06 PM · debug-info, Restricted Project
schweitz added a comment to D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings.

I'm fine with whatever numbering makes your development the easiest. My only ask is that if we still have a gap after this, please document what nodes are expected to go there, so there 1) won't be any future conflicts and 2) we don't pointlessly reserve space.

I'll have to re-confirm with our team. Making sure we don't break anything is priority for us.
@schweitz do you have any reservations WRT this ?

We don't have any reservations with bit 42 and 43. If @schweitz also don't have any reservations we can mark/document them to be usable by others.

Aug 21 2020, 1:05 PM · debug-info, Restricted Project
schweitz added a comment to D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings.

You might want to add "[flang]" to the subject line as this change supports Fortran. Thanx.

Aug 21 2020, 9:08 AM · debug-info, Restricted Project
schweitz accepted D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings.

Thanks, Sourabh. That will help sync these patches with our internal branch. Glad to see this get upstreamed.

Aug 21 2020, 9:06 AM · debug-info, Restricted Project

Aug 20 2020

schweitz accepted D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings.
Aug 20 2020, 2:38 PM · debug-info, Restricted Project

Aug 17 2020

schweitz accepted D85847: [mlir] Provide LLVMType::getPrimitiveSizeInBits.

Thanks for adding this.

Aug 17 2020, 8:54 AM · Restricted Project

Aug 12 2020

schweitz updated subscribers of D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

+1 @DavidTruby - For pointing the reason for MLIR to use .md files.
It's correct that LLVM uses Sphinx infrastructure to build docs for any sub-project except MLIR.

Aug 12 2020, 3:21 PM · Restricted Project

Aug 7 2020

schweitz accepted D85465: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer.
Aug 7 2020, 10:13 AM · Restricted Project, Restricted Project

Jul 30 2020

schweitz accepted D84936: [flang] Fix CMPLX folding with complex arguments.
Jul 30 2020, 3:35 PM · Restricted Project, Restricted Project

Jul 29 2020

schweitz accepted D84842: [flang] Expose specific to generic intrinsic name mapping.
Jul 29 2020, 8:28 AM · Restricted Project, Restricted Project

Jul 23 2020

schweitz added inline comments to D84195: [flang][openacc] Skeleton for OpenACC construct lowering.
Jul 23 2020, 8:42 AM · Restricted Project, Restricted Project

Jul 16 2020

schweitz added a comment to D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.

Fix build failure

Jul 16 2020, 8:33 AM · Restricted Project
schweitz accepted D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.
Jul 16 2020, 8:32 AM · Restricted Project

Jul 15 2020

schweitz added a reviewer for D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits: sscalpone.
Jul 15 2020, 7:09 AM · Restricted Project
schweitz added a comment to D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.

Ping. Not sure if flang is accepting such changes, if not please let me know and I will abandon this.

Jul 15 2020, 7:03 AM · Restricted Project

Jul 14 2020

schweitz accepted D83771: [flang] Fix shared library builds for lib/Lower..
Jul 14 2020, 1:00 PM · Restricted Project
schweitz accepted D83659: [flang][OpenMP] upstream OpenMP lowering.
Jul 14 2020, 5:13 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

schweitz committed rG9263e08251ae: [flang] ifdef to avoid warning about supposedly dead function (authored by schweitz).
[flang] ifdef to avoid warning about supposedly dead function
Jul 9 2020, 4:10 PM
schweitz committed rG7cd1b0ff347d: [flang] partially revert upstreamed code to support complex values in runtime… (authored by schweitz).
[flang] partially revert upstreamed code to support complex values in runtime…
Jul 9 2020, 7:40 AM

Jul 8 2020

schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

You also still haven't replied with "what bot/compiler/etc is going to break by making this change". Would you please do that?

Jul 8 2020, 8:58 AM · Restricted Project, Restricted Project
schweitz resigned from D83397: [flang] Replace uses of _Complex with std::complex.

I've reverted these models from the upstreamed code for now. It will avoid the warnings.

Jul 8 2020, 8:55 AM · Restricted Project, Restricted Project
schweitz committed rGc54a013e5a82: partial revert on RTBuilder.h to avoid warnings. (authored by schweitz).
partial revert on RTBuilder.h to avoid warnings.
Jul 8 2020, 8:47 AM
schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

That's not part of the llvm project.

That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.

It very much is unused and unnecessary as there are no pieces of that code in the repository.

Jul 8 2020, 8:07 AM · Restricted Project, Restricted Project
schweitz added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

Jul 8 2020, 7:44 AM · Restricted Project, Restricted Project
schweitz committed rG24b62f28c5da: [flang] Upstreaming intrinsic call lowering. (authored by schweitz).
[flang] Upstreaming intrinsic call lowering.
Jul 8 2020, 7:34 AM
schweitz closed D83355: [flang] upstream intrinsic call lowering.
Jul 8 2020, 7:34 AM · Restricted Project, Restricted Project
schweitz requested changes to D83397: [flang] Replace uses of _Complex with std::complex.

This will not compile in our builds.

Jul 8 2020, 7:30 AM · Restricted Project, Restricted Project

Jul 7 2020

Herald added a project to D83355: [flang] upstream intrinsic call lowering: Restricted Project.
Jul 7 2020, 4:08 PM · Restricted Project, Restricted Project
schweitz committed rG216a54a04b9b: [flang] Add lowering of I/O statements. (authored by schweitz).
[flang] Add lowering of I/O statements.
Jul 7 2020, 7:32 AM
schweitz closed D83267: [flang] Add lowering of I/O statements.
Jul 7 2020, 7:32 AM · Restricted Project, Restricted Project
schweitz added a comment to D83267: [flang] Add lowering of I/O statements.

Thanks for pointing out those comments. Yes, the I/O runtime is much further along now. I'll update them.

Jul 7 2020, 7:28 AM · Restricted Project, Restricted Project

Jul 6 2020

Herald added a reviewer for D83267: [flang] Add lowering of I/O statements: DavidTruby.
Jul 6 2020, 5:05 PM · Restricted Project, Restricted Project

Jul 3 2020

schweitz committed rG35808ab8e18c: [flang] Add FIRBuilder.cpp (authored by schweitz).
[flang] Add FIRBuilder.cpp
Jul 3 2020, 11:59 AM
schweitz closed D83107: [flang] Add FIR builder.
Jul 3 2020, 11:53 AM · Restricted Project, Restricted Project

Jul 2 2020

schweitz created D83107: [flang] Add FIR builder.
Jul 2 2020, 6:22 PM · Restricted Project, Restricted Project
schweitz accepted D83051: [flang][NFC] Move and rework pgmath description used in folding.
Jul 2 2020, 8:05 AM · Restricted Project, Restricted Project
schweitz committed rG5c02a2421b95: [flang] Add inliner pass. (authored by schweitz).
[flang] Add inliner pass.
Jul 2 2020, 6:27 AM
schweitz committed rGffa1f8198e6e: [flang] Add changes to codegen to convert it to tablegen passes. (authored by schweitz).
[flang] Add changes to codegen to convert it to tablegen passes.
Jul 2 2020, 6:27 AM
schweitz closed D83018: [flang] Add changes to codegen to convert it to tablegen passes..
Jul 2 2020, 6:27 AM · Restricted Project, Restricted Project
schweitz closed D83010: [flang] Add inliner pass..

Commit 5c02a2421b951a14d1294598d0082b32659c7082

Jul 2 2020, 6:25 AM · Restricted Project, Restricted Project

Jul 1 2020

schweitz created D83018: [flang] Add changes to codegen to convert it to tablegen passes..
Jul 1 2020, 6:54 PM · Restricted Project, Restricted Project
schweitz created D83010: [flang] Add inliner pass..
Jul 1 2020, 5:18 PM · Restricted Project, Restricted Project
schweitz accepted D83007: [flang] Add more support for alternate returns.
Jul 1 2020, 4:13 PM · Restricted Project, Restricted Project
schweitz accepted D82989: [flang][NFC] Get formatting in sync with latest clang-format.
Jul 1 2020, 4:13 PM · Restricted Project, Restricted Project
schweitz committed rG5a580bbb8187: [flang] Add the Runtime.h to prepare for more code being upstreamed. (authored by schweitz).
[flang] Add the Runtime.h to prepare for more code being upstreamed.
Jul 1 2020, 1:32 PM
schweitz closed D82991: [flang] Add the Runtime.h to prepare for more code being upstreamed..
Jul 1 2020, 1:32 PM · Restricted Project, Restricted Project
schweitz committed rGe1581540876f: [clang-tidy] Allows the prevailing include header guard in Flang to be… (authored by schweitz).
[clang-tidy] Allows the prevailing include header guard in Flang to be…
Jul 1 2020, 1:00 PM
schweitz closed D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jul 1 2020, 12:59 PM · Restricted Project, Restricted Project
schweitz created D82991: [flang] Add the Runtime.h to prepare for more code being upstreamed..
Jul 1 2020, 12:59 PM · Restricted Project, Restricted Project

Jun 30 2020

schweitz closed D82790: [flang] Coarray lowering.

Committed as bd2c3014e120949c4acc1d107ac71c4091f00a3d

Jun 30 2020, 8:39 AM · Restricted Project, Restricted Project

Jun 29 2020

schweitz updated the diff for D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jun 29 2020, 4:22 PM · Restricted Project, Restricted Project
schweitz committed rGbd2c3014e120: [flang] Add coarray lowering hooks. (authored by schweitz).
[flang] Add coarray lowering hooks.
Jun 29 2020, 2:26 PM
schweitz created D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jun 29 2020, 2:25 PM · Restricted Project, Restricted Project
schweitz created D82790: [flang] Coarray lowering.
Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project
schweitz added a comment to D82693: [flang] Upstream two FIR transformation passes.

In the passes files there are 6 pass creators declared. I failed to find all the definitions in this patch.
It seems sensible to split this into multiple commits. I would also recommend tests for new functionality.

[EDIT: Took too long to write my comments, seems abandoned now]

Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
schweitz abandoned D82693: [flang] Upstream two FIR transformation passes.
Jun 29 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2020

schweitz created D82693: [flang] Upstream two FIR transformation passes.
Jun 26 2020, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
schweitz committed rGc3477c51e599: [flang] Add CHARACTER type lowering helpers and runtime. (authored by schweitz).
[flang] Add CHARACTER type lowering helpers and runtime.
Jun 26 2020, 11:30 AM
schweitz closed D82608: [flang] upstream of CHARACTER helper and runtime lowering.
Jun 26 2020, 11:29 AM · Restricted Project, Restricted Project
schweitz accepted D82168: [flang] Port test_any.sh tests to FileCheck.

Did you remove the test_any.sh script in one of these?

Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82166: [flang] Port test_any.sh tests to FileCheck: Hand port getsymbols tests.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project
schweitz accepted D82167: [flang] Port test_any.sh tests to FileCheck: Hand port canondo{08-18} tests.
Jun 26 2020, 9:17 AM · Restricted Project, Restricted Project