Page MenuHomePhabricator

[AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store.
ClosedPublic

Authored by mbrkusanin on Tue, Oct 6, 2:26 AM.

Details

Summary

ExpandUnalignedLoad/Store can sometimes produce unnecessary copies to
temporary stack slot. We should prefer splitting vectors if possible.

Diff Detail

Event Timeline

mbrkusanin created this revision.Tue, Oct 6, 2:26 AM
mbrkusanin requested review of this revision.Tue, Oct 6, 2:26 AM

Could you pre-commit the test case?

mbrkusanin updated this revision to Diff 296437.Tue, Oct 6, 6:25 AM
  • Updated tests to reflect parent revision: D88895
mbrkusanin updated this revision to Diff 296457.Tue, Oct 6, 7:35 AM
mbrkusanin edited the summary of this revision. (Show Details)
  • Updated to reflect changes in parent revision.

LGTM. Please check with Matt too.

arsenm accepted this revision.Wed, Oct 7, 6:53 AM
This revision is now accepted and ready to land.Wed, Oct 7, 6:53 AM