Page MenuHomePhabricator

t-tye (Tony Tye)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2017, 6:01 PM (252 w, 21 h)

Recent Activity

Tue, Jan 18

t-tye committed rG8ba5043dbfb0: [AMDGPU][NFC] Add DWARF extension support for SIMD execution (authored by t-tye).
[AMDGPU][NFC] Add DWARF extension support for SIMD execution
Tue, Jan 18, 9:37 AM
t-tye closed D117572: [AMDGPU][NFC] Add DWARF extension support for SIMD execution.
Tue, Jan 18, 9:37 AM · Restricted Project
t-tye requested review of D117572: [AMDGPU][NFC] Add DWARF extension support for SIMD execution.
Tue, Jan 18, 9:26 AM · Restricted Project

Tue, Dec 28

t-tye committed rG0ac939f3e249: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging (authored by t-tye).
[AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging
Tue, Dec 28, 9:14 AM
t-tye closed D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
Tue, Dec 28, 9:14 AM · Restricted Project
t-tye committed rG4360207a219c: [AMDGPU][NFC] Update DWARF extension allowing locations on stack (authored by t-tye).
[AMDGPU][NFC] Update DWARF extension allowing locations on stack
Tue, Dec 28, 9:13 AM
t-tye closed D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
Tue, Dec 28, 9:12 AM · Restricted Project

Mon, Dec 27

t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Improve doument overview in first section.
  • Improve opening descrition of appendix A.
Mon, Dec 27, 3:49 PM · Restricted Project
t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.

Improve the summary of the extensions.

Mon, Dec 27, 3:40 PM · Restricted Project

Sun, Dec 26

t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
  • Add section numbers.
Sun, Dec 26, 2:39 PM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Add section numbers.
  • Other minor corrections.
Sun, Dec 26, 2:22 PM · Restricted Project
t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.

Additional corrections.

Sun, Dec 26, 10:34 AM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.

Additional corrections.

Sun, Dec 26, 10:34 AM · Restricted Project

Sat, Dec 25

t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.

Further corrections.

Sat, Dec 25, 7:16 PM · Restricted Project

Fri, Dec 24

t-tye requested review of D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
Fri, Dec 24, 4:53 PM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Remove mention of DW_OP_offset.
  • Other minor corrections.
Fri, Dec 24, 12:06 PM · Restricted Project
t-tye requested review of D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
Fri, Dec 24, 12:33 AM · Restricted Project

Dec 20 2021

t-tye committed rG0a3258febf2f: [AMDGPU][NFC] Update DWARF extension for locations on the stack (authored by t-tye).
[AMDGPU][NFC] Update DWARF extension for locations on the stack
Dec 20 2021, 9:59 PM
t-tye closed D116077: [AMDGPU][NFC] Update DWARF extension for locations on the stack.
Dec 20 2021, 9:58 PM · Restricted Project
t-tye requested review of D116077: [AMDGPU][NFC] Update DWARF extension for locations on the stack.
Dec 20 2021, 8:55 PM · Restricted Project

Dec 13 2021

t-tye committed rGc6be2ad73acb: [AMDGPU][NFC] Add documentation for location description DWARF extension (authored by t-tye).
[AMDGPU][NFC] Add documentation for location description DWARF extension
Dec 13 2021, 4:58 PM
t-tye closed D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.
Dec 13 2021, 4:58 PM · Restricted Project
t-tye updated the diff for D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.

Update review feedback from @scott.linder .

Dec 13 2021, 3:49 PM · Restricted Project

Dec 11 2021

t-tye requested review of D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.
Dec 11 2021, 4:02 PM · Restricted Project

Dec 7 2021

t-tye added a comment to D115229: [AMDGPU] In SIMemoryLegalizer assume all atomic ops have memoperands.

My understanding was that it was not guaranteed that an MI instruction has a MMO. That passes could drop the MMO. Are you saying that is not the case? As Matt says, if that is the case the verifier needs to enforce that.

Dec 7 2021, 7:06 PM · Restricted Project

Nov 25 2021

t-tye accepted D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.

LGTM

Nov 25 2021, 5:41 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 25 2021, 3:59 AM · Restricted Project

Nov 23 2021

t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 23 2021, 1:52 PM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 23 2021, 12:16 AM · Restricted Project

Nov 22 2021

t-tye requested changes to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 10:46 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 10:45 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 9:11 AM · Restricted Project

Nov 20 2021

t-tye added a comment to D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.

@tpr does this change break anything in LLPC?

Nov 20 2021, 12:59 PM · Restricted Project

Nov 17 2021

t-tye accepted D114076: [AMDGPU] Update GFX10 memory model to account for MALL.

LGTM

Nov 17 2021, 9:55 AM · Restricted Project

Aug 30 2021

t-tye added a comment to D108865: [AMDGPU] Use gcc pragmas to disable -Wtype-limits warning.

If LocalMemorySize is unsigned, how can it ever be less than 0? Shouldn't the code be corrected instead of adding pragmas?

Aug 30 2021, 6:30 PM · Restricted Project

Aug 19 2021

t-tye added inline comments to D108322: AMDGPU: Add options to override SGPR and VGPR blocks.
Aug 19 2021, 9:10 PM · Restricted Project

Aug 18 2021

t-tye added inline comments to D108322: AMDGPU: Add options to override SGPR and VGPR blocks.
Aug 18 2021, 8:28 PM · Restricted Project

Aug 10 2021

t-tye committed rG53eb469195b8: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer (authored by t-tye).
[AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer
Aug 10 2021, 1:44 AM
t-tye closed D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.
Aug 10 2021, 1:44 AM · Restricted Project
t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

Haven't looked at the test changes in detail, but code changes look fine.

Aug 10 2021, 1:39 AM · Restricted Project

Aug 7 2021

t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

@rampitec I believe the other changes do not change the behavior from the perspective of the C++ 20 standard.

Aug 7 2021, 3:46 PM · Restricted Project

Jul 30 2021

t-tye accepted D107190: [AMDGPU][HIP] Switch default DWARF version to 5.

LGTM

Jul 30 2021, 1:34 PM · Restricted Project

Jul 27 2021

t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

No testcases?

Jul 27 2021, 3:35 AM · Restricted Project
t-tye updated the diff for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

Remove unnecessary ()s.

Jul 27 2021, 3:32 AM · Restricted Project

Jul 26 2021

t-tye added a comment to D106338: Use GNUInstallDirs to define install locations for documentation.

I think the change itself LGTM, but I did a grep for GNUInstallDirs and it it only used in two other places currently. I suppose that means it is OK to use, but it does seem to imply there can be cases where we install to inconsistent locations. I don't know who to add to get more info on this, though?

Jul 26 2021, 4:10 PM · Restricted Project
t-tye added inline comments to D106736: Minor Sphinx documentation generation improvements.
Jul 26 2021, 4:07 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106736: Minor Sphinx documentation generation improvements.

Replaced comment with a trailing "Slash indicates contents of" comment as suggested by @scott.linder.

Jul 26 2021, 4:06 PM · Restricted Project, Restricted Project
t-tye added a reviewer for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer: arsenm.
Jul 26 2021, 8:37 AM · Restricted Project

Jul 24 2021

t-tye added inline comments to D106736: Minor Sphinx documentation generation improvements.
Jul 24 2021, 7:17 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106736: Minor Sphinx documentation generation improvements.

Remove mention of easy_install as deprecated. MacOS still appears to only come with easy_install.

Jul 24 2021, 7:13 PM · Restricted Project, Restricted Project

Jul 23 2021

t-tye added a comment to D106339: Add support to generate Sphinx DOCX documentation.

What's the benefit of having docx documentation? We generate HTML documentation, which ends up in the website, and that seems strictly superior to generating docx. What do you need it for?

The libc++ changes are almost trivial so I would not object to the change on that basis, however in general I think it's better to avoid adding support for things we won't be using on a regular basis.

Jul 23 2021, 8:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye updated the diff for D106339: Add support to generate Sphinx DOCX documentation.

Factor out documentation and CMake file changes unrelated to adding DOCX support to D106736.

Jul 23 2021, 7:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106736: Minor Sphinx documentation generation improvements.
Jul 23 2021, 7:47 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106339: Add support to generate Sphinx DOCX documentation.

Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734.

Jul 23 2021, 6:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106734: Eliminate clang man page generation warning for missing .rst files.
Jul 23 2021, 6:51 PM · Restricted Project, Restricted Project
t-tye added a reviewer for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer: efriedma.
Jul 23 2021, 5:49 PM · Restricted Project
t-tye requested review of D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.
Jul 23 2021, 5:09 PM · Restricted Project

Jul 19 2021

t-tye requested review of D106339: Add support to generate Sphinx DOCX documentation.
Jul 19 2021, 8:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106338: Use GNUInstallDirs to define install locations for documentation.
Jul 19 2021, 8:12 PM · Restricted Project
t-tye committed rG038602139db2: [NFC] Correct documentation error in OpenMP release ReleaseNotes (authored by t-tye).
[NFC] Correct documentation error in OpenMP release ReleaseNotes
Jul 19 2021, 7:05 PM
t-tye closed D106330: [NFC] Correct documentation error in OpenMP release ReleaseNotes.
Jul 19 2021, 7:05 PM · Restricted Project
t-tye requested review of D106330: [NFC] Correct documentation error in OpenMP release ReleaseNotes.
Jul 19 2021, 6:24 PM · Restricted Project
t-tye committed rG51e62e56f7ed: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x45 (authored by t-tye).
[AMDGPU] Reserve AMDGPU ELF e_flags machine 0x45
Jul 19 2021, 1:18 PM
t-tye closed D106249: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x45.
Jul 19 2021, 1:18 PM · Restricted Project

Jul 18 2021

t-tye requested review of D106249: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x45.
Jul 18 2021, 7:28 PM · Restricted Project

Jul 14 2021

t-tye committed rG53fed88159d0: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x44 (authored by t-tye).
[AMDGPU] Reserve AMDGPU ELF e_flags machine 0x44
Jul 14 2021, 11:47 PM
t-tye closed D106034: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x44.
Jul 14 2021, 11:47 PM · Restricted Project
t-tye requested review of D106034: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x44.
Jul 14 2021, 8:38 PM · Restricted Project

Jul 13 2021

t-tye added a comment to D105920: [AMDGPU] Init scratch only if necessary.

It is also not necessary to request the scratch SRD to be set up in the User SGPRs. There is a significant performance cost for small kernels to requesting this unneeded set of 4 SGPRs to be initialized by the hardware.

Jul 13 2021, 5:32 PM · Restricted Project
t-tye added inline comments to D105761: [lld][AMDGPU] Handle R_AMDGPU_REL16 relocation..
Jul 13 2021, 5:03 PM · Restricted Project

Jul 6 2021

t-tye committed rG8d69635ed9ec: [NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture (authored by t-tye).
[NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture
Jul 6 2021, 1:21 PM
t-tye closed D105377: [NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture.
Jul 6 2021, 1:21 PM · Restricted Project
t-tye added inline comments to D105507: AMDGPU: Add gfx10 assembler directive to specify shared VGPR count.
Jul 6 2021, 12:42 PM · Restricted Project

Jul 2 2021

t-tye retitled D105377: [NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture from [NFC][AMDGPU] Add link to AMD GPU gfx908 instruction set architecture to [NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture.
Jul 2 2021, 3:47 PM · Restricted Project
t-tye requested review of D105377: [NFC][AMDGPU] Add link to AMD GPU gfx906 instruction set architecture.
Jul 2 2021, 3:12 PM · Restricted Project

Jun 30 2021

t-tye added a comment to D105222: [AMDGPU][Docs] Update Code Object V3 example to includes args section.

My understanding of the documentation is that global_buffer causes the kernel launcher to put the argument into a buffer. Is that not the case?

Jun 30 2021, 9:17 PM · Restricted Project

Jun 29 2021

t-tye committed rG7f19aa73c265: [AMDGPU] Update gfx90a memory model support (authored by t-tye).
[AMDGPU] Update gfx90a memory model support
Jun 29 2021, 9:06 PM
t-tye closed D105137: [AMDGPU] Update gfx90a memory model support.
Jun 29 2021, 9:06 PM · Restricted Project
t-tye requested review of D105137: [AMDGPU] Update gfx90a memory model support.
Jun 29 2021, 10:59 AM · Restricted Project

Jun 24 2021

t-tye committed rGa1526af46466: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x43 (authored by t-tye).
[AMDGPU] Reserve AMDGPU ELF e_flags machine 0x43
Jun 24 2021, 3:53 PM
t-tye closed D104872: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x43.
Jun 24 2021, 3:53 PM · Restricted Project
t-tye accepted D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.

LGTM Thanks for documenting the differences.

Jun 24 2021, 2:03 PM · Restricted Project
t-tye requested review of D104872: [AMDGPU] Reserve AMDGPU ELF e_flags machine 0x43.
Jun 24 2021, 1:40 PM · Restricted Project

Jun 23 2021

t-tye added inline comments to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Jun 23 2021, 6:50 PM · Restricted Project

Jun 7 2021

t-tye added a comment to D103225: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers..

You probably need to wrap all prologue LDS stores into a block to execute it only from lane 0 and add a barrier after. @t-tye correct me if I am wrong.

But, I remember that we had decided to avoid barrier here, and instead just make sure that each thread within each wave execute the store instructions? In anycase, let me clarify it with @t-tye and @b-sumner.

I do not remember, but probably we can omit it since it is a singe store readonly memory. Anyway a confirmation from @t-tye would be nice.

For the record, the agreed way is to do a store from lane 0 of each wave and follow with a wave barrier.

Jun 7 2021, 8:27 PM · Restricted Project

May 21 2021

t-tye committed rG355114a7532d: [NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator (authored by t-tye).
[NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator
May 21 2021, 9:52 AM
t-tye closed D102859: [NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator.
May 21 2021, 9:52 AM · Restricted Project
t-tye committed rGb408efe4ffcd: [NFC][AMDGPU] Mark C code in AMDGPUUsage.rst (authored by t-tye).
[NFC][AMDGPU] Mark C code in AMDGPUUsage.rst
May 21 2021, 3:10 AM
t-tye closed D102910: [NFC][AMDGPU] Mark C code in AMDGPUUsage.rst.
May 21 2021, 3:09 AM · Restricted Project
t-tye requested review of D102910: [NFC][AMDGPU] Mark C code in AMDGPUUsage.rst.
May 21 2021, 2:56 AM · Restricted Project

May 20 2021

t-tye added a reviewer for D102859: [NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator: dp.
May 20 2021, 1:26 PM · Restricted Project
t-tye updated the diff for D102859: [NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator.

Add feedback from @dp .

May 20 2021, 1:26 PM · Restricted Project
t-tye requested changes to D102837: [AMDGPU][DOC][NFC] Added links to public description of MI100 ISA.

Can you review D102859 instead? I will add your change to that as well.

May 20 2021, 1:15 PM · Restricted Project
t-tye requested review of D102859: [NFC][AMDGPU] Add documentation for AMD Instinct MI100 accelerator.
May 20 2021, 11:48 AM · Restricted Project

May 19 2021

t-tye added a comment to D102691: [AMDGPU][Libomptarget] Remove global KernelNameMap.

I like the direction. Could we hold it for a day or so? I'd like to check through the uses of the kernel name to see if there's a missing edge case, or if we can simplify this a step further.

It looks like the msgpack data always contains the foo and the foo.kd strings, under different keys. I wonder if that's something we can rely on the compiler emitting.

May 19 2021, 1:12 AM · Restricted Project

May 18 2021

t-tye accepted D102708: AMDGPU/NFC: Replace EF_AMDGPU_MACH_AMDGCN_RESERVED_0X3E with EF_AMDGPU_MACH_AMDGCN_GFX1034.

This needs AMDGPUUsage to also be updated that these values are now reserved.

May 18 2021, 4:06 PM · Restricted Project
t-tye reopened D102708: AMDGPU/NFC: Replace EF_AMDGPU_MACH_AMDGCN_RESERVED_0X3E with EF_AMDGPU_MACH_AMDGCN_GFX1034.

This needs AMDGPUUsage to also be updated that these values are now reserved.

May 18 2021, 1:44 PM · Restricted Project

May 17 2021

t-tye accepted D102366: [AMDGPU] Do not check denorm for LDS FP atomic with unsafe flag.

LGTM

May 17 2021, 3:58 PM · Restricted Project

May 13 2021

t-tye accepted D102432: [AMDGPU] Add support for architected flat scratch.

The documentation parts LGTM.

May 13 2021, 2:38 PM · Restricted Project
t-tye added inline comments to D102432: [AMDGPU] Add support for architected flat scratch.
May 13 2021, 2:07 PM · Restricted Project