Page MenuHomePhabricator

mbrkusanin (Mirko Brkusanin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2019, 1:58 AM (101 w, 1 d)

Recent Activity

Today

mbrkusanin updated the diff for D95242: [AMDGPU][GlobalISel] Handle G_PTR_ADD when looking for constant offset.
  • Rebase and rename test
Wed, Jan 27, 9:25 AM · Restricted Project
mbrkusanin requested review of D95540: [AMDGPU][GlobalISel] Remove redundant cmp when copying constant to vcc.
Wed, Jan 27, 9:25 AM · Restricted Project

Yesterday

mbrkusanin committed rG608ac62540ad: [AMDGPU] Fix use of HasModifiers in VopProfile (authored by mbrkusanin).
[AMDGPU] Fix use of HasModifiers in VopProfile
Tue, Jan 26, 6:23 AM
mbrkusanin closed D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.
Tue, Jan 26, 6:23 AM · Restricted Project

Fri, Jan 22

mbrkusanin updated the summary of D95242: [AMDGPU][GlobalISel] Handle G_PTR_ADD when looking for constant offset.
Fri, Jan 22, 8:33 AM · Restricted Project
mbrkusanin requested review of D95242: [AMDGPU][GlobalISel] Handle G_PTR_ADD when looking for constant offset.
Fri, Jan 22, 8:32 AM · Restricted Project

Wed, Jan 20

mbrkusanin committed rGa6a72dfdf2e1: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants (authored by mbrkusanin).
[AMDGPU][GlobalISel] Avoid selecting S_PACK with constants
Wed, Jan 20, 2:56 AM
mbrkusanin closed D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.
Wed, Jan 20, 2:56 AM · Restricted Project
mbrkusanin added a comment to D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.

Do we really need HasModifiers if breaking this down to src modifiers and omod?

Wed, Jan 20, 2:28 AM · Restricted Project
mbrkusanin updated the diff for D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.
  • Undid few changes to fix disassemble tests.
Wed, Jan 20, 2:26 AM · Restricted Project

Fri, Jan 15

mbrkusanin added a comment to D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.

"HasModifiers should not be true if at least one modifier is used."

Do you mean "*should* be true"?

Fri, Jan 15, 9:22 AM · Restricted Project
mbrkusanin updated the summary of D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.
Fri, Jan 15, 9:22 AM · Restricted Project
mbrkusanin updated the diff for D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.

Rename + G_ANYEXT will now be treated same as G_SEXT instead of G_ZEXT.

Fri, Jan 15, 9:15 AM · Restricted Project
mbrkusanin added a comment to D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.

I would prefer to include HasClamp inside "field bit HasModifiers =" but VOPProfile allows clamp to be explicitly enabled through "bit _EnableClamp = 0" which still messes up the logic a little bit (like in class getIns64). Not sure if there is some other reason to keeping clamp separate from other modifiers.

Fri, Jan 15, 9:14 AM · Restricted Project
mbrkusanin requested review of D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.
Fri, Jan 15, 9:13 AM · Restricted Project

Dec 10 2020

mbrkusanin committed rG0c7cce54eba3: [AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2 (authored by mbrkusanin).
[AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2
Dec 10 2020, 3:50 AM
mbrkusanin closed D92767: [AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2.
Dec 10 2020, 3:50 AM · Restricted Project

Dec 8 2020

mbrkusanin added inline comments to D92767: [AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2.
Dec 8 2020, 1:55 AM · Restricted Project
mbrkusanin updated the diff for D92767: [AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2.
Dec 8 2020, 1:55 AM · Restricted Project

Dec 7 2020

mbrkusanin requested review of D92767: [AMDGPU] Resolve issues when picking between ds_read/write and ds_read2/write2.
Dec 7 2020, 7:50 AM · Restricted Project

Nov 27 2020

mbrkusanin added inline comments to D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.
Nov 27 2020, 5:58 AM · Restricted Project
mbrkusanin updated the summary of D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.
Nov 27 2020, 5:51 AM · Restricted Project
mbrkusanin updated the diff for D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.

Specific case from one of the tests:

%5:sgpr(s16) = G_FCONSTANT half 0xH4000
%7:sgpr(s32) = G_ANYEXT %5:sgpr(s16)
%4:sreg_32(<2 x s16>) = G_BUILD_VECTOR_TRUNC %7:sgpr(s32), %7:sgpr(s32)
Nov 27 2020, 5:26 AM · Restricted Project
mbrkusanin requested review of D92219: [AMDGPU][GlobalISel] Avoid selecting S_PACK with constants.
Nov 27 2020, 3:09 AM · Restricted Project

Nov 16 2020

mbrkusanin committed rG4cf6dd518ece: [AMDGPU][GlobalISel] Fix lowerShlSat (authored by mbrkusanin).
[AMDGPU][GlobalISel] Fix lowerShlSat
Nov 16 2020, 8:46 AM
mbrkusanin closed D91437: [AMDGPU][GlobalISel] Fix lowerShlSat.
Nov 16 2020, 8:46 AM · Restricted Project
mbrkusanin added inline comments to D91437: [AMDGPU][GlobalISel] Fix lowerShlSat.
Nov 16 2020, 8:29 AM · Restricted Project
mbrkusanin updated the diff for D91437: [AMDGPU][GlobalISel] Fix lowerShlSat.
Nov 16 2020, 8:29 AM · Restricted Project

Nov 13 2020

mbrkusanin requested review of D91437: [AMDGPU][GlobalISel] Fix lowerShlSat.
Nov 13 2020, 9:04 AM · Restricted Project

Nov 10 2020

mbrkusanin committed rGa75d6178b809: [GlobalISel] Add combine for (x | mask) -> x when (x | mask) == x (authored by mbrkusanin).
[GlobalISel] Add combine for (x | mask) -> x when (x | mask) == x
Nov 10 2020, 2:38 AM
mbrkusanin closed D90952: [GlobalISel] Add combine for (x | mask) -> x when (x | mask) == x.
Nov 10 2020, 2:38 AM · Restricted Project
mbrkusanin committed rGfb36ab0a42f4: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x (authored by mbrkusanin).
[GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x
Nov 10 2020, 2:38 AM
mbrkusanin closed D90674: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x.
Nov 10 2020, 2:37 AM · Restricted Project
mbrkusanin committed rG53ae95c946c0: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands (authored by mbrkusanin).
[AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands
Nov 10 2020, 2:37 AM
mbrkusanin closed D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
Nov 10 2020, 2:37 AM · Restricted Project
mbrkusanin committed rGde719586a8fa: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant… (authored by mbrkusanin).
[AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant…
Nov 10 2020, 2:37 AM
mbrkusanin closed D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
Nov 10 2020, 2:37 AM · Restricted Project
mbrkusanin updated the diff for D90952: [GlobalISel] Add combine for (x | mask) -> x when (x | mask) == x.
  • Rename
  • Updated comments
Nov 10 2020, 2:36 AM · Restricted Project
mbrkusanin updated the diff for D90674: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x.
  • Renamed
  • Updated comments
Nov 10 2020, 2:36 AM · Restricted Project
mbrkusanin updated the diff for D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
  • Rebase
Nov 10 2020, 2:35 AM · Restricted Project
mbrkusanin updated the diff for D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
  • Rebase
  • Updated comments
Nov 10 2020, 2:35 AM · Restricted Project

Nov 6 2020

mbrkusanin added inline comments to D90674: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x.
Nov 6 2020, 8:54 AM · Restricted Project
mbrkusanin requested review of D90952: [GlobalISel] Add combine for (x | mask) -> x when (x | mask) == x.
Nov 6 2020, 8:50 AM · Restricted Project
mbrkusanin updated the diff for D90674: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x.
  • Refactored match function
  • Updated tests
Nov 6 2020, 8:50 AM · Restricted Project
mbrkusanin updated the diff for D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
  • Rebase
Nov 6 2020, 8:50 AM · Restricted Project
mbrkusanin updated the diff for D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
  • Avoid combine for G_USHLSAT when sum exceeds scalar size.
Nov 6 2020, 8:50 AM · Restricted Project

Nov 3 2020

mbrkusanin requested review of D90674: [GlobalISel] Expand combine for (x & mask) -> x when (x & mask) == x.
Nov 3 2020, 2:51 AM · Restricted Project
mbrkusanin updated the diff for D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
  • Updated comments.
Nov 3 2020, 2:51 AM · Restricted Project
mbrkusanin updated the diff for D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
  • Fix handling of G_SSHLSAT and G_USHLSAT.
  • Removed new MachineIRBuilder.
Nov 3 2020, 2:51 AM · Restricted Project

Oct 30 2020

mbrkusanin updated the diff for D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
  • Supported G_SSHLSAT and G_USHLSAT and addressed other comments.
  • Added .mir test for G_SSHLSAT and G_USHLSAT.
Oct 30 2020, 9:16 AM · Restricted Project
mbrkusanin updated the diff for D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
  • Using RegisterImmPair, removed ShiftChain struct.
  • Supported G_SSHLSAT and G_USHLSAT.
  • Added .mir tests
Oct 30 2020, 9:14 AM · Restricted Project

Oct 27 2020

mbrkusanin updated the diff for D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
  • clang-format
Oct 27 2020, 6:37 AM · Restricted Project
mbrkusanin added inline comments to D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
Oct 27 2020, 6:08 AM · Restricted Project
mbrkusanin updated the diff for D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
  • Addressed review comments.
  • Updated comment at the start of match function.
Oct 27 2020, 6:08 AM · Restricted Project
mbrkusanin added a comment to D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.

This patch is basically a global-isel version of combineShiftOfShiftedLogic() from DAGCombiner.

Oct 27 2020, 4:46 AM · Restricted Project
mbrkusanin requested review of D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands.
Oct 27 2020, 4:41 AM · Restricted Project
mbrkusanin retitled D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands from [GlobalISel] Fold a chain of two shift instructions with constant operands to [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
Oct 27 2020, 4:14 AM · Restricted Project
mbrkusanin requested review of D90217: [AMDGPU][GlobalISel] Fold a chain of two shift instructions with constant operands.
Oct 27 2020, 3:59 AM · Restricted Project

Oct 13 2020

mbrkusanin committed rG52ba4fa6aa21: [GlobalISel] Avoid making G_PTR_ADD with nullptr (authored by mbrkusanin).
[GlobalISel] Avoid making G_PTR_ADD with nullptr
Oct 13 2020, 4:04 AM
mbrkusanin closed D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
Oct 13 2020, 4:04 AM · Restricted Project
mbrkusanin updated the diff for D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
  • Addressed comments.
Oct 13 2020, 2:55 AM · Restricted Project
mbrkusanin updated the diff for D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
  • Rebase
  • Ping
Oct 13 2020, 1:59 AM · Restricted Project

Oct 8 2020

mbrkusanin committed rG7c88d13fd1c1: [AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store (authored by mbrkusanin).
[AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store
Oct 8 2020, 1:25 AM
mbrkusanin committed rG380087e6c9a2: [AMDGPU] Add test with redundant copies to temporary stack slot produced by… (authored by mbrkusanin).
[AMDGPU] Add test with redundant copies to temporary stack slot produced by…
Oct 8 2020, 1:25 AM
mbrkusanin closed D88882: [AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store..
Oct 8 2020, 1:25 AM · Restricted Project
mbrkusanin closed D88895: [AMDGPU] Add test with redundant copies to temporary stack slot produced by expandUnalignedLoad.
Oct 8 2020, 1:24 AM · Restricted Project

Oct 6 2020

mbrkusanin updated the diff for D88882: [AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store..
  • Updated to reflect changes in parent revision.
Oct 6 2020, 7:35 AM · Restricted Project
mbrkusanin updated the diff for D88895: [AMDGPU] Add test with redundant copies to temporary stack slot produced by expandUnalignedLoad.

I used "Spilling" as a term for storing and restoring of values regardless of who/what is causing it. But I guess we should be precise.

Oct 6 2020, 7:34 AM · Restricted Project
mbrkusanin updated the diff for D88882: [AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store..
  • Updated tests to reflect parent revision: D88895
Oct 6 2020, 6:25 AM · Restricted Project
mbrkusanin requested review of D88895: [AMDGPU] Add test with redundant copies to temporary stack slot produced by expandUnalignedLoad.
Oct 6 2020, 6:22 AM · Restricted Project
mbrkusanin requested review of D88882: [AMDGPU] Prefer SplitVectorLoad/Store over expandUnalignedLoad/Store..
Oct 6 2020, 2:26 AM · Restricted Project

Sep 30 2020

mbrkusanin committed rG0249df33fec1: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer (authored by mbrkusanin).
[AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer
Sep 30 2020, 2:16 AM
mbrkusanin closed D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
Sep 30 2020, 2:16 AM · Restricted Project

Sep 29 2020

mbrkusanin updated the diff for D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
  • Refactored matchPtrAddZero().
Sep 29 2020, 7:53 AM · Restricted Project
mbrkusanin updated the diff for D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
  • Updated opt test check lines.
Sep 29 2020, 7:34 AM · Restricted Project
mbrkusanin added inline comments to D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
Sep 29 2020, 7:01 AM · Restricted Project
mbrkusanin updated the diff for D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
  • Updated llc test check lines.
Sep 29 2020, 7:00 AM · Restricted Project
mbrkusanin added a reverting change for rGf5cd7ec9f3fc: [AMDGPU] Reorganize GCN subtarget features for unaligned access: rG8b08fa0103c8: Revert "[AMDGPU] Reorganize GCN subtarget features for unaligned access".
Sep 29 2020, 6:36 AM
mbrkusanin committed rG8b08fa0103c8: Revert "[AMDGPU] Reorganize GCN subtarget features for unaligned access" (authored by mbrkusanin).
Revert "[AMDGPU] Reorganize GCN subtarget features for unaligned access"
Sep 29 2020, 6:36 AM
mbrkusanin added a reverting change for D84522: [AMDGPU] Reorganize GCN subtarget features for unaligned access: rG8b08fa0103c8: Revert "[AMDGPU] Reorganize GCN subtarget features for unaligned access".
Sep 29 2020, 6:36 AM · Restricted Project

Sep 28 2020

mbrkusanin updated the diff for D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
  • Added buildMul that checks for mul with 1.
Sep 28 2020, 8:11 AM · Restricted Project
mbrkusanin added inline comments to D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
Sep 28 2020, 7:50 AM · Restricted Project
mbrkusanin updated the diff for D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
  • Changed test to opt + llc global-isel (SDag was already removing these mul instructions, just later on). Should I split the file into two tests?
Sep 28 2020, 7:49 AM · Restricted Project

Sep 25 2020

mbrkusanin requested review of D88315: [AMDGPU] Do not generate mul with 1 in AMDGPU Atomic Optimizer.
Sep 25 2020, 9:10 AM · Restricted Project
mbrkusanin updated the diff for D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
Sep 25 2020, 9:04 AM · Restricted Project

Sep 18 2020

mbrkusanin committed rGae36c02ad0cb: [AMDGPU] Set DS alignment requirements to be more strict (authored by mbrkusanin).
[AMDGPU] Set DS alignment requirements to be more strict
Sep 18 2020, 6:28 AM
mbrkusanin closed D87821: [AMDGPU] Set DS alignment requirements to be more strict.
Sep 18 2020, 6:28 AM · Restricted Project
mbrkusanin updated the diff for D87821: [AMDGPU] Set DS alignment requirements to be more strict.
Sep 18 2020, 5:07 AM · Restricted Project

Sep 17 2020

mbrkusanin updated the diff for D87821: [AMDGPU] Set DS alignment requirements to be more strict.
  • Added run line with -mattr=+unaligned-access-mode to test/CodeGen/AMDGPU/GlobalISel/legalize-load-local.mir
Sep 17 2020, 7:40 AM · Restricted Project
mbrkusanin updated the diff for D87821: [AMDGPU] Set DS alignment requirements to be more strict.
  • Removed dword-access-mode from tests.
Sep 17 2020, 6:48 AM · Restricted Project
mbrkusanin added inline comments to D87821: [AMDGPU] Set DS alignment requirements to be more strict.
Sep 17 2020, 6:47 AM · Restricted Project
mbrkusanin added a comment to D87821: [AMDGPU] Set DS alignment requirements to be more strict.

This helps vulkan gfx9 windows tests.

Sep 17 2020, 2:54 AM · Restricted Project
mbrkusanin requested review of D87821: [AMDGPU] Set DS alignment requirements to be more strict.
Sep 17 2020, 2:53 AM · Restricted Project

Sep 16 2020

mbrkusanin updated the diff for D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
  • Reimplemented as a AMDGPU GICombineRule.
Sep 16 2020, 5:40 AM · Restricted Project

Sep 9 2020

mbrkusanin closed D87093: [AMDGPU] Workaround for LDS Misalignment bug on GFX10.

43af2a6faa272565cde4e3eec7dfeac593d29701

Sep 9 2020, 2:53 AM · Restricted Project
mbrkusanin committed rG43af2a6faa27: [AMDGPU] Workaround for LDS Misalignment bug on GFX10 (authored by mbrkusanin).
[AMDGPU] Workaround for LDS Misalignment bug on GFX10
Sep 9 2020, 2:48 AM

Sep 8 2020

mbrkusanin updated the diff for D87093: [AMDGPU] Workaround for LDS Misalignment bug on GFX10.
  • Added FeatureLdsMisalignedBug to GFX 10.1.1
Sep 8 2020, 2:55 AM · Restricted Project

Sep 4 2020

mbrkusanin requested review of D87140: [GlobalISel] Avoid making G_PTR_ADD with nullptr.
Sep 4 2020, 6:04 AM · Restricted Project
mbrkusanin added a comment to D87093: [AMDGPU] Workaround for LDS Misalignment bug on GFX10.

Can you add a comment to hasLDSMisalignedBug with what specifically is broken? Is b64 broken too?

Sep 4 2020, 5:23 AM · Restricted Project
mbrkusanin updated the diff for D87093: [AMDGPU] Workaround for LDS Misalignment bug on GFX10.
  • Updated description of FeatureLdsMisalignedBug to match what is covered by tests.
Sep 4 2020, 5:22 AM · Restricted Project