This is an archive of the discontinued LLVM Phabricator instance.

[mlir][shape] Add `shape.cstr_require %bool`
ClosedPublic

Authored by silvas on Sep 17 2020, 4:26 PM.

Details

Summary

This op is a catch-all for creating witnesses from various random kinds of constraints. In particular, when dealing with extents directly, which are of index type, one can directly use std ops for calculating the predicates, and then use cstr_require for the final conversion to a
witness.

Diff Detail

Unit TestsFailed

Event Timeline

silvas created this revision.Sep 17 2020, 4:26 PM
Herald added a project: Restricted Project. · View Herald Transcript
silvas requested review of this revision.Sep 17 2020, 4:26 PM
silvas updated this revision to Diff 292657.EditedSep 17 2020, 4:27 PM

update

jpienaar edited the summary of this revision. (Show Details)Sep 17 2020, 4:29 PM
jpienaar accepted this revision.Sep 17 2020, 4:34 PM

Thanks, I am tempted to suggest we add "use this only if more specific form is not available" (e.g., use this for cases not expressible with the others). So that we push to simpler forms.

This revision is now accepted and ready to land.Sep 17 2020, 4:34 PM
silvas updated this revision to Diff 292661.Sep 17 2020, 4:40 PM

+1, added some verbiage to that effect

Harbormaster completed remote builds in B72102: Diff 292657.
This revision was landed with ongoing or failed builds.Sep 17 2020, 4:57 PM
This revision was automatically updated to reflect the committed changes.