This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Linalg] Integration tests for convolutions added.
ClosedPublic

Authored by limo1996 on Sep 8 2020, 4:27 AM.

Details

Summary

This commit introduces end-to-end integration tests for
convolutions that test multiple ways of ConvOps lowering.

Diff Detail

Event Timeline

limo1996 created this revision.Sep 8 2020, 4:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
limo1996 requested review of this revision.Sep 8 2020, 4:27 AM
nicolasvasilache accepted this revision.Sep 9 2020, 3:03 AM
This revision is now accepted and ready to land.Sep 9 2020, 3:03 AM
This revision was automatically updated to reflect the committed changes.

Thanks for adding more tests to this suite.

A minor nit, per our discussion in the forum we decided on the directory structure

mlir/integration_test/Dialect/XX/CPU/*

for XX dialect CPU tests, so the Conv should really have been CPU. But it is perhaps questionable if we will see non-CPU tests here, so I am okay with this naming structure too.