This is an archive of the discontinued LLVM Phabricator instance.

[KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries
ClosedPublic

Authored by dmm9 on Sep 6 2020, 4:58 AM.

Details

Summary

Add PRIVATE keyword in target_link_libraries to prevent CMake Error on Windows.

While trying to compile llvm/clang on Windows, the following CMake error occurred. The reason is a missing PUBLIC/PRIVATE/INTERFACE keyword in target_link_libraries.

`
CMake Error at utils/KillTheDoctor/CMakeLists.txt:5 (target_link_libraries):

The keyword signature for target_link_libraries has already been used with
the target "KillTheDoctor".  All uses of target_link_libraries with a
target must be either all-keyword or all-plain.

The uses of the keyword signature are here:

 * cmake/modules/AddLLVM.cmake:771 (target_link_libraries)

`

Diff Detail

Event Timeline

dmm9 created this revision.Sep 6 2020, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2020, 4:58 AM
dmm9 requested review of this revision.Sep 6 2020, 4:58 AM
dmm9 edited the summary of this revision. (Show Details)Sep 7 2020, 4:11 AM
dmm9 edited reviewers, added: tambre; removed: thakis.
tambre accepted this revision.Sep 7 2020, 4:54 AM

LGTM

This revision is now accepted and ready to land.Sep 7 2020, 4:54 AM
tambre added a comment.Sep 7 2020, 5:47 AM

Do you need me to land this for you, as I presume you lack the commit privileges?

dmm9 added a comment.Sep 7 2020, 5:48 AM

Thanks for the review. Yes, I do not have commit rights.

tambre added a comment.Sep 7 2020, 6:03 AM

Thanks for the review. Yes, I do not have commit rights.

Under what name and email address would you like this to be committed? Phabricator doesn't seem to provide this information when trying to land a patch.

dmm9 added a comment.Sep 7 2020, 6:06 AM

You can take the name from my profile and email is 'danyable' in the gmail domain.