Page MenuHomePhabricator

tambre (Raul Tambre)
Software Developer @ Cleveron AS

Projects

User does not belong to any projects.

User Details

User Since
May 4 2019, 1:33 AM (102 w, 10 h)

Recent Activity

Mon, Apr 12

tambre added a comment to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Summary also looks good. đź‘Ť
You probably don't need to wait for more approvals.

Mon, Apr 12, 12:36 AM · Restricted Project
tambre accepted D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Thanks, LGTM! Probably worth mentioning what I had in my comment in the commit message.

Mon, Apr 12, 12:30 AM · Restricted Project

Sat, Apr 10

tambre added inline comments to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..
Sat, Apr 10, 9:42 AM · Restricted Project

Fri, Apr 9

tambre added a comment to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

The fact that Clang chooses to (explicitly) forget about a builtin in SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't fully understand how the builtin mechanism is supposed to work.
@rsmith and @tambre, git history showed me you have more experience in this area and touched some of that code before, so hopefully you can give me some good feedback!

Fri, Apr 9, 9:55 AM · Restricted Project

Mon, Apr 5

tambre abandoned D99886: [CMake] Propagate static extensions to LLVMExtensions object library.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

I'm planning to revert d66f9c4f1e along with 43ceb74eb. I"m just waiting for my test build to finish.

Mon, Apr 5, 9:11 AM · Restricted Project
tambre added a comment to D99886: [CMake] Propagate static extensions to LLVMExtensions object library.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

Mon, Apr 5, 9:00 AM · Restricted Project
tambre requested review of D99886: [CMake] Propagate static extensions to LLVMExtensions object library.
Mon, Apr 5, 8:58 AM · Restricted Project

Mar 7 2021

tambre added a comment to D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.

The fix resolves the issue on my environment. Thank you for the quick response!

Mar 7 2021, 11:48 PM · Restricted Project
tambre committed rGba860963b156: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non… (authored by tambre).
[CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non…
Mar 7 2021, 11:11 PM
tambre closed D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.
Mar 7 2021, 11:10 PM · Restricted Project

Mar 6 2021

tambre resigned from D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
Mar 6 2021, 1:49 AM · Restricted Project, Restricted Project
tambre added a comment to D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.

@ikudrin Thanks for the report on D93278. Could you give this patch a try?

Mar 6 2021, 1:49 AM · Restricted Project
tambre requested review of D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.
Mar 6 2021, 1:48 AM · Restricted Project
tambre committed rG10a7289649cf: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f… (authored by tambre).
[runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f…
Mar 6 2021, 1:35 AM
tambre closed D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 6 2021, 1:35 AM · Restricted Project

Mar 3 2021

tambre added inline comments to D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 3 2021, 8:58 AM · Restricted Project
tambre updated the diff for D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).

Move ARG_TARGET_TRIPLE block down to simplify code.

Mar 3 2021, 8:58 AM · Restricted Project
tambre requested review of D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 3 2021, 6:32 AM · Restricted Project

Feb 8 2021

tambre accepted D96259: [AArch64] Use '//' as comment string for MSVC assembly.

Thanks! Maybe worth a changelog entry?

Feb 8 2021, 8:11 AM · Restricted Project

Feb 6 2021

tambre added a comment to rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

Thanks for the background.

Feb 6 2021, 11:52 PM
tambre updated subscribers of rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….
Feb 6 2021, 9:58 AM
tambre updated subscribers of rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

Hi Raul,

I'm seeing this only on aarch64-windows-msvc target, and not on any aarch64-linux-gnu targets. The command line is below, but I'm not sure you'll reproduce the problem outside of Windows environment.

C:\Users\tcwg\source\llvm-package\bin\clang-cl.exe /nologo -DHAS_ASM_LSE -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -DSTDC_CONSTANT_MACROS -DSTDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DL_cas -DMODEL=3 -DSIZE=2 -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\compiler-rt\lib\builtins -Iprojects\compiler-rt\lib\builtins -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\compiler-rt\lib\builtins -Iinclude -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\llvm\include -march=armv8-a -DCOMPILER_RT_HAS_FLOAT16 /showIncludes /Foprojects\compiler-rt\lib\builtins\CMakeFiles\clang_rt.builtins-aarch64.dir\outline_atomic_helpers.dir\outline_atomic_cas2_3.S.obj /Fdprojects\compiler-rt\lib\builtins\CMakeFiles\clang_rt.builtins-aarch64.dir\clang_rt.builtins-aarch64.pdb -c -- projects\compiler-rt\lib\builtins\outline_atomic_helpers.dir\outline_atomic_cas2_3.S

Feb 6 2021, 1:02 AM

Feb 5 2021

tambre added a comment to rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

@tambre
Hi Raul,

I'm troubleshooting LLVM build on Windows on Arm, which is currently failing with
...
<unknown>:0: error: this directive must appear between .cfi_startproc and .cfi_endproc directives
...
when building LSE builtins. It seems that clang-cl.exe, which, presumably, uses masm parser falls over when .cfi_startproc is not at the beginning of the line. Reverting this patch and re-instating the workaround solves the problem.

Looking at https://reviews.llvm.org/rG039cb03dd0dcff4daa17a062f7414ac22bf5f2eb I don't understand how that fixes the problem of masm parser. Could you explain how it is supposed to work, please?

Thanks!

Feb 5 2021, 5:17 AM

Jan 19 2021

tambre committed rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre).
[CMake] Remove dead code setting policies to NEW
Jan 19 2021, 7:20 AM
tambre closed D94374: [CMake] Remove dead code setting policies to NEW.
Jan 19 2021, 7:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 17 2021

tambre added a comment to D94374: [CMake] Remove dead code setting policies to NEW.

ldionne: ping

Jan 17 2021, 11:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 11 2021

tambre added inline comments to D94374: [CMake] Remove dead code setting policies to NEW.
Jan 11 2021, 10:03 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tambre updated the diff for D94374: [CMake] Remove dead code setting policies to NEW.

Don't modify third-party checked-in libraries.

Jan 11 2021, 10:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 10 2021

tambre added a reviewer for D94374: [CMake] Remove dead code setting policies to NEW: ldionne.

ldionne: for libc++ review

Jan 10 2021, 11:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tambre requested review of D94374: [CMake] Remove dead code setting policies to NEW.
Jan 10 2021, 4:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 8 2021

tambre committed rG840a2c978374: [CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set (authored by tambre).
[CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set
Jan 8 2021, 11:24 AM
tambre closed D94326: [CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set.
Jan 8 2021, 11:24 AM · Restricted Project
tambre requested review of D94326: [CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set.
Jan 8 2021, 11:24 AM · Restricted Project
tambre committed rGd9ce31ae7d1f: Re-land "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build… (authored by tambre).
Re-land "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build…
Jan 8 2021, 10:26 AM
tambre closed D94322: Re-land "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 10:26 AM · Restricted Project
tambre added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

Sorry for the breakage.
I reverted (D94319) and now re-landed (D94322). Seems the check for empty CMAKE_BUILD_RPATH got incorrectly reverted when I addressed the review comment.

Jan 8 2021, 10:25 AM · Restricted Project
tambre requested review of D94322: Re-land "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 10:22 AM · Restricted Project
tambre added a reverting change for D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath: rG913c430403b5: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build….
Jan 8 2021, 10:00 AM · Restricted Project
tambre added a reverting change for rG0ebc1fb29f27: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath: rG913c430403b5: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build….
Jan 8 2021, 10:00 AM
tambre committed rG913c430403b5: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build… (authored by tambre).
Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build…
Jan 8 2021, 9:59 AM
tambre closed D94319: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 9:59 AM · Restricted Project
tambre added a reverting change for rG0ebc1fb29f27: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath: D94319: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 9:59 AM
tambre requested review of D94319: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 9:58 AM · Restricted Project
tambre added a reverting change for D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath: D94319: Revert "[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath".
Jan 8 2021, 9:58 AM · Restricted Project

Jan 7 2021

tambre committed rG0ebc1fb29f27: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath (authored by tambre).
[CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath
Jan 7 2021, 10:31 PM
tambre closed D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.
Jan 7 2021, 10:31 PM · Restricted Project
tambre added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

This is fine with me, but I wonder we should avoid setting this property for every target and instead rely on CMAKE_BUILD_WITH_INSTALL_RPATH (we could set CMAKE_BUILD_WITH_INSTALL_RPATH to ON if unset to preserve the current behavior).

Jan 7 2021, 2:47 AM · Restricted Project
tambre updated the diff for D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

Avoid extra variable

Jan 7 2021, 2:38 AM · Restricted Project

Jan 5 2021

tambre added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

ping

Jan 5 2021, 10:38 PM · Restricted Project

Dec 20 2020

tambre added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

ping

Dec 20 2020, 10:14 PM · Restricted Project

Dec 18 2020

tambre added inline comments to D93523: [DSE] Use correct memory location for read clobber check.
Dec 18 2020, 12:27 PM · Restricted Project

Dec 16 2020

tambre added a comment to D93278: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

Early heads-up: We're seeing compile errors on our arm64 bots that might be due to this change: https://bugs.chromium.org/p/chromium/issues/detail?id=1159420

I'll verify locally and make a stand-alone repro. (It's possible that I'll find it's not due to this change while doing this.)

Dec 16 2020, 7:38 AM · Restricted Project
tambre added a comment to D93390: [compiler-rt] [builtins] Fix name of __aarch64_have_lse_atomics on Darwin.

The one in cpu_model.c has 2 underscores. Where do the three come from for non-Apple?

Dec 16 2020, 3:58 AM · Restricted Project
tambre added a reverting change for rG3000c19df64f: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.: rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….
Dec 16 2020, 12:22 AM
tambre committed rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser… (authored by tambre).
Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser…
Dec 16 2020, 12:22 AM
tambre added a reverting change for D93236: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.: rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….
Dec 16 2020, 12:22 AM · Restricted Project
tambre closed D93379: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.".
Dec 16 2020, 12:22 AM · Restricted Project
tambre added a reverting change for rG3000c19df64f: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.: D93379: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.".
Dec 16 2020, 12:17 AM
tambre requested review of D93379: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.".
Dec 16 2020, 12:17 AM · Restricted Project
tambre added a reverting change for D93236: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.: D93379: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.".
Dec 16 2020, 12:17 AM · Restricted Project
tambre accepted D93378: [builtins] Use %% as the separator for aarch64-*-darwin and ; for powerpc{32,64}.

Fixes the issue, thanks! I'll revert the workaround once this lands.

Dec 16 2020, 12:11 AM · Restricted Project

Dec 15 2020

tambre added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

I am confused. Did you mean that with this patch clang -S generated assembly has a straying .cfi_endproc ?

Dec 15 2020, 11:25 PM · Restricted Project
tambre committed rG95bfd0849f7f: [PGO] Allow overriding -vp-counters-per-site (authored by tambre).
[PGO] Allow overriding -vp-counters-per-site
Dec 15 2020, 9:03 AM
tambre closed D93281: [PGO] Allow overriding -vp-counters-per-site.
Dec 15 2020, 9:03 AM · Restricted Project
tambre updated subscribers of D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

CC'ing @epastor as a FYI for the assembly parser bug.

Pretty sure the issue you're hitting will be in AsmParser, not MasmParser - you're not using MASM here, you're using GNU-style assembly.

But - the bug will be the same regardless. I'm not sure who the right expert is on AsmParser at the moment?

Dec 15 2020, 7:39 AM · Restricted Project

Dec 14 2020

tambre added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

I can add "cl::ZeroOrMore" to "-vp-counters-per-site". Would it be good?

Dec 14 2020, 10:43 PM · Restricted Project
tambre requested review of D93281: [PGO] Allow overriding -vp-counters-per-site.
Dec 14 2020, 10:42 PM · Restricted Project
tambre committed rGa72d462eb9b9: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins… (authored by tambre).
Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins…
Dec 14 2020, 10:18 PM
tambre closed D93278: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 10:18 PM · Restricted Project
tambre requested review of D93278: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 10:17 PM · Restricted Project
tambre committed rG3000c19df64f: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug. (authored by tambre).
[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug.
Dec 14 2020, 10:15 PM
tambre closed D93236: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug..
Dec 14 2020, 10:14 PM · Restricted Project
tambre accepted D93236: [Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug..

Thanks! I'll land this along with my fix.

Dec 14 2020, 10:14 PM · Restricted Project
tambre added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

In my case 1.5 is better, but not enough. 2.0 is good and is what I've used so far. However, -vp-counters-per-site can only be specified once so this has broken my builds and I've patched it out for now.
Could we maybe parameterize this or add an option to turn it off?

Dec 14 2020, 9:30 AM · Restricted Project
tambre updated subscribers of D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

CC'ing @epastor as a FYI for the assembly parser bug.

Dec 14 2020, 9:13 AM · Restricted Project
tambre added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

Could we revert this until we have a fix for the errors showing up on Darwin?

Dec 14 2020, 9:10 AM · Restricted Project
tambre committed rGc21df2a79c26: Revert "Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE… (authored by tambre).
Revert "Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE…
Dec 14 2020, 8:44 AM
tambre closed D93228: Revert "Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately"".
Dec 14 2020, 8:44 AM · Restricted Project
tambre updated the summary of D93228: Revert "Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately"".
Dec 14 2020, 8:43 AM · Restricted Project
tambre requested review of D93228: Revert "Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately"".
Dec 14 2020, 8:42 AM · Restricted Project
tambre added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv D92530 helped, but CFI start and end directives still seem to cause problems. Any ideas?

Dec 14 2020, 7:49 AM · Restricted Project
tambre committed rGd0797e62fa8a: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins… (authored by tambre).
Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins…
Dec 14 2020, 6:46 AM
tambre closed D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 6:45 AM · Restricted Project
tambre requested review of D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 6:43 AM · Restricted Project
tambre committed rGaa772fc85e0f: [compiler-rt] [builtins] Make lse.S compile on Darwin (authored by kubamracek).
[compiler-rt] [builtins] Make lse.S compile on Darwin
Dec 14 2020, 6:39 AM
tambre closed D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin.
Dec 14 2020, 6:39 AM · Restricted Project
tambre added a comment to D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Fix for lse.S is not landed yet: https://reviews.llvm.org/D92530

Dec 14 2020, 3:05 AM · Restricted Project
tambre committed rG55f07a340070: [XRay] Remove unnecessary <x86intrin.h> include (authored by tambre).
[XRay] Remove unnecessary <x86intrin.h> include
Dec 14 2020, 2:36 AM
tambre closed D93196: [XRay] Remove unnecessary <x86intrin.h> include.
Dec 14 2020, 2:36 AM · Restricted Project
tambre added a comment to D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Dec 14 2020, 1:45 AM · Restricted Project
tambre committed rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins… (authored by tambre).
Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins…
Dec 14 2020, 1:42 AM
tambre added a reverting change for rGd9697c2e6b15: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available: rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….
Dec 14 2020, 1:42 AM
tambre added a reverting change for rG33b740f8dc34: [CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately: rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….
Dec 14 2020, 1:42 AM
tambre closed D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 1:42 AM · Restricted Project
tambre added a reverting change for D93198: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available: rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….
Dec 14 2020, 1:42 AM · Restricted Project
tambre added a reverting change for D93178: [CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately: rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….
Dec 14 2020, 1:42 AM · Restricted Project
tambre added a reverting change for rG33b740f8dc34: [CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately: D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 1:42 AM
tambre added a reverting change for rGd9697c2e6b15: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available: D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 1:42 AM
tambre requested review of D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 1:42 AM · Restricted Project
tambre added a reverting change for D93178: [CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately: D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".
Dec 14 2020, 1:42 AM · Restricted Project