Page MenuHomePhabricator

tambre (Raul Tambre)
Software Developer @ Cleveron AS

Projects

User does not belong to any projects.

User Details

User Since
May 4 2019, 1:33 AM (82 w, 2 d)

Recent Activity

Sat, Nov 28

tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Thanks! I didn't see any mention of that here so I assumed it wasn't backported without checking.

Sat, Nov 28, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

@tstellar, can we have this in 11.0.1? I've already ported it back in openSUSE because we were having problems with the CMake 3.19 update.

Sat, Nov 28, 9:01 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 16

tambre added a comment to D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

Will this go to the 11.x release branch? We hit the crash that this fixes on 11.0.0.

Mon, Nov 16, 9:48 PM · Restricted Project

Oct 22 2020

tambre added a comment to D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..

I echo @tra's concerns.
Having an option for a vendor to append/prepend a toolkit search location seems useful, but currently this seems more like a workaround for an explicit CUDA toolkit path not being passed to the testsuite.
Shortcomings in the testrunner don't seem like a reason to introduce new build-time configured default search paths into the driver.

Oct 22 2020, 11:04 AM · Restricted Project, Restricted Project

Sep 29 2020

tambre added a comment to D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet..

LGTM

Sep 29 2020, 9:34 PM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

We've hit a fairly subtle miscompile caused by this patch.

glibc's setjmp.h looks like this (irrelevant parts removed):

struct __jmp_buf_tag { /*...*/ };
extern int __sigsetjmp(struct __jmp_buf_tag __env[1], int);
typedef struct __jmp_buf_tag sigjmp_buf[1];
#define sigsetjmp __sigsetjmp

This worked fine with the old approach. But with the new approach, we decide the declaration of __sigsetjmp is not a builtin, because at its point of declaration, we can't compute the "proper" type because sigjmp_buf has not been declared yet. As a result, we don't add a BuiltinAttr to __sigsetjmp, but much more critically, we don't add a ReturnsTwiceAttr, which results in miscompiles in calls to this function. (I think sigsetjmp is the only affected function with glibc. jmp_buf is declared prior to __setjmp and friends.)

I suppose we don't actually care what the parameter types for __sigsetjmp are, and it would be fine (and much safer) to treat any function with that name as a builtin, like we used to. Perhaps we should have a way of marking builtins as "the given type is what we expect / what we will implicitly declare, but it's OK if it doesn't actually match"?

Sep 29 2020, 12:13 AM · Restricted Project

Sep 21 2020

tambre added inline comments to D87983: [Sema] Split special builtin type lookups into a separate function.
Sep 21 2020, 9:13 AM · Restricted Project
tambre committed rGf91f28c350df: [Sema] Split special builtin type lookups into a separate function (authored by tambre).
[Sema] Split special builtin type lookups into a separate function
Sep 21 2020, 9:12 AM
tambre closed D87983: [Sema] Split special builtin type lookups into a separate function.
Sep 21 2020, 9:12 AM · Restricted Project

Sep 20 2020

tambre requested review of D87983: [Sema] Split special builtin type lookups into a separate function.
Sep 20 2020, 1:16 AM · Restricted Project

Sep 18 2020

tambre added inline comments to D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.
Sep 18 2020, 11:09 AM · Restricted Project
tambre committed rGa1aa330b202f: [Sema] Handle objc_super special lookup when checking builtin compatibility (authored by tambre).
[Sema] Handle objc_super special lookup when checking builtin compatibility
Sep 18 2020, 10:52 AM
tambre closed D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.
Sep 18 2020, 10:52 AM · Restricted Project
tambre added a comment to D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.

I'll go ahead and commit this after the builds pass, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules.

Sep 18 2020, 10:14 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Reproducer:

struct objc_super {};
extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...);
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);

Result:

$ clang -c test.mm
test.mm:3:48: error: reference to 'objc_super' is ambiguous
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);
                                               ^
test.mm:1:8: note: candidate found by name lookup is 'objc_super'
struct objc_super {};
       ^
note: candidate found by name lookup is 'objc_super'
1 error generated.

Looking into this, got an idea what might be wrong. Gimme an hour or two. :)

Sep 18 2020, 10:11 AM · Restricted Project
tambre requested review of D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.
Sep 18 2020, 10:11 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Reproducer:

struct objc_super {};
extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...);
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);

Result:

$ clang -c test.mm
test.mm:3:48: error: reference to 'objc_super' is ambiguous
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);
                                               ^
test.mm:1:8: note: candidate found by name lookup is 'objc_super'
struct objc_super {};
       ^
note: candidate found by name lookup is 'objc_super'
1 error generated.
Sep 18 2020, 9:57 AM · Restricted Project

Sep 17 2020

tambre committed rGe09107ab80dc: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness (authored by tambre).
[Sema] Introduce BuiltinAttr, per-declaration builtin-ness
Sep 17 2020, 9:29 AM
tambre closed D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sep 17 2020, 9:29 AM · Restricted Project

Sep 14 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

If there are no further comments I'll commit this in a few days.

Sep 14 2020, 10:34 PM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Address comments.

Sep 14 2020, 10:15 PM · Restricted Project

Sep 11 2020

tambre abandoned D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

It's not clear why couldn't we support per-target runtime directory? It uses the standard multiarch layout, so in you'd end up using a directory like [path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a. I'd find this more preferable for consistency with other targets, it'd also enable the use of runtimes build for baremetal.

Sep 11 2020, 11:22 AM · Restricted Project
tambre committed rGc42f96cb23be: [CMake][OpenMP] Simplify getting CUDA library directory (authored by tambre).
[CMake][OpenMP] Simplify getting CUDA library directory
Sep 11 2020, 11:19 AM
tambre closed D87195: [CMake][OpenMP] Simplify getting CUDA library directory.
Sep 11 2020, 11:19 AM · Restricted Project
tambre added a reviewer for D87195: [CMake][OpenMP] Simplify getting CUDA library directory: phosek.

phosek: Maybe you can review, others seems absent.

Sep 11 2020, 10:19 AM · Restricted Project
tambre updated the diff for D87195: [CMake][OpenMP] Simplify getting CUDA library directory.

Add quotes around variable expansion.
Otherwise it might break for paths with spaces.

Sep 11 2020, 10:18 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

ping

Sep 11 2020, 5:56 AM · Restricted Project

Sep 8 2020

tambre committed rG86bd8f82cc74: [CMake] Remove dead FindPythonInterp code (authored by tambre).
[CMake] Remove dead FindPythonInterp code
Sep 8 2020, 5:23 AM
tambre closed D87189: [CMake] Remove dead FindPythonInterp code.
Sep 8 2020, 5:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 7 2020

tambre added a comment to D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

phosek: ping

Sep 7 2020, 9:57 AM · Restricted Project
tambre committed rG6b954f1b7960: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries (authored by dmm9).
[KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries
Sep 7 2020, 6:09 AM
tambre closed D87203: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries.
Sep 7 2020, 6:09 AM · Restricted Project
tambre added a comment to D87203: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries.

Thanks for the review. Yes, I do not have commit rights.

Sep 7 2020, 6:03 AM · Restricted Project
tambre added a comment to D87203: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries.

Do you need me to land this for you, as I presume you lack the commit privileges?

Sep 7 2020, 5:47 AM · Restricted Project
tambre accepted D87203: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries.

LGTM

Sep 7 2020, 4:54 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Thanks for the review. All tests still pass, should be good for another round.

Sep 7 2020, 3:11 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Remove now obsolete FIXME.

Sep 7 2020, 3:11 AM · Restricted Project
tambre updated the summary of D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sep 7 2020, 3:02 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Address review comments.

Sep 7 2020, 2:59 AM · Restricted Project
tambre committed rGf4835b94f2cf: [CMake][TableGen] Remove dead CMake version checks (authored by tambre).
[CMake][TableGen] Remove dead CMake version checks
Sep 7 2020, 12:59 AM
tambre closed D87190: [CMake][TableGen] Remove dead CMake version checks.
Sep 7 2020, 12:59 AM · Restricted Project
tambre committed rG21c0e74c9e7f: [CMake][OpenMP] Remove old dead CMake code (authored by tambre).
[CMake][OpenMP] Remove old dead CMake code
Sep 7 2020, 12:57 AM
tambre closed D87191: [CMake][OpenMP] Remove old dead CMake code.
Sep 7 2020, 12:57 AM · Restricted Project
tambre committed rG098130fa403a: [CMake][Polly] Remove dead CMake code (authored by tambre).
[CMake][Polly] Remove dead CMake code
Sep 7 2020, 12:55 AM
tambre closed D87192: [CMake][Polly] Remove dead CMake code.
Sep 7 2020, 12:55 AM · Restricted Project
tambre committed rG80186e4efc92: [CMake][TableGen] Simplify code by using list(TRANSFORM) (authored by tambre).
[CMake][TableGen] Simplify code by using list(TRANSFORM)
Sep 7 2020, 12:53 AM
tambre closed D87193: [CMake][TableGen] Simplify code by using list(TRANSFORM).
Sep 7 2020, 12:53 AM · Restricted Project

Sep 5 2020

tambre retitled D87195: [CMake][OpenMP] Simplify getting CUDA library directory from [CMake][OpenMP] Simplify getting CUDA library target to [CMake][OpenMP] Simplify getting CUDA library directory.
Sep 5 2020, 8:31 AM · Restricted Project
tambre requested review of D87195: [CMake][OpenMP] Simplify getting CUDA library directory.
Sep 5 2020, 8:30 AM · Restricted Project
tambre requested review of D87193: [CMake][TableGen] Simplify code by using list(TRANSFORM).
Sep 5 2020, 8:24 AM · Restricted Project
tambre updated the diff for D87192: [CMake][Polly] Remove dead CMake code.

Simply code to use set_property(), which can handle multiple targets at once.

Sep 5 2020, 8:18 AM · Restricted Project
tambre requested review of D87192: [CMake][Polly] Remove dead CMake code.
Sep 5 2020, 8:17 AM · Restricted Project
tambre requested review of D87191: [CMake][OpenMP] Remove old dead CMake code.
Sep 5 2020, 8:12 AM · Restricted Project
tambre requested review of D87190: [CMake][TableGen] Remove dead CMake version checks.
Sep 5 2020, 8:09 AM · Restricted Project
tambre requested review of D87189: [CMake] Remove dead FindPythonInterp code.
Sep 5 2020, 7:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 4 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

I didn't see the specific example, sorry. I agree that my description is more applicable to builtins in the __builtin namespace, which describes most of the builtins with custom typechecking. Is the problem just __va_start?

Sep 4 2020, 9:44 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Improve comments.

Sep 4 2020, 9:43 AM · Restricted Project

Sep 3 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

The builtins with custom type-checking are all true intrinsics like __builtin_operator_new and so on. They really can't be validly declared by the user program. The thing that seems most likely to avoid random compiler crashes would be to either forbid explicit declarations of them or treat those as no longer being builtins. If we need to maintain compatibility with people making custom declarations, we would need to always treat them as builtins and run the risk of crashing if someone declares one with a bad signature. But I don't think it's unfair of us to break those people; that is seriously not reasonable user behavior.

It's possible that custom declarations are people trying to create compatibility shims for compilers that don't provide these as builtins. Those people should be guarding their custom declarations, preferably with __has_builtin.

Sep 3 2020, 9:12 AM · Restricted Project

Sep 2 2020

tambre updated the summary of D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sep 2 2020, 9:57 PM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Thanks for the review!
I believe I've managed to address your comments.

Sep 2 2020, 9:17 PM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Remove __inline__ and static from all builtins in intrin.h.
Remove ASTReader/ASTWriter placeholders.
During builtin recognition:

  • Use ASTContext::GetBuiltinType() instead of creating a new function declaration every time.
  • Check for C linkage.
  • Handle builtins with custom typechecking.
Sep 2 2020, 9:15 PM · Restricted Project

Sep 1 2020

tambre added a comment to D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

@phosek Please review again.
I've overhauled the patch as I realized that per-target runtime directories don't make sense for the bare-metal target, since the runtime is only distinguished by the specific architecture and nothing else.
As a result I've simply changed this into a cleanup doing the same thing as D59425, which seems to have languished.

Sep 1 2020, 7:16 AM · Restricted Project
tambre retitled D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain from [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain to [Clang][Driver] Use full path to builtins in bare-metal toolchain.
Sep 1 2020, 7:13 AM · Restricted Project
tambre updated the diff for D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

Rework patch to simply cleanup runtime handling in the bare-metal toolchain.

Sep 1 2020, 7:13 AM · Restricted Project
tambre added a comment to D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

This was discussed when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR was introduced and there was a pushback against changing the driver behavior depending on the value of that option, so if we're going to reverse that decision for BareMetal, I think that deserves a broader discussion.

Sep 1 2020, 12:58 AM · Restricted Project
tambre updated the diff for D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

Remove define to change driver behaviour, use ToolChain::getCompilerRTArgString() instead.

Sep 1 2020, 12:02 AM · Restricted Project

Aug 31 2020

tambre updated the diff for D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.

Add missing dash.

Aug 31 2020, 8:32 AM · Restricted Project
tambre requested review of D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain.
Aug 31 2020, 8:29 AM · Restricted Project
tambre added inline comments to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Aug 31 2020, 3:17 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Remove builtin reverting.

Aug 31 2020, 3:16 AM · Restricted Project

Aug 30 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

FYI: PR45410, which this fixes, has been marked as a release blocker for 11.0.0.

Aug 30 2020, 9:25 PM · Restricted Project

Aug 29 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Please review. I would like to get this in a mergeable state.

Aug 29 2020, 11:33 AM · Restricted Project
tambre updated the summary of D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Aug 29 2020, 11:25 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Rebase, fix new MS builtins and other tests, XFAIL pthread_create() test

Aug 29 2020, 11:20 AM · Restricted Project

Aug 27 2020

tambre committed rG45344cf7ac5b: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify… (authored by tambre).
[CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify…
Aug 27 2020, 5:40 AM
tambre closed D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.
Aug 27 2020, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
tambre updated the diff for D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Rebase, just in case

Aug 27 2020, 5:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2020

tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Sorry, just got around to check this out. With the new workaround this seems to work on macOS (the initial patch did produce the same error).

Many thanks!
I've submitted an upstream CMake MR to hopefully fix this. I'd appreciate if you could test that too. There's an example testcase in CMake issue 20771.

With that CMake patch your original patch compiles just fine on macOS. Feel free to add a FIXME that this workaround can be removed when the CMake version you merged this is because the new minimum required. Thanks!

Aug 24 2020, 9:34 AM · Restricted Project, Restricted Project, Restricted Project
tambre updated the diff for D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Gate Apple workaround behind CMake version 3.19

Aug 24 2020, 9:32 AM · Restricted Project, Restricted Project, Restricted Project

Aug 21 2020

tambre abandoned D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

Abandoning as it seems this will never get reviewed.

Aug 21 2020, 7:06 AM · Restricted Project
tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Sorry, just got around to check this out. With the new workaround this seems to work on macOS (the initial patch did produce the same error).

Aug 21 2020, 1:04 AM · Restricted Project, Restricted Project, Restricted Project
tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Just FWIW, a similar change was made in libunwind earlier (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44), which then required workarounds for cmake issues on both mingw and macos (see b780df052dd2b246a760d00e00f7de9ebdab9d09 and d4ded05ba851304b26a437896bc3962ef56f62cb) to reintroduce the code for building the asm code as C.

Aug 21 2020, 12:43 AM · Restricted Project, Restricted Project, Restricted Project
tambre updated the summary of D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.
Aug 21 2020, 12:33 AM · Restricted Project, Restricted Project, Restricted Project
tambre retitled D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds from Reland [compiler-rt] Compile assembly files as ASM not C to [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.
Aug 21 2020, 12:30 AM · Restricted Project, Restricted Project, Restricted Project
tambre updated the diff for D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

Add workaround for Apple, and for MinGW prior to CMake 3.17.

Aug 21 2020, 12:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 20 2020

tambre committed rG58c08c444655: Test commit (authored by tambre).
Test commit
Aug 20 2020, 12:15 PM
tambre added a comment to D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.

I'm pretty sure add_asm_sources() has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway.

Aug 20 2020, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
tambre requested review of D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds.
Aug 20 2020, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

tambre added a comment to D85706: [compiler-rt] Compile assembly files as ASM not C.

ping

Aug 19 2020, 11:54 PM · Restricted Project, Restricted Project
tambre added a comment to D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

paquette: ping for landing

Aug 19 2020, 12:00 PM · Restricted Project

Aug 18 2020

tambre added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

I've been using this + D75960 in my employer's Clang build for almost two months. We have been using std::bit_cast in our codebase quite a bit and haven't encountered any issues with these two changes. It would be nice to see this merged.

Aug 18 2020, 6:10 AM · Restricted Project

Aug 14 2020

tambre added a comment to D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

Please land this for me (as "Raul Tambre <raul@tambre.ee>"). I lack commit privileges. :)

Aug 14 2020, 12:09 PM · Restricted Project
tambre added a comment to D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

paquette: ping

Aug 14 2020, 11:01 AM · Restricted Project
tambre updated the summary of D85706: [compiler-rt] Compile assembly files as ASM not C.
Aug 14 2020, 11:00 AM · Restricted Project, Restricted Project
tambre added a comment to D85706: [compiler-rt] Compile assembly files as ASM not C.

One concern I have with this change is that we may not always consistently update CMAKE_ASM_FLAGS or set CMAKE_ASM_COMPILER. This wouldn't make a difference before, but it'll with this change. Can you check if these variables are being updated as needed?

Aug 14 2020, 10:59 AM · Restricted Project, Restricted Project
tambre updated the diff for D85706: [compiler-rt] Compile assembly files as ASM not C.

Pass CMAKE_ASM_COMPILER to compiler-rt in runtime build

Aug 14 2020, 10:57 AM · Restricted Project, Restricted Project

Aug 12 2020

tambre updated the diff for D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

Re-generate test checks

Aug 12 2020, 11:51 AM · Restricted Project

Aug 11 2020

tambre added a comment to D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().

Per usual, if it looks good please land this for me.

Aug 11 2020, 3:42 AM · Restricted Project
tambre requested review of D85720: [AArch64][GlobalISel] Handle rtcGPR64RegClassID in AArch64RegisterBankInfo::getRegBankFromRegClass().
Aug 11 2020, 3:40 AM · Restricted Project

Aug 10 2020

tambre requested review of D85706: [compiler-rt] Compile assembly files as ASM not C.
Aug 10 2020, 10:58 PM · Restricted Project, Restricted Project