- User Since
- May 4 2019, 1:33 AM (82 w, 2 d)
Sat, Nov 28
Mon, Nov 16
Oct 22 2020
I echo @tra's concerns.
Having an option for a vendor to append/prepend a toolkit search location seems useful, but currently this seems more like a workaround for an explicit CUDA toolkit path not being passed to the testsuite.
Shortcomings in the testrunner don't seem like a reason to introduce new build-time configured default search paths into the driver.
Sep 29 2020
Sep 21 2020
Sep 20 2020
Sep 18 2020
I'll go ahead and commit this after the builds pass, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules.
Sep 17 2020
Sep 14 2020
If there are no further comments I'll commit this in a few days.
Sep 11 2020
phosek: Maybe you can review, others seems absent.
Add quotes around variable expansion.
Otherwise it might break for paths with spaces.
Sep 8 2020
Sep 7 2020
Do you need me to land this for you, as I presume you lack the commit privileges?
Thanks for the review. All tests still pass, should be good for another round.
Remove now obsolete FIXME.
Address review comments.
Sep 5 2020
Simply code to use set_property(), which can handle multiple targets at once.
Sep 4 2020
Sep 3 2020
Sep 2 2020
Thanks for the review!
I believe I've managed to address your comments.
Remove __inline__ and static from all builtins in intrin.h.
Remove ASTReader/ASTWriter placeholders.
During builtin recognition:
- Use ASTContext::GetBuiltinType() instead of creating a new function declaration every time.
- Check for C linkage.
- Handle builtins with custom typechecking.
Sep 1 2020
@phosek Please review again.
I've overhauled the patch as I realized that per-target runtime directories don't make sense for the bare-metal target, since the runtime is only distinguished by the specific architecture and nothing else.
As a result I've simply changed this into a cleanup doing the same thing as D59425, which seems to have languished.
Rework patch to simply cleanup runtime handling in the bare-metal toolchain.
Remove define to change driver behaviour, use ToolChain::getCompilerRTArgString() instead.
Aug 31 2020
Add missing dash.
Remove builtin reverting.
Aug 30 2020
FYI: PR45410, which this fixes, has been marked as a release blocker for 11.0.0.
Aug 29 2020
Please review. I would like to get this in a mergeable state.
Rebase, fix new MS builtins and other tests, XFAIL pthread_create() test
Aug 27 2020
Rebase, just in case
Aug 24 2020
Gate Apple workaround behind CMake version 3.19
Aug 21 2020
Abandoning as it seems this will never get reviewed.
Add workaround for Apple, and for MinGW prior to CMake 3.17.
Aug 20 2020
I'm pretty sure add_asm_sources() has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway.
Aug 19 2020
paquette: ping for landing
Aug 18 2020
I've been using this + D75960 in my employer's Clang build for almost two months. We have been using std::bit_cast in our codebase quite a bit and haven't encountered any issues with these two changes. It would be nice to see this merged.
Aug 14 2020
Please land this for me (as "Raul Tambre <email@example.com>"). I lack commit privileges. :)
Pass CMAKE_ASM_COMPILER to compiler-rt in runtime build
Aug 12 2020
Re-generate test checks
Aug 11 2020
Per usual, if it looks good please land this for me.