Page MenuHomePhabricator

ruiu (Rui Ueyama)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 12:16 AM (381 w, 6 d)

Recent Activity

May 20 2020

ruiu added a comment to D80255: [rfc] [lld] Do not ignore comdats when parsing LTO objects.

I tried building a more complex workload and the build failed due to some undefined hidden symbol. For thinlto, is the linker or codegen supposed to handle comdat folding?

May 20 2020, 10:01 PM · Restricted Project

May 13 2020

ruiu accepted D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.

LGTM

May 13 2020, 11:23 PM · Restricted Project, lld
ruiu accepted D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.

LGTM

May 13 2020, 8:43 PM · Restricted Project
ruiu accepted D79880: [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members.

LGTM

May 13 2020, 8:43 PM · Restricted Project
ruiu added a comment to D79300: [ELF] Demote lazy symbols relative to a discarded section to Undefined.

There might be a better way of doing this. As far as I know, directly referring a non-group-leader symbol is not allowed, so the problem we have here is to find an object file that violates the spec. Do you think you can directly implement that logic? I mean, when a symbol is being resolved, we can check if a symbol is directly referring a group internal symbol, and if that's the case, we can emit an error as soon as such a bad symbol use is found.

May 13 2020, 8:11 PM · Restricted Project

May 12 2020

ruiu added a comment to D79300: [ELF] Demote lazy symbols relative to a discarded section to Undefined.

I wonder in what condition this error occurs. In particular, can you trigger this with standard-compliant object files?

May 12 2020, 11:09 PM · Restricted Project
ruiu added a comment to D78342: [lld] Add archive file support to Mach-O backend.

Nice. This looks like a straightforward implementation of an archive file support.

May 12 2020, 10:05 PM · Restricted Project

Apr 26 2020

ruiu accepted D78837: [lld] Remove special cases from default ld driver mode..

I think this behavior was carried over from the previous version of lld, but I believe this would cause confusion than being convenient. This is also against our general policy to make cross-linking easier, which is "lld should not change the behavior on which OS it is running".

Apr 26 2020, 11:22 PM · Restricted Project, lld

Apr 14 2020

ruiu added inline comments to D77187: [lld][WebAssembly] Add initial support for -Map/--print-map.
Apr 14 2020, 9:12 PM · Restricted Project

Apr 12 2020

ruiu added inline comments to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.
Apr 12 2020, 11:25 PM · Restricted Project
ruiu accepted D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X.

LGTM

Apr 12 2020, 10:27 PM · Restricted Project
ruiu accepted D76908: [lld-macho] Add support for emitting dylibs with a single symbol.

LGTM

Apr 12 2020, 9:55 PM · Restricted Project
ruiu accepted D76742: [lld-macho] Add basic symbol table output.

Much better! Thank you for making the changes, this patch looks pretty good now. LGTM

Apr 12 2020, 8:50 PM · Restricted Project
ruiu added inline comments to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.
Apr 12 2020, 8:50 PM · Restricted Project
ruiu added inline comments to D77187: [lld][WebAssembly] Add initial support for -Map/--print-map.
Apr 12 2020, 8:50 PM · Restricted Project

Apr 8 2020

ruiu added inline comments to D76977: [lld-macho] Implement basic export trie.
Apr 8 2020, 11:16 PM · Restricted Project
ruiu added inline comments to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.
Apr 8 2020, 11:12 PM · Restricted Project
ruiu added inline comments to D76742: [lld-macho] Add basic symbol table output.
Apr 8 2020, 11:12 PM · Restricted Project

Apr 7 2020

ruiu added a comment to D77672: [ELF] Support a few more SPARCv9 relocations.

Improving SPARC support is fine as long as we don't need to do something special for the ISA. But since no active maintainers have a SPARC machine, it is hard to find bugs in SPARC. Can you add tests for the new relocations?

For what it's worth, I have access to various SPARC machines, so can test things as needed. Also, the GCC compile farm (https://cfarm.tetaneutral.net/machines/list/) has multiple SPARC machines; in particular, gcc202 is managed by us Debian sparc64 porters, and has a beefy 64 cores and 64 GiB on a T5 (which, unlike some of the earlier UltraSparcs, has decent single-threaded performance too), so it should be easy for maintainers to test things if they're interested enough. The compile farm is a great resource in general that is really easy to sign up for and most don't know about.

Apr 7 2020, 10:50 PM · Restricted Project
ruiu added inline comments to D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 7 2020, 9:46 PM · Restricted Project
ruiu added a comment to D77672: [ELF] Support a few more SPARCv9 relocations.

Improving SPARC support is fine as long as we don't need to do something special for the ISA. But since no active maintainers have a SPARC machine, it is hard to find bugs in SPARC. Can you add tests for the new relocations?

Apr 7 2020, 9:13 PM · Restricted Project

Apr 6 2020

ruiu accepted D68065: Propeller: LLD Support for Basic Block Sections.

I had a VC meeting wtih maskray to discuss concerns he has, and he is ok with this patch. I'm fine with this patch too. I'll give a final LGTM to unblock you. Please make the following changes and submit. Thanks!

Apr 6 2020, 8:44 PM · Restricted Project, lld

Apr 5 2020

ruiu added inline comments to D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list.
Apr 5 2020, 10:25 PM · Restricted Project

Apr 1 2020

ruiu added inline comments to D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands.
Apr 1 2020, 8:42 PM · Restricted Project
ruiu added a comment to D76742: [lld-macho] Add basic symbol table output.

We usually construct a section in three phases as follows:

Apr 1 2020, 8:09 PM · Restricted Project
ruiu added inline comments to D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands.
Apr 1 2020, 2:43 AM · Restricted Project
ruiu added a comment to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.

The tests for lld/mach-o definitely need to be able to run on non-macOS platforms. We generally run all tests on all kind of bots, so yes, you cannot assume that /usr/lib/libSystem.B.dylib exists. Actually you shouldn't make any assumptions on the existence or absence of any external file.

Apr 1 2020, 1:36 AM · Restricted Project

Mar 31 2020

ruiu accepted D76999: [ELF] Print symbols with non-default versions for better "undefined symbol" diagnostics.

LGTM

Mar 31 2020, 11:05 PM · Restricted Project
ruiu added inline comments to D76999: [ELF] Print symbols with non-default versions for better "undefined symbol" diagnostics.
Mar 31 2020, 10:00 PM · Restricted Project
ruiu added inline comments to D76252: [lld-macho] Add basic support for linking against dylibs.
Mar 31 2020, 10:00 PM · Restricted Project
ruiu accepted D76908: [lld-macho] Add support for emitting dylibs with a single symbol.

LGTM

Mar 31 2020, 10:00 PM · Restricted Project
ruiu added inline comments to D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands.
Mar 31 2020, 10:00 PM · Restricted Project
ruiu added inline comments to D76977: [lld-macho] Implement basic export trie.
Mar 31 2020, 9:27 PM · Restricted Project
ruiu accepted D76960: [lld][WebAssembly] Early error if output file cannot be created..

LGTM

Mar 31 2020, 9:27 PM · Restricted Project
ruiu added a comment to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.

What do you mean by "upstream"?

Mar 31 2020, 9:27 PM · Restricted Project
ruiu added a comment to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.

Hm, I was just trying to emulate ld64's behavior, but I agree that this one might not be very useful. Regardless of whether we throw an error, though, having special-case code to emit it at test time seems useful, if only so we can run the resulting executables on macOS.

Mar 31 2020, 8:23 PM · Restricted Project
ruiu added inline comments to D76977: [lld-macho] Implement basic export trie.
Mar 31 2020, 8:23 PM · Restricted Project
ruiu added a comment to D77086: [lld-macho][easy] Use substitution for test.

Manual line wrapping is kind of a chore, and since we don't have an autoformatter for these files, we'd end up with lines that are too short after doing that sed operation. Plus I was also considering adding -Z to the base %lld substitution to ensure that we never write tests which accidentally depend on system libraries.

Mar 31 2020, 8:22 PM · Restricted Project
ruiu added inline comments to D77187: [lld][WebAssembly] Add initial support for -Map/--print-map.
Mar 31 2020, 8:22 PM · Restricted Project
ruiu added inline comments to D76977: [lld-macho] Implement basic export trie.
Mar 31 2020, 2:10 AM · Restricted Project
ruiu accepted D77006: [lld-macho] Support reading of universal binaries.

LGTM

Mar 31 2020, 2:10 AM · Restricted Project
ruiu added a comment to D77087: [lld-macho] Only mock out libSystem.dylib loading in tests.

I'm not sure why we need this. Could you elaborate a bit? If all executables need to be linked against /usr/lib/libSystem.B.dylib and if a user didn't pass -lSystem, isn't it still their fault and not ours, no?

Mar 31 2020, 2:10 AM · Restricted Project
ruiu added inline comments to D76908: [lld-macho] Add support for emitting dylibs with a single symbol.
Mar 31 2020, 1:37 AM · Restricted Project
ruiu added a comment to D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands.

Overall I'd like to see more comments. All functions and classes that are not trivial should have a comment explaining what they represent or what they are supposed to do.

Mar 31 2020, 1:04 AM · Restricted Project

Mar 30 2020

ruiu added inline comments to D76742: [lld-macho] Add basic symbol table output.
Mar 30 2020, 11:58 PM · Restricted Project
ruiu added inline comments to D76252: [lld-macho] Add basic support for linking against dylibs.
Mar 30 2020, 11:58 PM · Restricted Project
ruiu added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

Instead of --threads=all, can you use --threads? --threads has several advantages over --threads=all:

Mar 30 2020, 11:25 PM · Restricted Project
ruiu added a comment to D77086: [lld-macho][easy] Use substitution for test.

I'm actually not in favor of this change as I want to keep test files self-contained. I'd stick with lld -flavor darwinnew. Once the new lld/mach-o is ready, you can run sed with s/lld -flavor darwinnew/lld.ld64/g to replace all occurrences of lld -flavor darwinnew. So I don't see a need for abstraction here.

Mar 30 2020, 10:22 PM · Restricted Project
ruiu added a comment to D75382: [lld] Initial commit for new Mach-O backend.

Can you submit this change? I think this is good enough as an initial commit, and you can make further changes on top of this.

Mar 30 2020, 10:22 PM · Restricted Project
ruiu added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

Do we need all? It's the default behavior, so if you want to specify --threads=all, you can just delete it altogether.

Mar 30 2020, 9:18 PM · Restricted Project

Mar 24 2020

ruiu added a comment to D76668: [lld][ELF] Ignore __start/__stop symbols in section groups during GC.

lld's --gc-sections behavior didn't take start/stop symbols into consideration, but it turned out some programs didn't work with that algorithm, so we (I believe rafael or pcc) added the logic to preserve sections for start/stop symbols. Therefore, I think we can't ignore start/stop symbols at the section gc stage and need to at least keep the existing logic.

Mar 24 2020, 10:56 PM · Restricted Project

Mar 23 2020

ruiu added a comment to D76668: [lld][ELF] Ignore __start/__stop symbols in section groups during GC.

Although I understand your concrete example, I'm not sure if this is logically correct. This patch is written based on the following assumption:

Mar 23 2020, 11:57 PM · Restricted Project

Mar 18 2020

ruiu added a comment to D76252: [lld-macho] Add basic support for linking against dylibs.

As to the tests, we generally don't use yaml2obj to write tests (except for COFF which is historically using yaml2obj). If you are using yaml2obj just until lld itself is able to produce files used by tests, I don't think you have to spend too much time writing tests in yaml2obj. Instead, you can submit binary files for now and then replace them later.

Hi @ruiu,

I'm just doing a quick drive by comment here, since I'm not really doing much LLD work at the moment myself. Why are you opposed to yaml2obj being used to generate test inputs instead of llvm-mc? Surely yaml2obj gives more direct control over what is actually in the input? In llvm-mc you only have relatively limited control over some things like relocations.

It seems to me like yaml2obj is a better instrument to be using for the vast majority of test cases, with only a limited set using llvm-mc as a catch-all test to make sure that we don't miss some odd interaction. Of course, this is all making the assumption that mach-o yaml2obj is straightforward to use (I have a feeling it might not be).

You can write tests with yaml2obj too, but if you take a look at ELF, don't you think that we can write fine-grained test cases with llvm-mc too? I want tests to be realistic input files, and in that respect, test cases written in llvm-mc are better than ones in obj2yaml.

I also found that tests written in llvm-mc are easier to maintain. For example, imagine that you already have a test file containing tests for relocations and you want to add a new type of relocation. Then, you'll have to not only add a new relocation to a yaml file but also add a few extra bytes with some addend at a right bit-wise position to the .text section, which isn't easy to do by hand. So, I guess you'll end up writing a test in assembly, compile it and then convert it to yaml -- but if that's the case, we should write tests in assembly in the first place. On the other hand, I didn't find a test case that is easy to write in yaml but not in assembly. There might be some, but that shouldn't be too many. So it looks to me that llvm-mc is a better choice to write test files.

I think there is no universal approach and I agree with both of you. For example, for testing relocation relaxations I'd definetely prefer using YAML because it is important to get the particular op-codes and relocations in the inputs.
It is probaly easier to use YAMLs rather than using llvm-mc and verifying inputs with objdump or alike. For many other things, using llvm-mc is probably a bit more natural.

What I do not agree with is that commiting binaries is OK. From my one last experience after working on
yaml2obj and converting LLVM binaries, I found them are source of all kind of problems. If we can use yaml2obj for that out of box, I think we should.
If we can't then probably it is OK to use binaries temporary, but probably a bug should be reported about lacking features of yaml2obj and the
test should have a FIXME comment with a link.

Mar 18 2020, 3:46 AM · Restricted Project
ruiu accepted D75382: [lld] Initial commit for new Mach-O backend.

LGTM

Mar 18 2020, 3:13 AM · Restricted Project
ruiu added a comment to D76252: [lld-macho] Add basic support for linking against dylibs.

As to the tests, we generally don't use yaml2obj to write tests (except for COFF which is historically using yaml2obj). If you are using yaml2obj just until lld itself is able to produce files used by tests, I don't think you have to spend too much time writing tests in yaml2obj. Instead, you can submit binary files for now and then replace them later.

Hi @ruiu,

I'm just doing a quick drive by comment here, since I'm not really doing much LLD work at the moment myself. Why are you opposed to yaml2obj being used to generate test inputs instead of llvm-mc? Surely yaml2obj gives more direct control over what is actually in the input? In llvm-mc you only have relatively limited control over some things like relocations.

It seems to me like yaml2obj is a better instrument to be using for the vast majority of test cases, with only a limited set using llvm-mc as a catch-all test to make sure that we don't miss some odd interaction. Of course, this is all making the assumption that mach-o yaml2obj is straightforward to use (I have a feeling it might not be).

Mar 18 2020, 2:41 AM · Restricted Project
ruiu added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 18 2020, 1:04 AM · Restricted Project
ruiu added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 18 2020, 12:31 AM · Restricted Project

Mar 17 2020

ruiu added a comment to D76252: [lld-macho] Add basic support for linking against dylibs.

The no-id-dylink.s test needs yaml2obj to generate an invalid dylib, but yeah I can replace the other two with binary blobs

We are trying to avoid binary blob in LLVM binary utilities + lld. @grimar has done lots of work in this area. Can you figure out how much effort it takes to implement relevant features in yaml2obj Mach-O? I hope we can avoid binary blobs early.

Mar 17 2020, 6:56 PM · Restricted Project
ruiu added a comment to D76252: [lld-macho] Add basic support for linking against dylibs.

As to the tests, we generally don't use yaml2obj to write tests (except for COFF which is historically using yaml2obj). If you are using yaml2obj just until lld itself is able to produce files used by tests, I don't think you have to spend too much time writing tests in yaml2obj. Instead, you can submit binary files for now and then replace them later.

Mar 17 2020, 12:52 AM · Restricted Project

Mar 16 2020

ruiu added inline comments to D76252: [lld-macho] Add basic support for linking against dylibs.
Mar 16 2020, 10:43 PM · Restricted Project
ruiu accepted D68065: Propeller: LLD Support for Basic Block Sections.

It looks like there's no activities in the llvm-dev thread and this review thread, so I'll reiterate my LGTM, as I think we should not block this change, in particular given that the corresponding change to LLVM has been submitted.

Mar 16 2020, 3:09 AM · Restricted Project, lld
ruiu committed rGa2923b2a1e45: Implement CET Shadow Stack (Intel Controlflow Enforcement Technology) support… (authored by ruiu).
Implement CET Shadow Stack (Intel Controlflow Enforcement Technology) support…
Mar 16 2020, 2:10 AM
ruiu closed D70606: LLD: CET shadow stack support on Windows.
Mar 16 2020, 2:10 AM · Restricted Project, lld

Mar 13 2020

ruiu added a comment to D70606: LLD: CET shadow stack support on Windows.

That's discussed on llvm-dev, and I think that even though we should ideally extend
the tool to handle the new bit, it shouldn't block this patch. This patch adds a missing
flag that was added to MSVC link.exe recently.

Mar 13 2020, 4:24 AM · Restricted Project, lld
ruiu added inline comments to D70557: [lld][COFF] Add support for /map.
Mar 13 2020, 12:50 AM · Restricted Project, lld
ruiu added a comment to D75382: [lld] Initial commit for new Mach-O backend.

Jez and Shoaib, if you guys have more patches on this one, you can send them now for review if you want.

Mar 13 2020, 12:50 AM · Restricted Project

Mar 12 2020

ruiu added a comment to D75382: [lld] Initial commit for new Mach-O backend.

LGTM

Mar 12 2020, 11:19 PM · Restricted Project
ruiu accepted D76109: [ELF] Correct error message when OUTPUT_FORMAT is used.

LGTM

Mar 12 2020, 10:36 PM · Restricted Project

Mar 10 2020

ruiu accepted D75382: [lld] Initial commit for new Mach-O backend.

Thank you very much for doing this!

Mar 10 2020, 3:46 AM · Restricted Project
ruiu accepted D75742: [Object] Support large archive members.

LGTM

Mar 10 2020, 12:09 AM · Restricted Project

Mar 9 2020

ruiu accepted D70557: [lld][COFF] Add support for /map.

LGTM

Mar 9 2020, 11:21 PM · Restricted Project, lld
ruiu added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 9 2020, 2:07 AM · Restricted Project
ruiu accepted D75809: [lld] Add .clang-tidy to customize readability-identifier-naming.{Member,Parameter,Variable}Case => camelBack.

LGTM

Mar 9 2020, 2:07 AM · Restricted Project

Mar 5 2020

ruiu added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Yeah, that's another type of consistency, and if you feel that that consistency is more important, feel free to make a change to wasm-ld so that the tool defaults to runtime OS's rsp-quoting style.

Mar 5 2020, 11:30 PM · Restricted Project
ruiu accepted D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file..

LGTM

Mar 5 2020, 11:30 PM · debug-info, Restricted Project
ruiu added a comment to D70557: [lld][COFF] Add support for /map.

Overall looking good.

Mar 5 2020, 10:58 PM · Restricted Project, lld
ruiu added a comment to D70606: LLD: CET shadow stack support on Windows.

I tried to apply your patch to submit, but it looks like your test file (llvm/test/tools/llvm-readobj/COFF/Inputs/has_cet.exe) cannot be downloaded from Phabricator. Can you upload a file somewhere and send me the URL? Or you can encode with base64 and send it to me via email.

Mar 5 2020, 9:49 PM · Restricted Project, lld

Mar 4 2020

ruiu added a comment to D75648: [lld] Rename -flavor darwin to -flavor old-darwin.

But we are going to call the new one as mach_o2 until mach_o can be removed and rename the new one mach_o once it's done, no? If so, I don't think we need to rename only this part at this moment. We can rename them all at once later.

Mar 4 2020, 6:31 PM · Restricted Project
ruiu added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 4 2020, 1:46 AM · Restricted Project
ruiu added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

lld's default choices are different among platforms as we are trying to match the native linkers' behaviors. So is true to clang; if you invoke clang as clang-cl (which is a Microsoft-compatible compiler driver), the value is set to Windows by default. I think we didn't have any other policy than this, as we are creating drop-in replacements.

Mar 4 2020, 1:13 AM · Restricted Project

Mar 3 2020

ruiu added inline comments to D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file..
Mar 3 2020, 11:01 PM · debug-info, Restricted Project
ruiu accepted D70606: LLD: CET shadow stack support on Windows.

LGTM with this change.

Mar 3 2020, 10:21 PM · Restricted Project, lld
ruiu accepted D75577: [lld][WebAssembly] Add support for --rsp-quoting.

LGTM

Mar 3 2020, 10:21 PM · Restricted Project

Mar 1 2020

ruiu added a comment to D75382: [lld] Initial commit for new Mach-O backend.

This seems a pretty straightforward port of the existing backends. Very nice!

Mar 1 2020, 9:08 PM · Restricted Project

Feb 27 2020

ruiu added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

If Sriraman has already resolved all Fangrui's comments, I can reiterate my LGTM, as the new code is well written, and I don't have a specific concern. I actually think that this is an interesting feature and in some degree a natural extension of -ffunction-sections.

Feb 27 2020, 8:32 PM · Restricted Project, lld

Feb 24 2020

ruiu accepted D75100: [ELF] Support archive:file syntax in input section descriptions.

LGTM

Feb 24 2020, 10:53 PM · Restricted Project
ruiu added inline comments to D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file..
Feb 24 2020, 6:52 PM · debug-info, Restricted Project
ruiu accepted D68065: Propeller: LLD Support for Basic Block Sections.

LGTM

Feb 24 2020, 6:33 PM · Restricted Project, lld

Feb 13 2020

ruiu added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

Overall looking good, but it looks like this test file doesn't cover all relocations you want to handle. You are handling the following relocations, and compared to that the test file seems too small.

Feb 13 2020, 11:38 PM · Restricted Project, lld

Feb 12 2020

ruiu added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 12 2020, 11:47 PM · Restricted Project, lld

Feb 11 2020

ruiu added inline comments to D68065: Propeller: LLD Support for Basic Block Sections.
Feb 11 2020, 11:12 PM · Restricted Project, lld

Feb 7 2020

ruiu added a comment to D73497: lld: Propeller framework part I.

As we discussed today, this patch didn't make sense to me at first sight, as it redoes a lot of things that we already implemented to lld (e.g. making a new "config" object only for this thing, defining a new type of Symbol (SymbolEntry) even though we have Symbol class, etc.) But the thing is that this code is intended to be used by some external tool. If that's the case, you should consider moving this to LLVM instead and use the code from lld and your tool.

Feb 7 2020, 4:25 AM · Restricted Project
ruiu added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

Here is a summary of today's discussion:

Feb 7 2020, 4:25 AM · Restricted Project, lld

Jan 16 2020

ruiu added a comment to D72803: Make lld cmake not compute commit revision twice.

LGTM

Jan 16 2020, 6:33 PM · Restricted Project

Jan 9 2020

ruiu added a comment to D59780: Support Intel Control-flow Enforcement Technology.

@MaskRay Please rebase and upload it with me and other people as reviewers, then I'll LGTM.

Jan 9 2020, 6:46 AM · Restricted Project

Jan 6 2020

ruiu added inline comments to D72183: [ELF][PPC64] Add --lax-call-lacks-nop.
Jan 6 2020, 12:53 AM · Restricted Project
ruiu added inline comments to D72183: [ELF][PPC64] Add --lax-call-lacks-nop.
Jan 6 2020, 12:35 AM · Restricted Project

Jan 5 2020

ruiu added inline comments to D72183: [ELF][PPC64] Add --lax-call-lacks-nop.
Jan 5 2020, 10:43 PM · Restricted Project
ruiu accepted D72196: [lld] Fix trivial typos in comments.

LGTM

Jan 5 2020, 10:34 PM · Restricted Project, lld
ruiu added inline comments to D71981: [LLD] [COFF] Don't error out on duplicate absolute symbols with the same value.
Jan 5 2020, 10:25 PM · Restricted Project