Page MenuHomePhabricator

[llvm-readobj/elf] - Refine signature of print*Reloc methods.
ClosedPublic

Authored by grimar on Thu, Sep 3, 6:19 AM.

Details

Summary

This makes the interface cleaner and slightly improves messages
reported.

I need it for another patch that is going to reuse
virtual print*Reloc methods for printing dynamic relocations.
(in that case the const Elf_Shdr *Sec argument introduced
instead of unsigned SecIndex will be nullptr).

Diff Detail

Event Timeline

grimar created this revision.Thu, Sep 3, 6:19 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Thu, Sep 3, 6:19 AM
grimar updated this revision to Diff 289708.Thu, Sep 3, 6:47 AM
  • Fix minor nit.
jhenderson accepted this revision.Fri, Sep 4, 12:41 AM

Not sure this shouldn't be two separate patches (improve error message/change signature), but I'm not going to ask for it. LGTM.

This revision is now accepted and ready to land.Fri, Sep 4, 12:41 AM