- User Since
- Jun 28 2018, 11:39 AM (117 w, 3 d)
Fri, Sep 25
There's a build warning that needs to be fixed, but otherwise LG.
Wed, Sep 23
- Switch back to using localhost for non-socket uses
Tue, Sep 22
The issue is with the new pass manager.
Mon, Sep 21
Thu, Sep 17
Looks like llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test covers this, so LGTM
Wed, Sep 16
Tue, Sep 15
The initial dns lookup may still fail, I think? e.g. my initial version of this patch had:
- Compare directly against the error code instead of hopping through std::make_error_code()
Mon, Sep 14
Thu, Sep 10
Wed, Sep 9
This is ready for review now after scrubbing out the "localhost" changes I had earlier.
- Don't use "localhost" to avoid dns latency. Instead, prefer either 127.0.0.1 or ::1 directly.
Tue, Sep 8
Thu, Sep 3
Wed, Sep 2
SG, will land momentarily with the one formatting change. Thanks!
When trying to integrate this downstream, I'm having trouble figuring out what to do with this block: https://github.com/tensorflow/mlir-hlo/blob/master/lib/Dialect/mhlo/transforms/hlo_legalize_to_lhlo.cc#L441
Thanks for the revert.
Tue, Sep 1
Ok. Thanks for confirming!
Usually, tests that are marked # REQUIRES: asserts are done so because they make use of some code that is only available behind NDEBUG. However, in this case, it's outright crashing on certain inputs when not in debug mode. At a first glance, that doesn't seem like a correct fix to me -- after all, the crashing bug is still there -- but I'm not familiar with this code, so I'm probably missing something?
FYI, I reverted this (and D86413 which depends on it) in 8693ddc74371dedc742c9f3d3e4eda1da72c13ea to keep the build green, as it was causing surprising crashes when running ninja check-llvm-codegen-aarch64-globalisel in release builds.
Aug 28 2020
Aug 27 2020
Aug 21 2020
Aug 20 2020
Aug 17 2020
Here's as far as I could get with a repro. Sorry it's weird:
Aug 14 2020
FYI, I reverted this in 38884641f28e373ce291dc5ea93416756216e536 due to the assertion failure being triggered. The reduction is taking longer than usual, so I wasn't able to finish it today. I should be able to have something on Monday.
Aug 13 2020
This is the largest fix I've seen for unused variable warnings, but nonetheless looks correct.
Aug 11 2020
Aug 10 2020
I'm not familiar with sparc target arches, but this looks fine to me if you've been able to verify it fixes things.
Aug 5 2020
FYI, reverted in 3c39db0c4452218c967a8ac3ad48144fbf1159ff. See http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/19573/steps/build%20stage%201/logs/stdio for a breakage that's shown up in buildbots.
Aug 4 2020
Aug 3 2020
Thanks for the quick review!
- Use logging.error
- Remove trailing stop
- Edit message to indicate that matching tests weren't found (user error)