Page MenuHomePhabricator

pcc (Peter Collingbourne)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 28 2012, 2:34 PM (396 w, 2 d)

Recent Activity

Fri, Jul 24

pcc added a comment to D84574: [lld-macho] Fix segment filesize calculation.

I think you can use wc -c. See e.g. clang/test/Modules/rebuild.m.

Fri, Jul 24, 6:39 PM · Restricted Project
pcc accepted D82397: [scudo][standalone] mallopt runtime configuration options.

A possible concern was that this could be constraining future development by exposing implementation details. But I think that as long as we are free to change how these options are interpreted, or start ignoring them entirely, this is probably fine.

Fri, Jul 24, 11:30 AM · Restricted Project
pcc accepted D83993: [scudo][standalone] Change the release loop for efficiency purposes.

LGTM

Fri, Jul 24, 10:27 AM · Restricted Project

Thu, Jul 23

pcc added a comment to D82397: [scudo][standalone] mallopt runtime configuration options.

Where does the configuration need to live? If it just needs to be a build-time configuration, that may be simpler than exposing new mallopt options.

Thu, Jul 23, 4:44 PM · Restricted Project
pcc added inline comments to D83993: [scudo][standalone] Change the release loop for efficiency purposes.
Thu, Jul 23, 4:33 PM · Restricted Project
pcc committed rGb83417aa7e26: scudo: Interleave odd and even tags for adjacent blocks. (authored by pcc).
scudo: Interleave odd and even tags for adjacent blocks.
Thu, Jul 23, 3:10 PM
pcc closed D84361: scudo: Interleave odd and even tags for adjacent blocks..
Thu, Jul 23, 3:09 PM · Restricted Project
pcc added a comment to D84414: [RISCV] Support Shadow Call Stack.

Any callee-saved register can be used.

Thu, Jul 23, 12:48 PM · Restricted Project, Restricted Project
pcc added inline comments to D84414: [RISCV] Support Shadow Call Stack.
Thu, Jul 23, 12:44 PM · Restricted Project, Restricted Project
pcc committed rG9b2164063f77: scudo: Remove some boilerplate from the combined allocator tests. NFCI. (authored by pcc).
scudo: Remove some boilerplate from the combined allocator tests. NFCI.
Thu, Jul 23, 12:22 PM
pcc closed D84454: scudo: Remove some boilerplate from the combined allocator tests. NFCI..
Thu, Jul 23, 12:22 PM · Restricted Project
pcc added inline comments to D84361: scudo: Interleave odd and even tags for adjacent blocks..
Thu, Jul 23, 12:07 PM · Restricted Project
pcc updated the diff for D84361: scudo: Interleave odd and even tags for adjacent blocks..

Rebase

Thu, Jul 23, 12:06 PM · Restricted Project
Herald added a project to D84454: scudo: Remove some boilerplate from the combined allocator tests. NFCI.: Restricted Project.
Thu, Jul 23, 12:06 PM · Restricted Project

Wed, Jul 22

pcc updated the diff for D84361: scudo: Interleave odd and even tags for adjacent blocks..

Add a tuning setting

Wed, Jul 22, 5:46 PM · Restricted Project
Herald added a project to D84361: scudo: Interleave odd and even tags for adjacent blocks.: Restricted Project.
Wed, Jul 22, 1:57 PM · Restricted Project

Tue, Jul 21

pcc added a comment to D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0.

See also @jhenderson's latest reply to the generic-abi thread "SHF_LINK_ORDER's original semantics make upgrade difficult"

# input.o:
<table header> [common]
- DW_TAG_compile_unit [common]
-- DW_TAG_variable [.data.foo]
-- DW_TAG_namespace [common]
--- DW_TAG_subprogram [.text.bar]
--- DW_TAG_variable [.data.baz]
<table footer> [common]

@pcc I sent the patches since you expressed a preference on more work on SHF_LINK_ORDER. Though, @jhenderson's needs (and my header/footer argument in that thread) make me think more whether we should continue patching SHF_LINK_ORDER or start pursuing another section flag.

Without metadata sections's override, SHF_LINK_ORDER will have very few use cases. The problems still exist but we probably don't really need to address them.

Tue, Jul 21, 12:53 PM · Restricted Project
pcc added inline comments to D84001: [ELF] Allow mixed SHF_LINK_ORDER & non-SHF_LINK_ORDER sections and sort within InputSectionDescription.
Tue, Jul 21, 12:35 PM · Restricted Project
pcc added a comment to D72899: [MC] Set sh_link to 0 if the associated symbol is undefined.

Doesn't this require a change to the parser to accept 0 in place of the linked symbol?

Tue, Jul 21, 12:10 PM · Restricted Project

Thu, Jul 16

pcc added inline comments to D83603: [lld-macho] Support __dso_handle for C++.
Thu, Jul 16, 4:16 PM · Restricted Project

Wed, Jul 15

pcc added inline comments to D83603: [lld-macho] Support __dso_handle for C++.
Wed, Jul 15, 12:14 AM · Restricted Project

Jun 22 2020

pcc committed rGbd7defeb9409: llvm-nm: Implement --special-syms. (authored by pcc).
llvm-nm: Implement --special-syms.
Jun 22 2020, 1:27 PM
pcc closed D82251: llvm-nm: Implement --special-syms..
Jun 22 2020, 1:27 PM · Restricted Project
pcc added a comment to D82251: llvm-nm: Implement --special-syms..

Seems reasonable, but the llvm-nm documentation needs updating (see llvm/docs/CommandGuide/llvm-nm.rst).

It may also be worth release-noting the change in behaviour too, since it will mean current ARM users who use llvm-nm will see their mapping symbols disappear from the output, if they aren't already using --special-syms.

Jun 22 2020, 1:26 PM · Restricted Project

Jun 19 2020

pcc created D82251: llvm-nm: Implement --special-syms..
Jun 19 2020, 7:32 PM · Restricted Project

Jun 15 2020

pcc added a comment to D81801: Remove KillTheDoctor.

Win32 has an API for disabling error reporting which is already implemented in sys::DisableSystemDialogsOnCrash(), gtest and relevant test cases such as compiler-rt/test/asan/TestCases/ill.cpp.

Jun 15 2020, 9:13 AM · Restricted Project, Restricted Project

Jun 9 2020

pcc accepted D80599: [HWASan] Add sizeof(global) in report even if symbols missing..

LGTM

Jun 9 2020, 11:32 AM · Restricted Project, Restricted Project

Jun 8 2020

pcc added inline comments to D81410: [ELF][AArch64] Correct relocation codes for R_<CLS>_PLT32.
Jun 8 2020, 11:02 AM · Restricted Project

Jun 5 2020

pcc added inline comments to D77647: [ELF][AArch64] Add R_AARCH64_PLT32 relocation type..
Jun 5 2020, 6:59 PM · Restricted Project
pcc added inline comments to D77647: [ELF][AArch64] Add R_AARCH64_PLT32 relocation type..
Jun 5 2020, 3:10 PM · Restricted Project
pcc added inline comments to D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 5 2020, 12:22 PM · Restricted Project, Restricted Project

Jun 3 2020

pcc added a comment to D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0.

Should we drop this and just let users set sh_link=self if they want these semantics?

Jun 3 2020, 11:32 AM · Restricted Project

Jun 2 2020

pcc added a comment to D80186: [Inliner] Update !associated metadata during inlining.
In D80186#2067298, @pcc wrote:

Yeah. Thinking about it more, you may consider a different !associated scheme for the __prof*_ globals.

  • __profc_* and __profn_* are associated with a dummy global (to allow the sections to be GC'd).
  • __profd_* is associated with the corresponding __profc_* section.

Now no special rules are required for inlining. __profc_* is kept alive via the references in the functions, __profd_ is kept alive via !associated and __profn_* is kept alive by direct reference.

I tried that, but now we get an error ld.lld: error: /tmp/instrprof-gc-sections-5f007f.o:(__llvm_prf_cnts): sh_link points to discarded section /tmp/instrprof-gc-sections-5f007f.o:(__llvm_prf_dummy) because the dummy global was discarded which creates a broken sh_link.

Jun 2 2020, 10:25 AM · Restricted Project

Jun 1 2020

pcc added a comment to D80186: [Inliner] Update !associated metadata during inlining.

Yeah. Thinking about it more, you may consider a different !associated scheme for the __prof*_ globals.

Jun 1 2020, 2:05 PM · Restricted Project
pcc updated subscribers of D80186: [Inliner] Update !associated metadata during inlining.

In this case you might consider replacing the global reference with null and implementing my proposal in https://bugs.llvm.org/show_bug.cgi?id=41734#c2 to make the section SHF_LINK_ORDER with a zero-length .init_array section.

Jun 1 2020, 12:59 PM · Restricted Project
pcc added inline comments to D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 1 2020, 10:45 AM · Restricted Project, Restricted Project

May 28 2020

pcc added inline comments to D80599: [HWASan] Add sizeof(global) in report even if symbols missing..
May 28 2020, 1:13 PM · Restricted Project, Restricted Project
pcc added inline comments to D80599: [HWASan] Add sizeof(global) in report even if symbols missing..
May 28 2020, 11:33 AM · Restricted Project, Restricted Project

May 27 2020

pcc added a comment to D80599: [HWASan] Add sizeof(global) in report even if symbols missing..

And instead of returning (global_begin, global_end) you could return something like an ArrayRef<hwasan_global> (I don't think we have ArrayRef in compiler-rt, but you could add one, it's pretty simple). Now the client code just looks like

for (hwasan_global &g : HwasanGlobalsFor(phdr, ...)) {
 ...
}
May 27 2020, 6:34 PM · Restricted Project, Restricted Project
pcc added a comment to D80599: [HWASan] Add sizeof(global) in report even if symbols missing..
In D80599#2056315, @pcc wrote:

Instead of adding these callbacks would it be simpler to have a function that takes the pointer to phdrs and returns (global_begin, global_end) (both 0 if not present)?

That would require duplicating the global iteration logic across the reporting and initialisation paths, which I was trying to avoid. Having a callback that recieves a single global is easier for my brain, but please let me know if you'd prefer it the other way around.

May 27 2020, 6:34 PM · Restricted Project, Restricted Project
pcc accepted D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be.

LGTM

May 27 2020, 10:50 AM · Restricted Project

May 26 2020

pcc added a comment to D80599: [HWASan] Add sizeof(global) in report even if symbols missing..

Instead of adding these callbacks would it be simpler to have a function that takes the pointer to phdrs and returns (global_begin, global_end) (both 0 if not present)?

May 26 2020, 6:33 PM · Restricted Project, Restricted Project
pcc added inline comments to D80591: Patch up pthread issues with GN build.
May 26 2020, 5:28 PM · Restricted Project

May 14 2020

pcc committed rGd2a26ad0dc2b: hwasan: Collect ring buffer statistics and include in dev note. (authored by pcc).
hwasan: Collect ring buffer statistics and include in dev note.
May 14 2020, 10:17 AM
pcc closed D79913: hwasan: Collect ring buffer statistics and include in dev note..
May 14 2020, 10:17 AM · Restricted Project
pcc accepted D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og.

LGTM

May 14 2020, 10:16 AM · Restricted Project

May 13 2020

pcc added a comment to D79818: [lld] Support size levels with (Thin)LTO.

@mehdi_amini @pcc @tejohnson

I just saw another issue saying that clang -Os -flto=thin a.c does not work https://bugs.llvm.org/show_bug.cgi?id=45913 (+ @manojgupta)
I marked it as yet another duplicate of PR42445

For -Os, clang driver passes -plugin-opt=Os (https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChains/CommonArgs.cpp#L402) but neither LLVMgold.so nor LLD recognizes -plugin-opt=Os.
-Oz is similar. What is the concrete suggestion here? For quick reference, the -plugin-opt=O logic was added by rL256146.

The issue form my perspective is the inconsistency. Today, lld accepts -plugin-opt=O<number> but it doesn't accept -plugin-opt=O<letter>, but Clang automatically translates -O<anything> to -plugin-opt=O<anything> which results in a failure when your try to use -Os, -Oz or -Og with (Thin)LTO.

May 13 2020, 4:57 PM · Restricted Project
pcc added a comment to D79913: hwasan: Collect ring buffer statistics and include in dev note..

Not sure if there's a good way to test this @eugenis?

May 13 2020, 4:57 PM · Restricted Project
pcc created D79913: hwasan: Collect ring buffer statistics and include in dev note..
May 13 2020, 4:57 PM · Restricted Project

May 12 2020

pcc added a comment to D79822: [AArch64] Emit CFI instruction for updating x18 when using ShadowCallStack with exception unwinding.

It is unclear to me whether removing the nounwind condition is necessary. The wording in the langref talks about "asynchronous exceptions" but only provides semantics for "exception handling schemes that are recognized by LLVM to handle asynchronous exceptions, such as SEH". Since we don't support anything like that on non-Windows. I don't believe that we need to support throwing exceptions past such functions on DWARF platforms, and the unwind info can only be used for the purpose of creating a stack trace.

May 12 2020, 5:15 PM · Restricted Project

May 6 2020

pcc accepted D79522: Allow -fsanitize-minimal-runtime with memtag sanitizer..

LGTM

May 6 2020, 4:30 PM · Restricted Project

May 1 2020

pcc committed rG8fac07a12adc: scudo: Exclude previous tag when retagging freed memory. (authored by pcc).
scudo: Exclude previous tag when retagging freed memory.
May 1 2020, 5:21 PM
pcc closed D79216: scudo: Exclude previous tag when retagging freed memory..
May 1 2020, 5:21 PM · Restricted Project

Apr 30 2020

pcc added a comment to D79153: [lld-macho] Avoid unnecessary preprocessing of relocations.

The architecture may need to be different here IMHO because of subsections. Don't forget that you need to map relocations onto subsections in order to implement gc-sections, and depending on the number of subsections you have per section, that could get expensive without an intermediate data structure. On top of that you'd still need the O(M log N) at output time. To me it seemed better to pay the O(M log N) up front once and avoid the cost at gc-sections time.

Apr 30 2020, 5:11 PM · Restricted Project
pcc created D79216: scudo: Exclude previous tag when retagging freed memory..
Apr 30 2020, 5:11 PM · Restricted Project

Apr 22 2020

pcc committed rG3616e851f66e: scudo: Change the macro used to check whether we're targeting the platform. (authored by pcc).
scudo: Change the macro used to check whether we're targeting the platform.
Apr 22 2020, 10:53 AM
pcc closed D78594: scudo: Change the macro used to check whether we're targeting the platform..
Apr 22 2020, 10:53 AM · Restricted Project

Apr 21 2020

pcc created D78594: scudo: Change the macro used to check whether we're targeting the platform..
Apr 21 2020, 3:44 PM · Restricted Project

Apr 17 2020

pcc committed rG21d50019ca83: scudo: Add support for diagnosing memory errors when memory tagging is enabled. (authored by pcc).
scudo: Add support for diagnosing memory errors when memory tagging is enabled.
Apr 17 2020, 5:31 PM
pcc closed D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 17 2020, 5:31 PM · Restricted Project
pcc added a comment to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..

Thanks Peter & Mitch!
As a side issue, do you have an idea on how to support the interface functions (__scudo_*) for both allocators once we get svelte support?

Apr 17 2020, 5:31 PM · Restricted Project

Apr 16 2020

pcc accepted D77421: [WPD] Avoid noalias assumptions in unique return value optimization.

LGTM

Apr 16 2020, 1:56 PM · Restricted Project

Apr 9 2020

pcc updated the diff for D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
  • Replace the fuzzer with one written by mitchp and fix an overflow bug
  • Move RegionInfo alignment to field to avoid alignment requirement for getErrorInfo callers
Apr 9 2020, 3:30 PM · Restricted Project
pcc committed rG9c86b83ffc8f: scudo: Replace ALIGNED macro with standard alignas specifier. (authored by pcc).
scudo: Replace ALIGNED macro with standard alignas specifier.
Apr 9 2020, 2:43 PM
pcc closed D77823: scudo: Replace ALIGNED macro with standard alignas specifier..
Apr 9 2020, 2:43 PM · Restricted Project
pcc added a comment to D77823: scudo: Replace ALIGNED macro with standard alignas specifier..

Did you verify this works on Fuchsia by chance?

Apr 9 2020, 2:11 PM · Restricted Project
pcc created D77823: scudo: Replace ALIGNED macro with standard alignas specifier..
Apr 9 2020, 1:50 PM · Restricted Project
pcc added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 9 2020, 1:04 PM · Restricted Project
pcc updated the diff for D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
  • Fix build error
Apr 9 2020, 1:02 PM · Restricted Project

Apr 8 2020

pcc updated the diff for D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
  • Add fuzzer, fix bugs found using it
Apr 8 2020, 7:01 PM · Restricted Project
pcc added inline comments to D77421: [WPD] Avoid noalias assumptions in unique return value optimization.
Apr 8 2020, 1:03 PM · Restricted Project
pcc added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 8 2020, 9:45 AM · Restricted Project

Apr 7 2020

pcc added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 7 2020, 6:00 PM · Restricted Project

Apr 6 2020

pcc added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 6 2020, 1:37 PM · Restricted Project

Apr 3 2020

pcc added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 3 2020, 8:02 PM · Restricted Project
pcc updated the diff for D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
  • Address review comments
Apr 3 2020, 8:02 PM · Restricted Project

Apr 1 2020

pcc created D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Apr 1 2020, 8:42 PM · Restricted Project

Mar 27 2020

pcc added a comment to D76322: tsan: Adding releaseAcquire() to ThreadClock.

It looks like this change broke the sanitizer-x86_64-linux-autoconf buildbot.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/48824

/b/sanitizer-x86_64-linux-autoconf/build/llvm-project/compiler-rt/lib/tsan/rtl/tsan_clock.cpp:190:13: error: use of undeclared identifier 'dst'
  DCHECK_LE(dst->size_, kMaxTid);
            ^
1 error generated.

Can you please take a look?

Mar 27 2020, 1:43 PM

Mar 26 2020

pcc added a comment to D76578: [compiler-rt] Intercept the uname() function.

This change broke the sanitizer-x86_64-linux bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26313
Please take a look.

Mar 26 2020, 12:33 PM · Restricted Project

Mar 23 2020

pcc committed rG8140f6bcde42: scudo: Create a public include directory. NFCI. (authored by pcc).
scudo: Create a public include directory. NFCI.
Mar 23 2020, 6:32 PM
pcc closed D76648: scudo: Create a public include directory. NFCI..
Mar 23 2020, 6:32 PM · Restricted Project
pcc created D76648: scudo: Create a public include directory. NFCI..
Mar 23 2020, 4:21 PM · Restricted Project
pcc added a comment to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.

Having given this some more thought, I'm still not in favour of this change even with start/stop symbols excluded, since there are other cases where enumeration of SHF_LINK_ORDER sections may be possible/desirable. To give one example, imagine that you have .init_array sections linked to the globals that they initialize (this may be possible if you can prove that the constructor has no side effects other than initializing the object). With this change we may for example have multiple .init_array sections for .bss and .data, which would need to be accounted for when computing DT_INIT_ARRAY/DT_INIT_ARRAY_SZ. There are various ways that you could deal with this sort of situation, but it seems like the simplest one would be to stick with one output section per file.

Mar 23 2020, 1:38 PM · Restricted Project
pcc added a comment to D76058: [OpenMPOpt] Validate declaration types against the expected types .

This change broke the msan buildbot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/39755

==70358==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5a602b2 in deleteParallelRegions /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/IPO/OpenMPOpt.cpp:127:9
    #1 0x5a602b2 in (anonymous namespace)::OpenMPOpt::run() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/IPO/OpenMPOpt.cpp:116:16
    #2 0x5a94252 in (anonymous namespace)::OpenMPOptLegacyPass::runOnSCC(llvm::CallGraphSCC&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/IPO/OpenMPOpt.cpp:559:19
    #3 0x3f53893 in RunPassOnSCC /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:139:23
Mar 23 2020, 12:33 PM · Restricted Project, Restricted Project

Mar 20 2020

pcc requested changes to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.
Mar 20 2020, 5:22 PM · Restricted Project

Mar 12 2020

pcc added inline comments to D75655: [Docs] Document -lto-whole-program-visibility.
Mar 12 2020, 10:18 AM · Restricted Project

Mar 5 2020

pcc added inline comments to D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Mar 5 2020, 11:32 AM · Restricted Project, Restricted Project
pcc added a comment to D75617: [WPD] Provide a way to prevent function(s) from being devirtualized.

@pcc Just to clarify: I'm using this patch to identify problems with WPD (typically those are either invalid reinterpret_cast or open type hierarchy). I find it convenient to obtain a list of devirtualized functions using pass remarks, "undevirtualize" some of them relink and run. With attributes it seems to be much harder

Mar 5 2020, 11:32 AM · Restricted Project
pcc added a comment to D75617: [WPD] Provide a way to prevent function(s) from being devirtualized.

There is already a way to do this, with the attribute [[clang::lto_visibility_public]]. Why do you need another one?

Mar 5 2020, 10:57 AM · Restricted Project
pcc added inline comments to D75655: [Docs] Document -lto-whole-program-visibility.
Mar 5 2020, 10:57 AM · Restricted Project

Mar 3 2020

pcc added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 3 2020, 9:39 AM · Restricted Project

Mar 2 2020

pcc added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 2 2020, 1:43 PM · Restricted Project
pcc added inline comments to D75382: [lld] Initial commit for new Mach-O backend.
Mar 2 2020, 12:03 PM · Restricted Project
pcc added inline comments to D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Mar 2 2020, 11:36 AM · Restricted Project, Restricted Project

Feb 24 2020

pcc committed rG0414c5694073: Revert "Rework go bindings so that validation works fine" (authored by pcc).
Revert "Rework go bindings so that validation works fine"
Feb 24 2020, 9:26 AM
pcc added a reverting change for rGe8f8873da5ea: Rework go bindings so that validation works fine: rG0414c5694073: Revert "Rework go bindings so that validation works fine".
Feb 24 2020, 9:26 AM
pcc added a comment to D75060: [test][go]Use -stdlib=libc++ to build GO binding test if LLVM is built with libc++.

This should be fixed by rG0414c5694073de26fd33a0276c47c6adea5284cf.

Feb 24 2020, 9:26 AM · Restricted Project
pcc added a comment to D74540: Rework go bindings so that binding tests work fine.

Now that llvm-go has been brought back, I've reverted this change.

Feb 24 2020, 9:26 AM · Restricted Project

Feb 13 2020

pcc accepted D74567: [scudo][standalone] Workaround for full regions on Android.

LGTM

Feb 13 2020, 12:52 PM · Restricted Project, Restricted Project
pcc accepted D74567: [scudo][standalone] Workaround for full regions on Android.

Does it make sense to write a test for this?

Feb 13 2020, 9:47 AM · Restricted Project, Restricted Project