Page MenuHomePhabricator

[mlir][Linalg] Modify callback for getting id/nprocs in LinalgDistribution options to allow more general distributions.
ClosedPublic

Authored by mravishankar on Aug 17 2020, 11:20 AM.

Details

Summary

Changing the signature of the callback to send in the ranges for all the parallel loops and expect a vector with the Value to use for the processor-id and number-of-processors for each of the parallel loops.

Diff Detail

Event Timeline

mravishankar created this revision.Aug 17 2020, 11:20 AM
mravishankar requested review of this revision.Aug 17 2020, 11:20 AM
ThomasRaoux accepted this revision.Aug 17 2020, 3:43 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 17 2020, 3:43 PM
hanchung added inline comments.
mlir/include/mlir/Dialect/Linalg/Utils/Utils.h
201

Remove the extra period?

mlir/lib/Dialect/Linalg/Utils/Utils.cpp
361

Is it a tab? :p

mlir/test/lib/Transforms/TestLinalgTransforms.cpp
298

Replace tab with spaces?

300

Replace tab with spaces?

mravishankar marked 2 inline comments as done.Aug 18 2020, 1:24 PM
mravishankar added inline comments.
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
361

It seems to be an artifact of arc/phabricator. The source doesnt have a tab.

mlir/test/lib/Transforms/TestLinalgTransforms.cpp
298

Same here. The source files dont have a tab.

300

Source files dont seem to have the tab.

mravishankar marked an inline comment as done.

Addressing comments and rebase.