Page MenuHomePhabricator

[flang] Add rudimentary empty function lowering to tco
AbandonedPublic

Authored by DavidTruby on Aug 7 2020, 2:14 AM.

Diff Detail

Event Timeline

DavidTruby created this revision.Aug 7 2020, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2020, 2:14 AM
DavidTruby requested review of this revision.Aug 7 2020, 2:14 AM

We really need passes to be tested individually with an opt like tool, let me know if you need more pointers.
I suspect you also should invest up-front in the same registration/description for passes as in the mlir core folder.

flang/lib/Optimizer/CodeGen/CodeGen.cpp
1

There should be a license header here I believe?

18

This kind of option is unusual: if you want to disable passes this is better done at the point where the pass pipeline is built.

(Also please use PassOptions instead of globals)

26

This comment seems misplaced

62

In general passes aren't supposed to depends on external entities like this: they are expected to be registered and invoked from an *-opt tool.

Here isn't clear why it can't just be a private instance for the pass?

DavidTruby abandoned this revision.Sep 22 2020, 9:53 AM

As discussed on flang-dev I am closing this to not block anyone else's progress on upstreaming.