Page MenuHomePhabricator

[mlir] Conversion of ViewOp with memory space to LLVM.
ClosedPublic

Authored by arpith-jacob on Fri, Jul 31, 2:55 PM.

Details

Summary

Handle the case where the ViewOp takes in a memref that has
an memory space.

Diff Detail

Event Timeline

arpith-jacob created this revision.Fri, Jul 31, 2:55 PM
Herald added a project: Restricted Project. · View Herald Transcript
arpith-jacob requested review of this revision.Fri, Jul 31, 2:55 PM
bondhugula requested changes to this revision.Sat, Aug 1, 12:14 AM
bondhugula added a subscriber: bondhugula.
bondhugula added inline comments.
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
2963

memRefType -> srcMemRefType

mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
827

address space -> memory space

Here and in the commit title/summary to be consistent with the terminology in langref and elsewhere.

This revision now requires changes to proceed.Sat, Aug 1, 12:14 AM
arpith-jacob retitled this revision from [mlir] Conversion of ViewOp with address space to LLVM. to [mlir] Conversion of ViewOp with memory space to LLVM..Mon, Aug 3, 8:55 AM
arpith-jacob edited the summary of this revision. (Show Details)
arpith-jacob retitled this revision from [mlir] Conversion of ViewOp with memory space to LLVM. to [mlir] Conversion of ViewOp with address space to LLVM..
arpith-jacob edited the summary of this revision. (Show Details)

Addressed comments. PTAL.

ftynse accepted this revision.Tue, Aug 4, 1:40 AM

LGTM!

bondhugula accepted this revision.Tue, Aug 4, 2:02 AM
This revision is now accepted and ready to land.Tue, Aug 4, 2:02 AM
nicolasvasilache accepted this revision.Tue, Aug 4, 3:29 AM
arpith-jacob retitled this revision from [mlir] Conversion of ViewOp with address space to LLVM. to [mlir] Conversion of ViewOp with memory space to LLVM..Tue, Aug 4, 1:58 PM
arpith-jacob edited the summary of this revision. (Show Details)

Can someone with commit access land this patch? Thanks.

This revision was automatically updated to reflect the committed changes.