Page MenuHomePhabricator

[clangd] Fix remote index build on macOS
ClosedPublic

Authored by kbobyrev on Jul 30 2020, 3:18 AM.

Details

Summary

macOS builds suddenly started failing:

https://github.com/kirillbobyrev/indexing-tools/runs/925090879

This patch makes use of imported libraries and fixes builds for macOS.

Diff Detail

Event Timeline

kbobyrev created this revision.Jul 30 2020, 3:18 AM
kbobyrev requested review of this revision.Jul 30 2020, 3:18 AM
kbobyrev edited reviewers, added: hokein; removed: sammccall.Jul 30 2020, 8:03 AM
kbobyrev edited the summary of this revision. (Show Details)Jul 30 2020, 11:40 AM

Hmm, apparently link_libraries is not supposed to be used this way as it adds to linker search path _after_ it's called (from the docs) but this still worked for me on mac before. Hence I was relying on incorrect behaviour, my bad.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2020, 5:03 AM
This revision was automatically updated to reflect the committed changes.