Page MenuHomePhabricator

kbobyrev (Kirill Bobyrev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2018, 7:14 AM (143 w, 5 d)

Recent Activity

Fri, Apr 9

kbobyrev accepted D100103: [clangd] Log a message when gRPC support is off, but remote-index is configured.

Thanks!

Fri, Apr 9, 4:26 AM · Restricted Project

Wed, Apr 7

kbobyrev committed rGf37ea62e57b5: [CMake] try creating symlink first on windows (authored by kbobyrev).
[CMake] try creating symlink first on windows
Wed, Apr 7, 2:23 AM
kbobyrev closed D99170: [CMake] try creating symlink first on windows.
Wed, Apr 7, 2:23 AM · Restricted Project

Tue, Apr 6

kbobyrev added a comment to D98748: [clangd] Add support for inline parameter hints.

Hey, I just wanted to say thank you! This is a rust-analyzer feature I really like when writing Rust code but somehow never thought about bringing it to Clangd. This is a nice idea, huge thanks for implementing it!

Tue, Apr 6, 6:06 AM · Restricted Project

Tue, Mar 30

kbobyrev accepted D99170: [CMake] try creating symlink first on windows.

I don't have a Windows machine to test this out but the change looks reasonable to me and the "fallback to COPY" should probably be enough in this case.

Tue, Mar 30, 11:39 PM · Restricted Project
kbobyrev accepted D98377: [clangd] Show padding following a field on field hover..

LGTM, thanks!

Tue, Mar 30, 4:23 AM · Restricted Project, Restricted Project

Fri, Mar 26

kbobyrev accepted D99405: [CMake][gRPC] Fix a typo in protobuf version variable name.

Good catch, thanks!

Fri, Mar 26, 8:53 AM · Restricted Project

Mar 16 2021

kbobyrev committed rG524fe515091d: [clangd] Add basic monitoring info request for remote index server (authored by kbobyrev).
[clangd] Add basic monitoring info request for remote index server
Mar 16 2021, 5:38 AM
kbobyrev closed D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 16 2021, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the summary of D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 16 2021, 5:36 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Resolve review comments.

Mar 16 2021, 4:32 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2021

kbobyrev added inline comments to D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 15 2021, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Address comments, rebase on top of main.

Mar 15 2021, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
kbobyrev committed rG9bcf0eff99a0: [clangd] Optionally add reflection for clangd-index-server (authored by kbobyrev).
[clangd] Optionally add reflection for clangd-index-server
Mar 15 2021, 1:08 PM
kbobyrev closed D98404: [clangd] Optionally add reflection for clangd-index-server.
Mar 15 2021, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Resolve post-LGTM comments.

Mar 15 2021, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Resolve review comments.

Mar 15 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Add explicit CMake option.

Mar 15 2021, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Include Features.inc in Server.cpp.

Mar 15 2021, 3:17 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Resolve review comments.

Mar 15 2021, 3:03 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Add the variable to Features.inc.in and canonicalize.

Mar 15 2021, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

kbobyrev added inline comments to D98404: [clangd] Optionally add reflection for clangd-index-server.
Mar 11 2021, 4:01 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98404: [clangd] Optionally add reflection for clangd-index-server.

Address review comments.

Mar 11 2021, 4:00 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev requested review of D98404: [clangd] Optionally add reflection for clangd-index-server.
Mar 11 2021, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Address review comments.

Mar 11 2021, 12:57 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2021

kbobyrev accepted D98164: [clangd] Drop explicit specifier on define out-of-line.
Mar 10 2021, 5:16 AM · Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1

Mar 10 2021, 12:08 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev committed rG8080ea4c4b8c: [clangd] Enable reflection for clangd-index-server (authored by kbobyrev).
[clangd] Enable reflection for clangd-index-server
Mar 10 2021, 12:08 AM

Mar 9 2021

kbobyrev updated subscribers of D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 9 2021, 6:12 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the summary of D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 9 2021, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the summary of D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 9 2021, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev updated the diff for D98246: [clangd] Add basic monitoring info request for remote index server.

Use reflection, improve message format.

Mar 9 2021, 6:06 AM · Restricted Project, Restricted Project, Restricted Project
kbobyrev requested review of D98246: [clangd] Add basic monitoring info request for remote index server.
Mar 9 2021, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2021

kbobyrev added inline comments to D96975: [Sema] Add some basic lambda capture fix-its.
Mar 8 2021, 5:56 AM · Restricted Project
kbobyrev added inline comments to D96975: [Sema] Add some basic lambda capture fix-its.
Mar 8 2021, 5:26 AM · Restricted Project
kbobyrev added inline comments to D96975: [Sema] Add some basic lambda capture fix-its.
Mar 8 2021, 5:00 AM · Restricted Project
kbobyrev accepted D96975: [Sema] Add some basic lambda capture fix-its.

LGTM, thanks for implementing this and apologies for the review delay (was a tough week for me & my team).

Mar 8 2021, 12:35 AM · Restricted Project

Mar 5 2021

kbobyrev added inline comments to D96975: [Sema] Add some basic lambda capture fix-its.
Mar 5 2021, 10:47 AM · Restricted Project
kbobyrev added a comment to D96975: [Sema] Add some basic lambda capture fix-its.

Thanks! The code looks right, my comments are mostly for the comments around to validate my mental model of the code structure and behavior.

Mar 5 2021, 10:44 AM · Restricted Project

Mar 4 2021

kbobyrev committed rGbff7faea2034: [clang-tidy] Add options to describe individual core increments to readability… (authored by massberg).
[clang-tidy] Add options to describe individual core increments to readability…
Mar 4 2021, 12:03 PM
kbobyrev closed D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Mar 4 2021, 12:03 PM · Restricted Project, Restricted Project
kbobyrev added a comment to D97803: [clangd] Overload bundles are only deprecated if each overloads is..

So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated groups?

Mar 4 2021, 1:56 AM · Restricted Project

Mar 1 2021

kbobyrev added a comment to D96975: [Sema] Add some basic lambda capture fix-its.

Ping

Mar 1 2021, 6:42 AM · Restricted Project

Feb 18 2021

kbobyrev abandoned D92220: [clangd] Add support for static fields in rename.

Yeah this does indeed already work.

Feb 18 2021, 5:59 AM · Restricted Project
kbobyrev committed rG19db870a0dd1: [clangd] Drop template argument lists from completions followed by < (authored by kbobyrev).
[clangd] Drop template argument lists from completions followed by <
Feb 18 2021, 4:10 AM
kbobyrev closed D89870: [clangd] Drop template argument lists from completions followed by <.
Feb 18 2021, 4:10 AM · Restricted Project
kbobyrev updated the diff for D89870: [clangd] Drop template argument lists from completions followed by <.

Address review comments

Feb 18 2021, 4:05 AM · Restricted Project

Feb 17 2021

kbobyrev updated the diff for D89870: [clangd] Drop template argument lists from completions followed by <.

Address review comments.

Feb 17 2021, 12:09 PM · Restricted Project

Feb 15 2021

kbobyrev committed rGeefd620a2572: [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer (authored by kbobyrev).
[llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer
Feb 15 2021, 5:53 AM
kbobyrev closed D91600: [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer.
Feb 15 2021, 5:53 AM · Restricted Project
kbobyrev accepted D96112: [Syntax] No crash on OpaqueValueExpr..

Sorry for the delay.

Feb 15 2021, 5:49 AM · Restricted Project

Feb 10 2021

kbobyrev added a comment to D96324: [clangd] Rename references to function arguments within the same file.

@sammccall this is the argument renaming diff I was talking about during the standup.

Feb 10 2021, 6:08 AM · Restricted Project
kbobyrev updated subscribers of D96324: [clangd] Rename references to function arguments within the same file.
Feb 10 2021, 6:08 AM · Restricted Project

Feb 9 2021

kbobyrev accepted D96017: [clang-check] Add tokens-dump in clang-check..

Thanks!

Feb 9 2021, 7:10 AM · Restricted Project
kbobyrev updated the diff for D96324: [clangd] Rename references to function arguments within the same file.

Rebase on top of D96247, check for conflicts in specialization bodies.

Feb 9 2021, 7:08 AM · Restricted Project
kbobyrev committed rGb60428c7ea68: [clangd] Fix false positive in local rename collision detetction (authored by kbobyrev).
[clangd] Fix false positive in local rename collision detetction
Feb 9 2021, 2:51 AM
kbobyrev closed D96247: [clangd] Fix false positive in local rename collision detetction.
Feb 9 2021, 2:51 AM · Restricted Project
kbobyrev updated the diff for D96247: [clangd] Fix false positive in local rename collision detetction.

Resolve review comment.

Feb 9 2021, 2:45 AM · Restricted Project
kbobyrev added a comment to D96324: [clangd] Rename references to function arguments within the same file.

This likely needs some further thought on conflict detection. Assume we have

Feb 9 2021, 2:42 AM · Restricted Project
kbobyrev updated the summary of D96324: [clangd] Rename references to function arguments within the same file.
Feb 9 2021, 2:38 AM · Restricted Project
kbobyrev updated the diff for D96324: [clangd] Rename references to function arguments within the same file.

Implement constructors handling.

Feb 9 2021, 2:37 AM · Restricted Project
kbobyrev requested review of D96324: [clangd] Rename references to function arguments within the same file.
Feb 9 2021, 1:53 AM · Restricted Project

Feb 8 2021

kbobyrev updated the diff for D96247: [clangd] Fix false positive in local rename collision detetction.

Fix comment formatting in the test.

Feb 8 2021, 12:53 AM · Restricted Project
kbobyrev requested review of D96247: [clangd] Fix false positive in local rename collision detetction.
Feb 8 2021, 12:53 AM · Restricted Project

Feb 4 2021

kbobyrev edited reviewers for D89870: [clangd] Drop template argument lists from completions followed by <, added: kadircet; removed: sammccall.
Feb 4 2021, 11:27 PM · Restricted Project
kbobyrev committed rGe8a2b7c91563: [clangd] Improve name conflict detection (authored by kbobyrev).
[clangd] Improve name conflict detection
Feb 4 2021, 12:38 PM
kbobyrev closed D96009: [clangd] Improve name conflict detection.
Feb 4 2021, 12:37 PM · Restricted Project
kbobyrev updated the diff for D96009: [clangd] Improve name conflict detection.

Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :(

Feb 4 2021, 12:36 PM · Restricted Project
kbobyrev updated the diff for D96009: [clangd] Improve name conflict detection.

Use FunctionProtoTypeLoc

Feb 4 2021, 5:38 AM · Restricted Project
kbobyrev requested review of D96009: [clangd] Improve name conflict detection.
Feb 4 2021, 3:08 AM · Restricted Project
kbobyrev committed rG5eec9a380a24: [clangd] Detect rename conflicits within enclosing scope (authored by kbobyrev).
[clangd] Detect rename conflicits within enclosing scope
Feb 4 2021, 12:46 AM
kbobyrev closed D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 4 2021, 12:46 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Pass const ref to DynTypedNode in helper.

Feb 4 2021, 12:36 AM · Restricted Project
kbobyrev added inline comments to D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 4 2021, 12:30 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Fix a couple problems pointed out during the review.

Feb 4 2021, 12:30 AM · Restricted Project

Feb 3 2021

kbobyrev added a comment to D89870: [clangd] Drop template argument lists from completions followed by <.

@sammccall Ping, this is a real patch :)

Feb 3 2021, 7:01 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Add comments.

Feb 3 2021, 7:00 AM · Restricted Project
kbobyrev added inline comments to D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 3 2021, 6:45 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Resolve most comments but one: some comments & examples in the code incoming in
the next diff.

Feb 3 2021, 6:35 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Revert last change: leads to incomplete types.

Feb 3 2021, 4:29 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Don't spell out DynTypedNodeList and don't include ParentMapContext.h

Feb 3 2021, 4:28 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Save few LOCs by checking for nullptr in CheckDeclStmt.

Feb 3 2021, 4:26 AM · Restricted Project
kbobyrev added inline comments to D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 3 2021, 4:23 AM · Restricted Project
kbobyrev updated the diff for D95925: [clangd] Detect rename conflicits within enclosing scope.

Resolve review comments.

Feb 3 2021, 4:22 AM · Restricted Project

Feb 2 2021

kbobyrev requested review of D95925: [clangd] Detect rename conflicits within enclosing scope.
Feb 2 2021, 10:08 PM · Restricted Project

Jan 29 2021

kbobyrev accepted D95450: [clangd] Respect ReferencesParams.context.includeDeclarations.

Thanks, LGTM with a couple of nits.

Jan 29 2021, 4:11 AM · Restricted Project

Jan 25 2021

kbobyrev committed rGc8d2ae52c15b: [clang] NFC: Remove else-after-return pattern from some files (authored by kbobyrev).
[clang] NFC: Remove else-after-return pattern from some files
Jan 25 2021, 2:14 AM
kbobyrev committed rG7e5d41a68255: [clang] NFC: Remove else if after return (authored by kbobyrev).
[clang] NFC: Remove else if after return
Jan 25 2021, 1:59 AM
kbobyrev closed D95336: [clang] NFC: Remove else if after return.
Jan 25 2021, 1:58 AM · Restricted Project
kbobyrev requested review of D95336: [clang] NFC: Remove else if after return.
Jan 25 2021, 1:37 AM · Restricted Project

Jan 13 2021

kbobyrev abandoned D94479: [clangd] Extend hints for gRPC and Protobuf CMake config paths.

As mentioned offline, this is not the right fix :( The correct one is pushed to our CI.

Jan 13 2021, 11:21 PM · Restricted Project

Jan 12 2021

kbobyrev requested review of D94479: [clangd] Extend hints for gRPC and Protobuf CMake config paths.
Jan 12 2021, 1:53 AM · Restricted Project

Dec 16 2020

kbobyrev added inline comments to D92788: [clangd] NFC: Use SmallVector<T> where possible.
Dec 16 2020, 10:58 AM · Restricted Project

Dec 15 2020

kbobyrev committed rG0545680cb870: Reland dcdef5b5b3df457566e7faf61e1e5789c42528d1 (authored by kbobyrev).
Reland dcdef5b5b3df457566e7faf61e1e5789c42528d1
Dec 15 2020, 11:55 AM
kbobyrev added a reverting change for rGdcdef5b5b3df: [clangd] Log remote index connectivity status: rG32e7a9cab641: Revert "[clangd] Log remote index connectivity status".
Dec 15 2020, 9:43 AM
kbobyrev added a reverting change for D92198: [clangd] Log remote index connectivity status: rG32e7a9cab641: Revert "[clangd] Log remote index connectivity status".
Dec 15 2020, 9:43 AM · Restricted Project
kbobyrev committed rG32e7a9cab641: Revert "[clangd] Log remote index connectivity status" (authored by kbobyrev).
Revert "[clangd] Log remote index connectivity status"
Dec 15 2020, 9:43 AM
kbobyrev committed rGdcdef5b5b3df: [clangd] Log remote index connectivity status (authored by kbobyrev).
[clangd] Log remote index connectivity status
Dec 15 2020, 9:30 AM
kbobyrev closed D92198: [clangd] Log remote index connectivity status.
Dec 15 2020, 9:30 AM · Restricted Project
kbobyrev updated the diff for D92198: [clangd] Log remote index connectivity status.

Actually clean up rebase artifacts.

Dec 15 2020, 9:28 AM · Restricted Project