Page MenuHomePhabricator

GlobalISel: Set instr/debugloc before any legalizer action
ClosedPublic

Authored by arsenm on Jun 8 2020, 6:46 AM.

Details

Summary

It was annoying enough that every custom lowering needed to set the
insert point, but this was made worse since now these all needed to be
updated to setInstrAndDebugLoc. Consolidate these so every
legalization action has the right insert position by default.

This should fix dropping debug info in every custom AMDGPU
legalization.

Diff Detail

Event Timeline

arsenm created this revision.Jun 8 2020, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 6:46 AM
aprantl added a reviewer: vsk.Jun 8 2020, 10:03 AM
aprantl added a project: debug-info.

Looks good.

This revision is now accepted and ready to land.Jun 8 2020, 11:27 AM
dsanders accepted this revision.Jun 9 2020, 9:53 AM

LGTM