This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Move Verifier and Dominance Analysis from /Analysis to /IR
ClosedPublic

Authored by stephenneuendorffer on May 1 2020, 9:30 AM.

Details

Summary

These libraries are distinct from other things in Analysis in that they
operate only on core IR concepts. This also simplifies dependencies
so that Dialect -> Analysis -> Parser -> IR. Previously, the parser depended
on portions of the the Analysis directory as well, which sometimes
caused issues with the way the cmake makefile generator discovers
dependencies on generated files during compilation.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
rriddle requested changes to this revision.May 1 2020, 10:15 AM

The files are marked as being added, but I would have expected something to mark the original locations as being moved/deleted.

mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
18

Can you fix these include orderings now? I would expect a run of clang-format to handle it.

mlir/include/mlir/IR/Dominance.h
9

MLIR_IR_ Now

mlir/include/mlir/IR/Verifier.h
9

MLIR_IR

This revision now requires changes to proceed.May 1 2020, 10:15 AM
stephenneuendorffer marked 3 inline comments as done.May 1 2020, 5:38 PM
rriddle accepted this revision.May 1 2020, 6:19 PM
rriddle added inline comments.
mlir/lib/IR/Verifier.cpp
31

This one is an exception, generally if there is a matching header it should be included first.

This revision is now accepted and ready to land.May 1 2020, 6:19 PM
stephenneuendorffer marked 2 inline comments as done.May 1 2020, 8:09 PM
stephenneuendorffer added inline comments.
mlir/lib/IR/Verifier.cpp
31

And I was confused by the fact that git clang-format did something wierd with it!

This revision was automatically updated to reflect the committed changes.
stephenneuendorffer marked an inline comment as done.