Page MenuHomePhabricator

[PowerPC] Fix missing GOT indirect variant kind
ClosedPublic

Authored by stefanp on Apr 28 2020, 8:55 AM.

Details

Summary

The function MCSymbolRefExpr::getVariantKindForName was missing the entry for VK_PPC_GOT_PCREL.
This patch adds the missing entry.

Diff Detail

Event Timeline

stefanp created this revision.Apr 28 2020, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 8:55 AM
kamaub accepted this revision as: kamaub.May 4 2020, 11:39 AM
kamaub added a subscriber: kamaub.

This LGTM, one minor comment about test case explanation, it can be done pre-commit for sure.

llvm/test/MC/PowerPC/future-reloc.s
6

Could you add a brief explanation of this test case here

This revision is now accepted and ready to land.May 4 2020, 11:39 AM
This revision was automatically updated to reflect the committed changes.