Page MenuHomePhabricator
People lei

lei (Lei Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 11:46 AM (209 w, 4 d)

Recent Activity
View All

Fri, Oct 23

lei accepted D89345: [PowerPC] Add intrinsics for MMA.
Fri, Oct 23, 7:34 AM · Restricted Project, Restricted Project
lei accepted D87705: [PowerPC] Implement Set Boolean Condition Instructions.

LGTM. Thanks for the update.
Please address the additional comments on commit.

Fri, Oct 23, 6:19 AM · Restricted Project, Restricted Project

Thu, Oct 22

lei added inline comments to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..
Thu, Oct 22, 7:31 AM · Restricted Project, Restricted Project
lei added a comment to D87705: [PowerPC] Implement Set Boolean Condition Instructions.

For the p10 specific tests, I think just use the default CHECK vs CHECK-P10.
Also, please ensure we are testing on both BE and LE.

Thu, Oct 22, 6:16 AM · Restricted Project, Restricted Project

Sep 18 2020

lei accepted D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

LGTM. Thx!

Sep 18 2020, 12:39 PM · Restricted Project, Restricted Project
lei added a comment to D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

please fix the clang format issues.

Sep 18 2020, 7:05 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.

Just some minor comments. Please address them prior to commit.

Sep 18 2020, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2020

lei accepted D84847: [PowerPC] Add accumulator register class and instructions.

LGTM

Sep 17 2020, 3:13 PM · Restricted Project, Restricted Project
lei added inline comments to D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Sep 17 2020, 2:52 PM · Restricted Project, Restricted Project

Sep 11 2020

lei accepted D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.

LGTM

Sep 11 2020, 10:54 AM · Restricted Project

Aug 26 2020

lei accepted D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.

LGTM
Thx!

Aug 26 2020, 1:32 PM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2020

lei committed rG7aaa85627b59: [PowerPC] Add options to control paired vector memops support (authored by bsaleil).
[PowerPC] Add options to control paired vector memops support
Jul 29 2020, 12:01 PM
lei closed D83722: [PowerPC] Add options to control paired vector memops support.
Jul 29 2020, 12:01 PM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2020

lei added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Please address the auto generated clang-format issues for the added code in this patch.

Jul 27 2020, 6:38 AM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 27 2020, 6:18 AM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2020

lei accepted D84382: [PowerPC][Power10] Cleanup p10vector clang test.

LGTM
thx!

Jul 23 2020, 5:34 AM · Restricted Project
lei accepted D84384: [PowerPC][Power10] Add Vector Extract Double Instruction Definitions and MC tests.

LGTM

Jul 23 2020, 5:31 AM · Restricted Project
lei added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 23 2020, 5:23 AM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.

Why are you removing MC tests for here?

Jul 23 2020, 5:19 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

LGTM,
Please add tests for BE in llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll prior to committing.

Jul 23 2020, 4:55 AM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2020

lei accepted D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests.

LGTM
Please address the nits on commit.

Jul 10 2020, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
lei committed rG90b1a710aede: [PowerPC] Enable default support of quad precision operations (authored by lei).
[PowerPC] Enable default support of quad precision operations
Jul 10 2020, 11:28 AM
lei closed D83437: [PowerPC] Enable default support of quad precision operations.
Jul 10 2020, 11:27 AM · Restricted Project

Jul 9 2020

lei accepted D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

LGTM

Jul 9 2020, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Jul 9 2020, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
lei added a reviewer for D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.: rzurob.
Jul 9 2020, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.

LGTM thx.

Jul 9 2020, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
lei removed a reviewer for D83437: [PowerPC] Enable default support of quad precision operations: • qshanz.
Jul 9 2020, 6:24 AM · Restricted Project

Jul 8 2020

lei added a reviewer for D83437: [PowerPC] Enable default support of quad precision operations: • qshanz.
Jul 8 2020, 3:21 PM · Restricted Project
lei added reviewers for D83437: [PowerPC] Enable default support of quad precision operations: nemanjai, Restricted Project.
Jul 8 2020, 3:20 PM · Restricted Project
Herald added a project to D83437: [PowerPC] Enable default support of quad precision operations: Restricted Project.
Jul 8 2020, 3:19 PM · Restricted Project
lei added inline comments to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Jul 8 2020, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D82510: [PowerPC][Power10] Implement low-order Vector Multiply, Modulus and Divide Instructions.

This LGTM, just wondering why you have not included testing for BE.

Jul 8 2020, 11:38 AM · Restricted Project, Restricted Project
lei added inline comments to D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.
Jul 8 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2020

lei committed rG62ba48b45f65: [PowerPC] Implement Vector Replace Builtins in LLVM (authored by biplmish).
[PowerPC] Implement Vector Replace Builtins in LLVM
Jul 7 2020, 10:24 AM
lei closed D83308: [Power10] Implement Vector Replace Builtins in LLVM.
Jul 7 2020, 10:24 AM · Restricted Project
lei added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 7 2020, 6:45 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2020

lei committed rG0c6b6e28e70c: [PowerPC] Implement Vector Splat Immediate Builtins in Clang (authored by biplmish).
[PowerPC] Implement Vector Splat Immediate Builtins in Clang
Jul 6 2020, 6:31 PM
lei closed D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.
Jul 6 2020, 6:31 PM · Restricted Project, Restricted Project
lei accepted D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..

LGTM

Jul 6 2020, 1:51 PM · Restricted Project
lei accepted D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.

LGTM

Jul 6 2020, 1:06 PM · Restricted Project, Restricted Project
lei added inline comments to D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..
Jul 6 2020, 12:40 PM · Restricted Project
lei added inline comments to D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..
Jul 6 2020, 11:44 AM · Restricted Project
lei added inline comments to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.
Jul 6 2020, 11:16 AM · Restricted Project, Restricted Project
lei added inline comments to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.
Jul 6 2020, 10:25 AM · Restricted Project, Restricted Project
lei added inline comments to D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang.
Jul 6 2020, 9:38 AM · Restricted Project
lei added inline comments to D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.
Jul 6 2020, 6:42 AM · Restricted Project, Restricted Project
lei added inline comments to D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang.
Jul 6 2020, 6:38 AM · Restricted Project

Jul 3 2020

lei committed rGe359ab1eca57: [PowerPC][NFC] Fix indentation (authored by lei).
[PowerPC][NFC] Fix indentation
Jul 3 2020, 3:14 PM
lei added inline comments to D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang.
Jul 3 2020, 3:14 PM · Restricted Project
lei requested changes to D82359: [Power10] Implement Vector Replace Builtins in LLVM/Clang.

This patch doesn't contain full context. Please regenerate with -U999999.

Jul 3 2020, 2:09 PM · Restricted Project
lei added inline comments to D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.
Jul 3 2020, 2:09 PM · Restricted Project, Restricted Project
lei committed rG0939e04e4176: [PowerPC] Implement Vector Insert Builtins in LLVM/Clang (authored by biplmish).
[PowerPC] Implement Vector Insert Builtins in LLVM/Clang
Jul 3 2020, 1:38 PM
lei closed D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.
Jul 3 2020, 1:37 PM · Restricted Project, Restricted Project
lei added a comment to D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.

I will commit this for Biplob since he does't have commit access yet.

Jul 3 2020, 10:44 AM · Restricted Project, Restricted Project
lei added inline comments to D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang.
Jul 3 2020, 6:26 AM · Restricted Project, Restricted Project

Jul 2 2020

lei committed rGca464639a1c9: [PowerPC] Implement Vector Blend Builtins in LLVM/Clang (authored by biplmish).
[PowerPC] Implement Vector Blend Builtins in LLVM/Clang
Jul 2 2020, 3:09 PM
lei closed D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.
Jul 2 2020, 3:08 PM · Restricted Project, Restricted Project
lei committed rG6076fc698df4: [PowerPC]Add Vector Insert Instruction Definitions and MC Test (authored by amyk).
[PowerPC]Add Vector Insert Instruction Definitions and MC Test
Jul 2 2020, 2:04 PM
lei closed D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests.
Jul 2 2020, 2:04 PM · Restricted Project, Restricted Project
lei added a comment to D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.

LGTM.

Jul 2 2020, 2:03 PM · Restricted Project, Restricted Project
lei committed rG286073484f7d: [PowerPC]Implement Vector Permute Extended Builtin (authored by biplmish).
[PowerPC]Implement Vector Permute Extended Builtin
Jul 2 2020, 12:59 PM
lei closed D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.
Jul 2 2020, 12:58 PM · Restricted Project, Restricted Project
lei added inline comments to D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.
Jul 2 2020, 12:25 PM · Restricted Project, Restricted Project
lei added inline comments to D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.
Jul 2 2020, 10:47 AM · Restricted Project, Restricted Project
lei accepted D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests.

LGTM

Jul 2 2020, 10:47 AM · Restricted Project, Restricted Project
lei added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 2 2020, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
lei requested changes to D83052: [PowerPC][Power10] Add Vector Insert Instruction Definitions and MC Tests.
Jul 2 2020, 8:37 AM · Restricted Project, Restricted Project
lei added inline comments to D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.
Jul 2 2020, 7:31 AM · Restricted Project, Restricted Project
lei added inline comments to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.
Jul 2 2020, 6:57 AM · Restricted Project, Restricted Project

Jul 1 2020

lei committed rG88874f074644: [PowerPC]Implement Vector Shift Double Bit Immediate Builtins (authored by biplmish).
[PowerPC]Implement Vector Shift Double Bit Immediate Builtins
Jul 1 2020, 6:55 PM
lei closed D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.
Jul 1 2020, 6:54 PM · Restricted Project, Restricted Project
lei committed rG99c4207d428b: [PowerPC][NFC] Update doc for FeatureISA3_1/FeatureISA3_0 definitions (authored by lei).
[PowerPC][NFC] Update doc for FeatureISA3_1/FeatureISA3_0 definitions
Jul 1 2020, 5:51 PM
lei committed rGc5b4f03b53a4: [PowerPC] Exploit xxspltiw and xxspltidp instructions (authored by anil9).
[PowerPC] Exploit xxspltiw and xxspltidp instructions
Jul 1 2020, 5:22 PM
lei closed D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 5:22 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 1:32 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

rename test file and add additional ccomments to code.

Jul 1 2020, 1:32 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

revert changes to the if condition

Jul 1 2020, 12:59 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jul 1 2020, 12:26 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

Remove unnecessary FIXME message, accidental formating, and simplify if-condition as suggested by Victor.

Jul 1 2020, 12:26 PM · Restricted Project
lei updated the diff for D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
  • clean up condition code in isFPImmLegal()
  • split test file into pcrel and non-pcrel related, clean up checks
  • add test for BE elfv2
Jul 1 2020, 10:48 AM · Restricted Project
lei commandeered D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..

Taking over ownership to address review comments.

Jul 1 2020, 10:48 AM · Restricted Project
lei added inline comments to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.
Jul 1 2020, 7:00 AM · Restricted Project, Restricted Project
lei accepted D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.

Please address nits and file name changes on commit.

Jul 1 2020, 7:00 AM · Restricted Project, Restricted Project
lei added a comment to D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang.

p10-permute-ops.ll => builtins-ppc-p10permute.ll
Looks like this file is being created in several diff patches you have up for review.

Jul 1 2020, 6:28 AM · Restricted Project, Restricted Project
lei added a comment to D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang.

p10-permute-ops.ll => builtins-ppc-p10permute.ll

Jul 1 2020, 6:28 AM · Restricted Project, Restricted Project
lei requested changes to D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang.

Please use similar naming for all new builtin test files:
p10-permute-ops.ll => builtins-ppc-p10permute.ll

Jul 1 2020, 6:27 AM · Restricted Project, Restricted Project
lei added inline comments to D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.
Jul 1 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82929: [PowerPC][Power10] Add Vector Multiply/Mod/Divide Instruction Definitions and MC Tests.

LGTM

Jul 1 2020, 5:22 AM · Restricted Project, Restricted Project

Jun 30 2020

lei requested changes to D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

Please move encoding tests to ppc64-encoding-ISA31.[txt|s].

Jun 30 2020, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.

LGTM thx!

Jun 30 2020, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 8:35 PM · Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 8:35 PM · Restricted Project
lei added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Please move encoding tests to ppc64-encoding-ISA31.[txt|s].

Jun 30 2020, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions..
Jun 30 2020, 3:14 PM · Restricted Project
lei added a comment to D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.

encoding tests need to be placed in corresponding ppc64-encoding-ISA31* files

Jun 30 2020, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
lei accepted D82896: [PowerPC][Power10] Add Vector Splat Immediate, Permute, Blend, Shift Double Bit immediate Instruction Definitions and MC Tests .

LGTM other then the minor nit that can be address on commit.

Jun 30 2020, 11:56 AM · Restricted Project, Restricted Project
lei committed rG3163269275dc: [PowerPC][NFC] Rename/organize encoding test files for ISA3.1 (authored by lei).
[PowerPC][NFC] Rename/organize encoding test files for ISA3.1
Jun 30 2020, 10:19 AM
lei requested changes to D82859: [Power10] Implement VSX vector permute extended instruction.

The asm instr should go into the appropriate files. Nothing with p10 in them.

Jun 30 2020, 6:28 AM · Restricted Project

Jun 29 2020

lei committed rGaf9cc2d2afe8: [PowerPC] Fix FeatureISA3_1 def in PPC.td to imply FeatureISA3_0. (authored by lei).
[PowerPC] Fix FeatureISA3_1 def in PPC.td to imply FeatureISA3_0.
Jun 29 2020, 2:25 PM