Page MenuHomePhabricator

kamaub (Kamau Bridgeman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2019, 12:39 PM (73 w, 2 d)

Recent Activity

Mon, Oct 12

kamaub accepted D88738: [PowerPC][PCRelative] Turn on TLS support for PCRel by default.

This LGTM

Mon, Oct 12, 2:02 PM · Restricted Project

Sat, Oct 10

kamaub added a project to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions.: Restricted Project.
Sat, Oct 10, 11:44 AM · Restricted Project, Restricted Project
kamaub requested review of D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..
Sat, Oct 10, 11:40 AM · Restricted Project, Restricted Project

Sep 1 2020

kamaub added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Sep 1 2020, 12:00 PM · Restricted Project, Restricted Project

Aug 21 2020

kamaub committed rG365f861c45bb: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec (authored by kamaub).
[PowerPC][PCRelative] Thread Local Storage Support for Initial Exec
Aug 21 2020, 8:13 AM
kamaub closed D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.
Aug 21 2020, 8:13 AM · Restricted Project, Restricted Project

Aug 20 2020

kamaub committed rGb74b80bb2d31: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic (authored by kamaub).
[PowerPC][PCRelative] Thread Local Storage Support for General Dynamic
Aug 20 2020, 1:08 PM
kamaub closed D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
Aug 20 2020, 1:08 PM · Restricted Project, Restricted Project

Aug 14 2020

kamaub accepted D85978: [clang-tools-extra] Added missing comma.

This LGTM

Aug 14 2020, 10:54 AM · Restricted Project

Aug 10 2020

kamaub added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots:
It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with -Werror
Please also note that it introduced 103 warnings in clang-ppc64le-linux-multistage/builds/13042

Aug 10 2020, 12:46 PM · Restricted Project

Aug 7 2020

kamaub committed rGd8c6d083c954: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops (authored by kamaub).
[PowerPC][PCRelative] Set TLS unsupported with PC relative memops
Aug 7 2020, 8:57 AM
kamaub closed D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 7 2020, 8:56 AM · Restricted Project, Restricted Project
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Rebasing and updating patch to use TLS enablement option.

Aug 7 2020, 6:39 AM · Restricted Project, Restricted Project

Aug 6 2020

kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Rebasing patch on D85448 and editing test cases to use enablement option.

Aug 6 2020, 12:09 PM · Restricted Project, Restricted Project
kamaub updated the summary of D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 6 2020, 11:21 AM · Restricted Project, Restricted Project
kamaub updated the diff for D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.

Replacing assert() with report_fatal_error()

Aug 6 2020, 11:20 AM · Restricted Project, Restricted Project
kamaub added a project to D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops: Restricted Project.
Aug 6 2020, 10:34 AM · Restricted Project, Restricted Project
kamaub requested review of D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 6 2020, 10:32 AM · Restricted Project, Restricted Project

Aug 5 2020

kamaub updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Rebasing on most recent D81947 and addressing review comments:

  • rebasing on the updated version of D81947
  • updating test cases according to review comments
  • updating comments in code
  • updating llvm-readobj run lines to follow new interface
Aug 5 2020, 1:42 PM · Restricted Project, Restricted Project
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Rebasing and addressing review comments:

  • rebased on the updated version of D82315
  • updated test cases according to reviews
  • updated llvm-readobj run lines in test cases to reflect interface change
Aug 5 2020, 11:08 AM · Restricted Project, Restricted Project
kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Addressing review comments and updating test cases:

  • rebasing the patch on to a more recent master and fixed merge conflicts
  • changed test cases to remove unnecessary bloat and update run lines.
Aug 5 2020, 5:40 AM · Restricted Project, Restricted Project

Jul 16 2020

kamaub accepted D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

LGTM

Jul 16 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project

Jul 9 2020

kamaub committed rGbd2068031121: [PowerPC] Split s34imm into two types (authored by stefanp).
[PowerPC] Split s34imm into two types
Jul 9 2020, 9:29 AM
kamaub closed D83255: [PowerPC] Split s34imm into two types.
Jul 9 2020, 9:29 AM · Restricted Project
kamaub committed rGbeb52b12cb17: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation (authored by stefanp).
[PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation
Jul 9 2020, 7:51 AM
kamaub closed D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation.
Jul 9 2020, 7:51 AM · Restricted Project

Jul 8 2020

kamaub added a project to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec: Restricted Project.
Jul 8 2020, 9:26 AM · Restricted Project, Restricted Project
Herald added a project to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec: Restricted Project.
Jul 8 2020, 9:20 AM · Restricted Project, Restricted Project
kamaub accepted D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.

LGTM

Jul 8 2020, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2020

kamaub accepted D83255: [PowerPC] Split s34imm into two types.

This is LGTM, one suggestion on the clang-format change that can be done pre-commit.

Jul 7 2020, 10:05 AM · Restricted Project
kamaub accepted D82584: [PowerPC][Power10] Exploit the High Order Vector Multiply Instructions on Power10.

This LGTM

Jul 7 2020, 8:51 AM · Restricted Project, Restricted Project
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.
  • rearranging conditional logic for emitting MCSymbolRefExpr::VK_PPC_TLS_PCREL so that it is less redundant and reads better.
  • replacing future with pwr10 in test cases and adding better comments.
Jul 7 2020, 6:10 AM · Restricted Project, Restricted Project

Jul 6 2020

kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
  • Renaming test functions names as per review comments.
Jul 6 2020, 8:59 AM · Restricted Project, Restricted Project
kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
  • Rebasing branch to more recent version of master.
  • Adding asserts to ensure values are always what they are expected to be.
  • Code formating and comments added.
  • Conditional logic for register operands rearranged to avoid potential bugs in PPCTLSDynamicCall.cpp.
Jul 6 2020, 8:46 AM · Restricted Project, Restricted Project

Jul 1 2020

kamaub committed rGb294e00fb079: [PowerPC] Fix for PC Relative call protocol (authored by stefanp).
[PowerPC] Fix for PC Relative call protocol
Jul 1 2020, 5:23 AM
kamaub closed D81126: [PowerPC] Fix for PC Relative call protocol.
Jul 1 2020, 5:23 AM · Restricted Project

Jun 26 2020

kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.
  • Rebasing patch to be dependant on D82315 - TLS Support for General Dynamic.
  • Adding Combination flag MO_GOT_TPREL_PCREL_FLAG to more explicitly define the king that will output @got@tprel@pcrel relocation.
  • Adding assembly reader test cases by request of reviewer for more robust testing.
  • Minor format changes.
Jun 26 2020, 10:22 AM · Restricted Project, Restricted Project

Jun 25 2020

kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Addressing clang format suggestion.

Jun 25 2020, 12:29 PM · Restricted Project, Restricted Project
kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Adding a combination flag to more explicitly set the bits needed to produce
General Dynamic TLS model relocations.

Jun 25 2020, 12:28 PM · Restricted Project, Restricted Project

Jun 24 2020

kamaub committed rG8131ef5d635b: [LLD][PowerPC] Add support for R_PPC64_GOT_PCREL34 (authored by stefanp).
[LLD][PowerPC] Add support for R_PPC64_GOT_PCREL34
Jun 24 2020, 5:55 AM
kamaub closed D81948: [LLD][PowerPC] Add support for R_PPC64_GOT_PCREL34.
Jun 24 2020, 5:54 AM · Restricted Project

Jun 23 2020

kamaub closed D81457: [LLD][PowerPC] Add support for R_PPC64_PCREL34.
Jun 23 2020, 1:59 PM · Restricted Project
kamaub committed rG3a55a2a97fd4: [LLD][PowerPC] Add support for R_PPC64_PCREL34 (authored by stefanp).
[LLD][PowerPC] Add support for R_PPC64_PCREL34
Jun 23 2020, 1:27 PM
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Addressing review comments.

Jun 23 2020, 11:15 AM · Restricted Project, Restricted Project
kamaub planned changes to D79747: Implementation of Simple Outliner Module Pass.
Jun 23 2020, 8:00 AM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Updating test case.

Jun 23 2020, 7:59 AM · Restricted Project
kamaub planned changes to D79747: Implementation of Simple Outliner Module Pass.

I think it would be great to add more details about the benefit of the outlining to the description. For the example in the test case, outlining seems quite heavy handed. Wouldn't it be simpler and faster in those cases to just duplicate the return block?

Jun 23 2020, 7:58 AM · Restricted Project

Jun 22 2020

kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Updating patch with author's credits.

Jun 22 2020, 10:12 AM · Restricted Project, Restricted Project
kamaub updated the summary of D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
Jun 22 2020, 10:12 AM · Restricted Project, Restricted Project
kamaub added a reviewer for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic: Restricted Project.
Jun 22 2020, 10:12 AM · Restricted Project, Restricted Project
kamaub created D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
Jun 22 2020, 10:12 AM · Restricted Project, Restricted Project

Jun 16 2020

kamaub added a reviewer for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec: Restricted Project.
Jun 16 2020, 9:54 AM · Restricted Project, Restricted Project
kamaub created D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.
Jun 16 2020, 9:54 AM · Restricted Project, Restricted Project

Jun 3 2020

kamaub retitled D79747: Implementation of Simple Outliner Module Pass from [PowerPC] Implementation of Simple Outliner Module Pass to Implementation of Simple Outliner Module Pass.
Jun 3 2020, 12:05 PM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Third attempt to address clang-format.

Jun 3 2020, 12:05 PM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Addressing clang-format suggestion.

Jun 3 2020, 12:05 PM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Address clang-format suggestions.

Jun 3 2020, 12:05 PM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Updating this patch to make it a target independent IPO module pass.

Jun 3 2020, 12:05 PM · Restricted Project

May 22 2020

kamaub committed rGa28e9f120860: [PowerPC] Add support for vmsumudm (authored by saghir).
[PowerPC] Add support for vmsumudm
May 22 2020, 12:53 PM
kamaub closed D80294: Add support for vmsumudm.
May 22 2020, 12:53 PM · Restricted Project, Restricted Project

May 15 2020

kamaub added a comment to D79747: Implementation of Simple Outliner Module Pass.

Addressed some review comments.

May 15 2020, 5:53 AM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

While using Arcanist I accidentally made the differential change BASE because the recorded HEAD commit hash on phabricator somehow became mixed-matched with my local HEAD that i use for this branch.
I am manually uploading the diff to correct this.

May 15 2020, 5:53 AM · Restricted Project

May 14 2020

kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Addressing review and clang-tidy comments

May 14 2020, 12:30 PM · Restricted Project
kamaub updated the diff for D79747: Implementation of Simple Outliner Module Pass.

Addressing review and clang-tidy comments

May 14 2020, 12:30 PM · Restricted Project
kamaub accepted D79736: [PowerPC][NFC] Cleanup load/store spilling code.

LGTM, one pre-commit nit with the indentation.

May 14 2020, 12:30 PM · Restricted Project, Restricted Project
kamaub added a comment to D79736: [PowerPC][NFC] Cleanup load/store spilling code.

I think the index for the StoreSpillOpcodesArray and LoadSpillOpcodesArray arrays are incorrect.

May 14 2020, 12:30 PM · Restricted Project, Restricted Project

May 13 2020

kamaub planned changes to D79747: Implementation of Simple Outliner Module Pass.

1: I like the idea about reducing csr cost in prologue/epilogue by outlining some function bodies. Any special reason for applying this pass only on PowerPC? I think many other platforms also can benefit from this pass.

I can definitely do this, I'll mark this patch as "changes planned" and then post the updated target independent version when it is completed.

2: Is there any plan to extend the light path definition. Currently in this pass a light path is a path from entry block directly to exit block. But I think light path can be more general. A simple example

//   ENTRY
//     |
//    BB1 
//    / \    
//   |  BB2    
//   |   | \     
//   |  ANY BLOCKS   
//   |  /                   
//   RET
//

A light path for this case can be ENTRY->BB1->RET and outline other blocks.

If we plan to extend light path definition, I think better to do a little change in the code framework. Eg: define a function like findLightPath() in tryOutlining instead of hard code the light path?

There are plans to improve this pass once that pass is completed and makes it into the compiler. Thank you for this guidance, I will keep it in mind.

3: After get the light path, I think it’s better to call interfaces in class CodeExtractor to do outlining like hotcoldsplitting pass and PartialInliner pass did.

I had not considered this , I will investigate this possibility as well.

May 13 2020, 10:50 AM · Restricted Project

May 12 2020

kamaub committed rGcd83333fc8fa: [PowerPC] Fold redundant load immediates of zero and delete if possible (authored by kamaub).
[PowerPC] Fold redundant load immediates of zero and delete if possible
May 12 2020, 11:18 AM
kamaub closed D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
May 12 2020, 11:17 AM · Restricted Project

May 11 2020

kamaub added a reviewer for D79747: Implementation of Simple Outliner Module Pass: Restricted Project.
May 11 2020, 3:07 PM · Restricted Project
kamaub created D79747: Implementation of Simple Outliner Module Pass.
May 11 2020, 2:35 PM · Restricted Project

May 4 2020

kamaub accepted D79015: [PowerPC] Fix missing GOT indirect variant kind.

This LGTM, one minor comment about test case explanation, it can be done pre-commit for sure.

May 4 2020, 11:48 AM · Restricted Project

Apr 22 2020

kamaub committed rGa60ca4b4e9b1: [PowerPC][Future] Initial support for PCRel addressing to get block address (authored by NeHuang).
[PowerPC][Future] Initial support for PCRel addressing to get block address
Apr 22 2020, 1:05 PM
kamaub closed D76294: [PowerPC][Future] Add initial support for PC Relative addressing to get block address .
Apr 22 2020, 1:05 PM · Restricted Project, Restricted Project
kamaub committed rG43abef06f42d: [PowerPC][Future] Initial support for PCRel addressing for jump tables. (authored by NeHuang).
[PowerPC][Future] Initial support for PCRel addressing for jump tables.
Apr 22 2020, 9:13 AM
kamaub closed D75931: [PowerPC][Future] Add initial support for PC Relative addressing to get jump table base address.
Apr 22 2020, 9:13 AM · Restricted Project

Apr 21 2020

kamaub committed rGa92ee77d8597: [PowerPC][Future] Add offsets to PC Relative relocations. (authored by stefanp).
[PowerPC][Future] Add offsets to PC Relative relocations.
Apr 21 2020, 9:11 AM
kamaub closed D76160: [PowerPC][Future] Add offsets to PC Relative relocations. .
Apr 21 2020, 9:10 AM · Restricted Project

Apr 17 2020

kamaub added a comment to D76064: [PowerPC][Future] Add initial support for PC Relative addressing for global values that require GOT indirect addressing.

Sorry I missed that git clang-format changed whitespace on unrelated lines.
Pulling out simply because of this seems like unnecessary churn for the bots
especially since the formatting is an improvement.
If someone would like me to pull it, I certainly don't mind.
I will definitely be more vigilant next time.

I commented on the commit b771c4a8, FYI

Apr 17 2020, 10:47 AM · Restricted Project
kamaub added a comment to rGb771c4a842d6: [PowerPC][Future] More support for PCRel addressing for global values.

Sorry I missed that git clang-format changed whitespace on unrelated lines.
Pulling out simply because of this seems like unnecessary churn for the bots
especially since the formatting is an improvement.
If someone would like me to pull it, I certainly don't mind.
I will definitely be more vigilant next time.

Apr 17 2020, 10:47 AM
kamaub committed rGb771c4a842d6: [PowerPC][Future] More support for PCRel addressing for global values (authored by stefanp).
[PowerPC][Future] More support for PCRel addressing for global values
Apr 17 2020, 9:11 AM
kamaub closed D76064: [PowerPC][Future] Add initial support for PC Relative addressing for global values that require GOT indirect addressing.
Apr 17 2020, 9:10 AM · Restricted Project

Apr 16 2020

kamaub committed rG18b605032412: [PowerPC][Future] Initial support for PC Relative addressing for global values (authored by stefanp).
[PowerPC][Future] Initial support for PC Relative addressing for global values
Apr 16 2020, 11:10 AM
kamaub closed D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Apr 16 2020, 11:09 AM · Restricted Project

Apr 9 2020

kamaub committed rG75828ef615da: [PowerPC][Future] Initial support for PCRel addressing for constant pool loads (authored by stefanp).
[PowerPC][Future] Initial support for PCRel addressing for constant pool loads
Apr 9 2020, 1:12 PM
kamaub closed D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.
Apr 9 2020, 1:12 PM · Restricted Project
kamaub added a comment to D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Looks like this breaks tests on Windows: http://45.33.8.238/win/12548/step_11.txt

Apr 9 2020, 11:16 AM · Restricted Project
kamaub added a reviewer for D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code: kamaub.
Apr 9 2020, 8:40 AM · Restricted Project
kamaub added inline comments to D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code.
Apr 9 2020, 8:40 AM · Restricted Project

Apr 8 2020

kamaub committed rG6c4b40def776: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC. (authored by stefanp).
[PowerPC][Future] Add Support For Functions That Do Not Use A TOC.
Apr 8 2020, 6:29 AM
kamaub closed D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Apr 8 2020, 6:29 AM · Restricted Project, Restricted Project

Apr 6 2020

kamaub committed rG9ed0612ccaf0: Add InjectTLIMappings pass to new pass manager (authored by masoud.ataei).
Add InjectTLIMappings pass to new pass manager
Apr 6 2020, 11:27 AM
kamaub closed D75354: Add InjectTLIMappings pass to new pass manager.
Apr 6 2020, 11:27 AM · Restricted Project

Mar 19 2020

kamaub committed rGaccf06feb1d1: Test commit. (authored by kamaub).
Test commit.
Mar 19 2020, 7:00 AM

Mar 2 2020

kamaub added a comment to rGf82ae3ad8f1b: Disable instrprof-merging.cpp to unblock bots while I investigate.

Sorry to report but this is causing failures as well.
http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1695
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/35741

Testing Time: 760.34s
********************
Unresolved Tests (1):
    Profile-powerpc64le :: instrprof-merging.cpp
Mar 2 2020, 10:41 AM

Jan 30 2020

kamaub added a comment to D70930: [llvm-objcopy][WebAssembly] Initial support for wasm in llvm-objcopy.

I won't have time to look at it today; i'll just revert and take a look tomorrow.

Jan 30 2020, 6:40 AM · Restricted Project

Jan 29 2020

kamaub added a comment to D70930: [llvm-objcopy][WebAssembly] Initial support for wasm in llvm-objcopy.

@dschuff please note this patch causes build failures for PowerPC big endian buildbots with commit rGa928d127a52a
If the solution isn't a simple fix please revert the commit so we may continue testing the rest of the repository

Jan 29 2020, 7:21 AM · Restricted Project

Jan 22 2020

kamaub added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

@kamaub The build failures you see should have been fixed by the followup commit r6ccebe004446.

EDIT: On inspection, (for example) http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/43185 shows that you're now seeing a different error that appears unrelated?

Jan 22 2020, 4:25 AM · Restricted Project

Jan 21 2020

kamaub added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

@epastor The lastest commit for this patch: r5f6dfa800e0b causes build failures on:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23101
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/43182
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/34405

Jan 21 2020, 1:19 PM · Restricted Project

Jan 15 2020

kamaub added a comment to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

This patch looks ready to land (once the other comments are addressed), I only have two of NFC request that can be done pre-commit for readability.

Jan 15 2020, 2:06 PM · Restricted Project, Restricted Project