[analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

[Szelethus]

Summary

The comment in Checkers.td explains whats going on. As StreamChecker grows, expect a need to have smaller checkers out of it, but let that be a worry for later.

[balazske]

LGTM
But a better approach can be to make a new kind of dependency. (Or split the StreamChecker.)

[Szelethus]

In D78120#1983756, @balazske wrote:

LGTM
But a better approach can be to make a new kind of dependency. (Or split the StreamChecker.)

Definitely the latter, I just didn't wanna mess with your project :) But I'd be happy to assist in splitting it up eventually!

[Szelethus]

In D78120#2034455, @Szelethus wrote:

In D78120#1983756, @balazske wrote:

LGTM
But a better approach can be to make a new kind of dependency. (Or split the StreamChecker.)

Definitely the latter, I just didn't wanna mess with your project :) But I'd be happy to assist in splitting it up eventually!

Just to clarify, I don't mean to push the implementation of the correct solution to somebody else, but StreamChecker is a moving target and splitting checkers up, as this project demonstrates, is about a few lines worth of work.

clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

 def AnalyzerStatsChecker : Checker<"Stats">,
   HelpText<"Emit warnings with analyzer statistics">,
   Documentation<NotDocumented>;
 
 def TaintTesterChecker : Checker<"TaintTest">,
   HelpText<"Mark tainted symbols as such.">,
   Documentation<NotDocumented>;
 
+// This checker *technically* depends on SteamChecker, but we don't allow
+// dependency checkers to emit diagnostics, and a debug checker isn't worth
+// the chore needed to create a modeling portion on its own. Since this checker
+// is for development purposes only anyways, make sure that StreamChecker is
+// also enabled, at least for the time being.
 def StreamTesterChecker : Checker<"StreamTester">,
-  HelpText<"Add test functions to StreamChecker for test and debugging purposes.">,
-  Dependencies<[StreamChecker]>,
+  HelpText<"Add test functions to StreamChecker for test and debugging "
+           "purposes.">,
   Documentation<NotDocumented>;
 
 def ExprInspectionChecker : Checker<"ExprInspection">,
   HelpText<"Check the analyzer's understanding of expressions">,
   Documentation<NotDocumented>;
 
 def ExplodedGraphViewer : Checker<"ViewExplodedGraph">,
   HelpText<"View Exploded Graphs using GraphViz">,

clang/test/Analysis/stream-error.c

-// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-checker=debug.StreamTester,debug.ExprInspection -analyzer-store region -verify %s
+// RUN: %clang_analyze_cc1 -verify %s \
+// RUN: -analyzer-checker=core \
+// RUN: -analyzer-checker=alpha.unix.Stream \
+// RUN: -analyzer-checker=debug.StreamTester \
+// RUN: -analyzer-checker=debug.ExprInspection
 
 #include "Inputs/system-header-simulator.h"
 
 void clang_analyzer_eval(int);
 void StreamTesterChecker_make_feof_stream(FILE *);
 void StreamTesterChecker_make_ferror_stream(FILE *);
 
 void error_fopen() {