This is an archive of the discontinued LLVM Phabricator instance.

[ARM] add ARMv8.6-A Activity monitors virtualization extension
ClosedPublic

Authored by stuij on Mar 28 2020, 3:52 PM.

Details

Summary

This patch upstreams v8.6A activity monitors virtualization
assembler support, which consists of 32 new system
registers (two groups, each with 16 numbered registers).

See ARMv8.6-AMU in the Arm Architecture Reference Manual Armv8 for more
information.

Diff Detail

Event Timeline

stuij created this revision.Mar 28 2020, 3:52 PM
SjoerdMeijer added inline comments.Mar 30 2020, 3:52 AM
llvm/test/MC/AArch64/armv8.6a-amvs-error.s
1 ↗(On Diff #253383)

I am unfamiliar with this: %p/armv8.6a-amvs.s , what is this doing?

ostannard added inline comments.
llvm/test/MC/AArch64/armv8.6a-amvs-error.s
1 ↗(On Diff #253383)

%p expands to the test source directory, so this test is using the code from an adjacent file, with the filecheck lines from this file. I think it would be better (more obvious, idiomatic) to merge the two files together using different check prefixes for the positive and negative cases.

SjoerdMeijer added inline comments.Mar 30 2020, 6:00 AM
llvm/test/MC/AArch64/armv8.6a-amvs-error.s
1 ↗(On Diff #253383)

cheers, and +1 to that

stuij updated this revision to Diff 253731.Mar 30 2020, 3:58 PM

As per review suggestion, merging tests from armv8.6a-amvs-error.s with armv8.6a-amvs.s.

ostannard added inline comments.Mar 31 2020, 2:00 AM
llvm/test/MC/AArch64/armv8.6a-amvs.s
66

Run lines should all be grouped at the top of the file.

stuij updated this revision to Diff 253894.Mar 31 2020, 8:22 AM

rearranging lit test run lines as commented on by reviewer

This revision is now accepted and ready to land.Mar 31 2020, 9:06 AM
This revision was automatically updated to reflect the committed changes.