Differential D74977

[WIP][RISCV][GlobalISel] Add lowerFormalArguments for calling convention
Needs ReviewPublic
Actions

Authored by lewis-revill on Feb 21 2020, 11:34 AM.

Details

Reviewers

asb
weiwei
luismarques
simoncook
apazos
shiva0217
Joe
lenary

Summary

This patch adds an IncomingValueHandler and implements minimal support for lowering formal arguments according to the RISC-V calling convention. Simple non-aggregate integer and pointer types are supported. Lowering according to fastcc calling convention is not yet supported.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	120 ms	LLVM.Transforms/LoopStrengthReduce::Unknown Unit Message ("") Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/llc -debug-only=loop-reduce < /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/Transforms/LoopStrengthReduce/phi-unknownscev.ll 2>&1 \| /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/Transforms/LoopStrengthReduce/phi-unknownscev.ll

Event Timeline

lewis-revill created this revision.Feb 21 2020, 11:34 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2020, 11:34 AM

Herald added subscribers: llvm-commits, evandro, sameer.abuasal and 23 others. · View Herald Transcript

lewis-revill added a parent revision: D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..Feb 21 2020, 11:35 AM

lewis-revill updated this revision to Diff 246068.Feb 22 2020, 2:51 AM

lewis-revill updated this revision to Diff 246115.Feb 23 2020, 11:07 AM

lewis-revill added a child revision: D75023: [WIP][RISCV][GlobalISel] Add lowerCall for calling convention.Feb 23 2020, 11:11 AM

Rebase, update test structure.

Harbormaster failed remote builds in B48201: Diff 248480!Mar 5 2020, 8:45 AM

lewis-revill edited parent revisions, added: D75683: [NFC][RISCV][GlobalISel] Move test file into irtranslator subdirectory; removed: D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..Mar 18 2020, 10:02 AM

lewis-revill added a reviewer: Joe.Mar 18 2020, 10:07 AM

Joe added inline comments.Mar 20 2020, 7:52 AM

llvm/lib/Target/RISCV/RISCVCallLowering.cpp
171	Perhaps add a test for this?
173	Floats don't work here. HandleAssignments tries to truncate it. Best to leave it unsupported for now.

Address comments relating to supported types.

Harbormaster failed remote builds in B50945: Diff 253565!Mar 30 2020, 6:27 AM

lewis-revill updated this revision to Diff 254140.Apr 1 2020, 3:06 AM

Harbormaster failed remote builds in B51268: Diff 254140!Apr 1 2020, 3:51 AM

lenary resigned from this revision.Jan 14 2021, 10:10 AM

Herald added subscribers: frasercrmck, NickHung. · View Herald TranscriptJan 14 2021, 10:10 AM

rkruppe removed a subscriber: rkruppe.Jan 14 2021, 10:20 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

RISCV/

RISCVCallLowering.cpp

97 lines

test/

CodeGen/

RISCV/

GlobalISel/

irtranslator/

235 lines

Diff 254140

llvm/lib/Target/RISCV/RISCVCallLowering.cpp

Loading...

llvm/test/CodeGen/RISCV/GlobalISel/irtranslator/args.ll

Loading...