This is an archive of the discontinued LLVM Phabricator instance.

Reland "[Support] make report_fatal_error `abort` instead of `exit`"
ClosedPublic

Authored by ychen on Feb 11 2020, 5:37 PM.

Details

Summary

Reland D67847 after D73742 is committed. Replace sys::Process::Exit(1)
with abort in report_fatal_error.

After this patch, for tools turning on CrashRecoveryContext,
crash handler installed by CrashRecoveryContext is called unless
they installed a non-returning handler using llvm::install_fatal_error_handler
like cc1_main currently does.

Diff Detail

Event Timeline

ychen created this revision.Feb 11 2020, 5:37 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Feb 11 2020, 5:57 PM
This revision is now accepted and ready to land.Feb 11 2020, 5:57 PM

ninja check-llvm check-clang passed on a powerpc64le machine.

ychen added a comment.Feb 11 2020, 6:23 PM

ninja check-llvm check-clang passed on a powerpc64le machine.

Thanks for the review. Fingers crossed sanitizer bots not complain.

This revision was automatically updated to reflect the committed changes.
llvm/test/Object/invalid.test