Page MenuHomePhabricator

[mlir][spirv] Create builtin variable in nearest symbol table
ClosedPublic

Authored by antiagainst on Jan 25 2020, 7:13 AM.

Details

Summary

This commit changes the logic of getBuiltinVariableValue to get
or create the builtin variable in the nearest symbol table. This
will allow us to use this function in other partial conversion
cases where we haven't created the spv.module yet.

Diff Detail

Event Timeline

antiagainst created this revision.Jan 25 2020, 7:13 AM

Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

benvanik accepted this revision.Jan 25 2020, 3:51 PM
This revision is now accepted and ready to land.Jan 25 2020, 3:51 PM
rriddle added inline comments.Jan 26 2020, 2:33 AM
mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
281

SymbolTable.cpp defines a static method for this(getNearestSymbolTable) that we could likely expose.

This revision was automatically updated to reflect the committed changes.
antiagainst marked an inline comment as done.
antiagainst marked an inline comment as done.Jan 26 2020, 8:05 AM
antiagainst added inline comments.
mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp
281