Page MenuHomePhabricator

lucyrfox (Lucy Fox)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 7:44 AM (48 w, 8 h)

Recent Activity

Jun 16 2020

lucyrfox committed rG7b226fde6781: [MLIR] Add an Op util which returns its name with the dialect stripped. (authored by lucyrfox).
[MLIR] Add an Op util which returns its name with the dialect stripped.
Jun 16 2020, 5:02 PM
lucyrfox closed D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..
Jun 16 2020, 5:01 PM · Restricted Project
lucyrfox added a comment to D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..

Are there use cases in-tree that could be updated?

Jun 16 2020, 3:28 PM · Restricted Project
lucyrfox updated the diff for D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..

Add one usage of getting dialect directly.

Jun 16 2020, 3:24 PM · Restricted Project

Jun 8 2020

lucyrfox updated the diff for D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..

Added a check for the case where there is no dialect prefix.

Jun 8 2020, 5:44 PM · Restricted Project
lucyrfox edited reviewers for D81435: [MLIR] Add an Op util which returns its name with the dialect stripped., added: jpienaar; removed: rriddle.
Jun 8 2020, 4:06 PM · Restricted Project
lucyrfox created D81435: [MLIR] Add an Op util which returns its name with the dialect stripped..
Jun 8 2020, 3:34 PM · Restricted Project

Apr 30 2020

lucyrfox committed rG8de482ea9aa6: [MLIR] Modify Partial op conversion mode to optionally track all non… (authored by lucyrfox).
[MLIR] Modify Partial op conversion mode to optionally track all non…
Apr 30 2020, 10:09 AM
lucyrfox closed D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..
Apr 30 2020, 10:09 AM · Restricted Project
lucyrfox updated the diff for D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..

Small formatting fix.

Apr 30 2020, 10:08 AM · Restricted Project
lucyrfox retitled D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations. from [MLIR] Modify Analysis op conversion mode to emit errors for all unlegalizable operations. to [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..
Apr 30 2020, 9:02 AM · Restricted Project

Apr 29 2020

lucyrfox added inline comments to D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..
Apr 29 2020, 9:37 PM · Restricted Project
lucyrfox updated the diff for D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..

Modify Partial conversion mode (instead of Analysis mode) to take an optional parameter to store non-legalizable ops.

Apr 29 2020, 9:37 PM · Restricted Project

Apr 28 2020

lucyrfox added a comment to D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..

[Note: I haven't made code changes in this iteration because I want to settle on an approach before refactoring this. For the same reason I'm leaving some comments unresolved for now.]

Apr 28 2020, 4:45 PM · Restricted Project

Apr 24 2020

lucyrfox updated the diff for D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..

Minor formatting change.

Apr 24 2020, 10:48 AM · Restricted Project

Apr 23 2020

lucyrfox added reviewers for D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations.: rriddle, mehdi_amini.

Took a first pass at this, but I'm open to different ways of approaching this change. At I've written it now, the basic idea of the Analysis conversion is "we're performing a partial conversion and emitting warnings along the way for any ops that would fail to legalize in a full conversion". Success is returned as long as the partial conversion succeeds. I did it this way because returning failure outright means that the partially converted IR doesn't get emitted, which is useful for debugging.

Apr 23 2020, 10:14 PM · Restricted Project
lucyrfox created D78788: [MLIR] Modify Partial op conversion mode to optionally track all non-legalizable operations..
Apr 23 2020, 9:42 PM · Restricted Project

Apr 17 2020

lucyrfox committed rGa0d5e5496621: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 8:24 PM
lucyrfox committed rGa6b427167e05: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 8:24 PM
lucyrfox committed rG495cf2729188: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 8:24 PM
lucyrfox closed D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..
Apr 17 2020, 8:24 PM · Restricted Project
lucyrfox added a comment to D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..

Sorry about that - am working with an unfamiliar workflow that led me to a strange place... just deleted the branch but let me know if there's still any issue.

Apr 17 2020, 8:24 PM · Restricted Project
lucyrfox committed rG46294ffd1c08: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 6:04 PM
lucyrfox committed rG9cad0d090d33: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 6:04 PM
lucyrfox committed rG01d781489e71: [MLIR] Update tutorial to add missing tests and bring directory paths and code… (authored by lucyrfox).
[MLIR] Update tutorial to add missing tests and bring directory paths and code…
Apr 17 2020, 6:04 PM
lucyrfox added a comment to D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..

Fix typo in run commands in tests.

Apr 17 2020, 6:03 PM · Restricted Project
lucyrfox updated the diff for D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..
Apr 17 2020, 6:03 PM · Restricted Project

Apr 1 2020

lucyrfox updated the diff for D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..

Add -opt flag to added tests in Ch3-7.

Apr 1 2020, 2:13 PM · Restricted Project

Mar 25 2020

lucyrfox added a reviewer for D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date.: rriddle.
Mar 25 2020, 4:16 PM · Restricted Project
lucyrfox created D76809: [MLIR] Update tutorial to add missing tests and bring directory paths and code snippets up to date..
Mar 25 2020, 4:16 PM · Restricted Project

Feb 25 2020

lucyrfox accepted D75133: [mlir][DenseElementsAttr] Fix storage size for bfloat16 when parsing from hex..

LGTM, thanks for the quick fix, River!

Feb 25 2020, 12:22 PM · Restricted Project

Feb 19 2020

lucyrfox updated subscribers of D73819: [mlir] Add $_op hook to RewriterGen..
Feb 19 2020, 11:18 AM · Restricted Project

Feb 6 2020

lucyrfox accepted D74181: [mlir][AsmPrinter] Fix edge case when printing floating point values..
Feb 6 2020, 5:09 PM · Restricted Project

Feb 4 2020

lucyrfox abandoned D73819: [mlir] Add $_op hook to RewriterGen..
Feb 4 2020, 11:35 AM · Restricted Project

Feb 3 2020

lucyrfox updated the summary of D73819: [mlir] Add $_op hook to RewriterGen..
Feb 3 2020, 2:28 PM · Restricted Project
lucyrfox updated the diff for D73819: [mlir] Add $_op hook to RewriterGen..

Added tests.

Feb 3 2020, 2:28 PM · Restricted Project

Jan 31 2020

lucyrfox abandoned D73818: Add $_op hook to RewriterGen..
Jan 31 2020, 4:34 PM · Restricted Project
lucyrfox abandoned D73806: Add $_op hook to RewriterGen..
Jan 31 2020, 4:26 PM · Restricted Project
lucyrfox added a reviewer for D73819: [mlir] Add $_op hook to RewriterGen.: rriddle.
Jan 31 2020, 4:25 PM · Restricted Project
lucyrfox created D73819: [mlir] Add $_op hook to RewriterGen..
Jan 31 2020, 4:25 PM · Restricted Project
lucyrfox created D73818: Add $_op hook to RewriterGen..
Jan 31 2020, 4:25 PM · Restricted Project
lucyrfox created D73806: Add $_op hook to RewriterGen..
Jan 31 2020, 2:27 PM · Restricted Project

Jan 15 2020

lucyrfox accepted D72697: [mlir] fix broken link to Glossary.
Jan 15 2020, 9:35 AM · Restricted Project

Jan 14 2020

lucyrfox added a comment to D72697: [mlir] fix broken link to Glossary.

Thanks for making this fix. +1 on using relative links. While you're here, you could also make the link to the glossary in the LangRef relative.

Jan 14 2020, 1:59 PM · Restricted Project