This is an archive of the discontinued LLVM Phabricator instance.

[X86][Sched] A bunch of fixes to the Zen2 sched model latencies.
ClosedPublic

Authored by courbet on Jan 22 2020, 4:00 AM.

Details

Summary

As determined with llvm-exegesis.

Some of these look like typos/misunderstandings of the sched model td
spec:

  • latency defaults to 1 when not set => Maybe we can avoid having a default ?
  • problems with regexps not being anchored by default (XCHG matching CMPXHG)

Note that this is not complete, it fixes only the most obvious mistakes,
and only for latency (not uops).

Event Timeline

courbet created this revision.Jan 22 2020, 4:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 4:00 AM
courbet updated this revision to Diff 239538.Jan 22 2020, 4:05 AM

update mca tests

Harbormaster completed remote builds in B44567: Diff 239538.

There seems to be a load of whitespace changes (maybe copy+paste issues in D66088?) - please could you regenerate against trunk, commit those NFC changes and then rebase?

courbet updated this revision to Diff 239556.Jan 22 2020, 5:56 AM

Rebase on fixed tests.

There seems to be a load of whitespace changes (maybe copy+paste issues in D66088?) - please could you regenerate against trunk, commit those NFC changes and then rebase?

Sure, done.

Changes done are obvious. Are you using libpfm with znver2 for verifying these?

Changes done are obvious. Are you using libpfm with znver2 for verifying these?

Yes, I'm using llvm-exegesis:

llvm-exegesis -mode=latency -opcode-index=-1 -dump-object-to-disk=0 > /tmp/zen2-latency
llvm-exegesis -mode=analysis -analysis-inconsistencies-output-file=/tmp/zen2-latency.html  -benchmarks-file=/tmp/zen2-latency

@GGanesh does this look reasonable to you ?

Yes looks good to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 30 2020, 1:21 AM
This revision was automatically updated to reflect the committed changes.

Backport to 10 branch?

courbet added a comment.EditedFeb 3 2020, 6:30 AM

Backport to 10 branch?

No strong opinion: I don't know if there ave a lot of users of llvm-exegesis that are not using LLVM at head.