Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (245 w, 1 d)

Recent Activity

Tue, Dec 1

courbet committed rG735e6c888ec8: [MergeICmps] Fix missing split. (authored by courbet).
[MergeICmps] Fix missing split.
Tue, Dec 1, 7:51 AM
courbet closed D92375: [MergeICmps] Fix missing split..
Tue, Dec 1, 7:51 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Improve commit message.

Tue, Dec 1, 7:43 AM · Restricted Project
courbet added a comment to D92375: [MergeICmps] Fix missing split..

Thanks for the comments.

Tue, Dec 1, 6:50 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

...and add a side-effecting instruction at the top.

Tue, Dec 1, 6:49 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Make the test more robust to future optimizations as suggested by James.

Tue, Dec 1, 6:43 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Simplify the test as suggested by James.

Tue, Dec 1, 6:40 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Update comment.

Tue, Dec 1, 6:23 AM · Restricted Project
courbet added a comment to D92364: [MergeICmps] Disable if a GEP does not reference an Argument.

Thanks for the repro. I think a better fix is D92375 (missing split).

Tue, Dec 1, 2:33 AM · Restricted Project
courbet requested review of D92375: [MergeICmps] Fix missing split..
Tue, Dec 1, 2:32 AM · Restricted Project

Thu, Nov 26

courbet added a comment to D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.

Thanks, comments addressed.

Thu, Nov 26, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
courbet updated the diff for D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.

Add to release notes.

Thu, Nov 26, 7:17 AM · Restricted Project, Restricted Project, Restricted Project
courbet requested review of D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.
Thu, Nov 26, 6:48 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 19

courbet added a comment to D91833: [SelectionDAG] Avoid aliasing analysis if the object size is unknown..

Thanks, could you please add a unit test for this ?

Thu, Nov 19, 10:54 PM · Restricted Project

Tue, Nov 17

courbet added a comment to D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.

LGTM for llvm-exegesis

Tue, Nov 17, 6:06 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

courbet added a comment to D90592: [llvm-exegesis] Save target state before running the benchmark..

This was eventually landed as rG8383fddc4fa9b4e61954e5ac93b00719a39d2291

Thu, Nov 12, 7:25 AM · Restricted Project

Wed, Nov 11

courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

hi @courbet,
our internal buildbots at Azul has failed because of an older assembler. We’ve taken in all commits/reverts/relands w.r.t this change upto Nov 4th.

The specific failure is:
/tmp/cc2lBtEi.s: Assembler messages:
/tmp/cc2lBtEi.s:541: Error: no such instruction: `fxsave64 16(%rax)'
/tmp/cc2lBtEi.s:566: Error: no such instruction: `fxrstor64 16(%rdi)'
/tmp/cc2lBtEi.s:592: Error: no such instruction: `fxrstor64 16(%rdi)'
make[2]: *** [tools/llvm-exegesis/lib/X86/CMakeFiles/LLVMExegesisX86.dir/Target.cpp.o] Error 1

Any suggestions to fix this apart from an upgrade (which seems to be a very invasive change on our machines)?

Wed, Nov 11, 11:15 PM · Restricted Project

Wed, Nov 4

courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

Looks like this doesn't build on windows: http://45.33.8.238/win/27220/step_4.txt

Thanks, I missed this bot. I'll send a fix.

Wed, Nov 4, 4:24 AM · Restricted Project
courbet committed rG9287eb352e6c: [llvm-exegesis] Fix rGaf658d920e2b (authored by courbet).
[llvm-exegesis] Fix rGaf658d920e2b
Wed, Nov 4, 4:24 AM
courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

Looks like this doesn't build on windows: http://45.33.8.238/win/27220/step_4.txt

Wed, Nov 4, 4:20 AM · Restricted Project

Nov 4 2020

courbet requested review of D90744: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes..
Nov 4 2020, 1:47 AM · Restricted Project
courbet committed rGaf658d920e2b: [llvm-exegesis][X86] Save and restore eflags. (authored by courbet).
[llvm-exegesis][X86] Save and restore eflags.
Nov 4 2020, 1:44 AM
courbet closed D90742: [llvm-exegesis][X86] Save and restore eflags..
Nov 4 2020, 1:44 AM · Restricted Project
courbet requested review of D90742: [llvm-exegesis][X86] Save and restore eflags..
Nov 4 2020, 1:17 AM · Restricted Project
courbet committed rG045c3692099a: [llvm-exegesis] Fix unused variable warning. (authored by courbet).
[llvm-exegesis] Fix unused variable warning.
Nov 4 2020, 1:10 AM
courbet added a reverting change for rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark.: rG8383fddc4fa9: Re-land "[llvm-exegesis] Save target state before running the benchmark.".
Nov 4 2020, 12:47 AM
courbet committed rG8383fddc4fa9: Re-land "[llvm-exegesis] Save target state before running the benchmark." (authored by courbet).
Re-land "[llvm-exegesis] Save target state before running the benchmark."
Nov 4 2020, 12:47 AM

Nov 3 2020

courbet added a reverting change for rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark.: rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark..
Nov 3 2020, 11:49 PM
courbet committed rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark.
Nov 3 2020, 11:49 PM
courbet added a reverting change for rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.": rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark..
Nov 3 2020, 11:35 PM
courbet committed rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
Re-land "[llvm-exegesis] Save target state before running the benchmark.
Nov 3 2020, 11:35 PM

Nov 2 2020

courbet added a reverting change for rG274de447fe96: [llvm-exegesis] Save target state before running the benchmark.: rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.".
Nov 2 2020, 6:12 AM
courbet committed rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark." (authored by courbet).
Revert "[llvm-exegesis] Save target state before running the benchmark."
Nov 2 2020, 6:12 AM
courbet added a reverting change for D90592: [llvm-exegesis] Save target state before running the benchmark.: rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.".
Nov 2 2020, 6:12 AM · Restricted Project
courbet committed rG274de447fe96: [llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
[llvm-exegesis] Save target state before running the benchmark.
Nov 2 2020, 6:03 AM
courbet closed D90592: [llvm-exegesis] Save target state before running the benchmark..
Nov 2 2020, 6:03 AM · Restricted Project
courbet updated the diff for D90592: [llvm-exegesis] Save target state before running the benchmark..

Address review comments

Nov 2 2020, 4:40 AM · Restricted Project
courbet added a comment to D90592: [llvm-exegesis] Save target state before running the benchmark..

Thanks, PTAL.

Nov 2 2020, 4:39 AM · Restricted Project
courbet requested review of D90592: [llvm-exegesis] Save target state before running the benchmark..
Nov 2 2020, 1:59 AM · Restricted Project
courbet committed rG7706c3022ead: [llvm-exegesis] Print signal name when the snippet crashed. (authored by courbet).
[llvm-exegesis] Print signal name when the snippet crashed.
Nov 2 2020, 1:42 AM
courbet closed D90453: [llvm-exegesis] Print signal name when the snippet crashed..
Nov 2 2020, 1:42 AM · Restricted Project

Oct 30 2020

courbet requested review of D90453: [llvm-exegesis] Print signal name when the snippet crashed..
Oct 30 2020, 4:02 AM · Restricted Project

Oct 29 2020

courbet committed rG24bf8faabd62: [llvm-exegesis] Do not try to assign random registers twice. (authored by courbet).
[llvm-exegesis] Do not try to assign random registers twice.
Oct 29 2020, 5:28 AM
courbet closed D90380: [llvm-exegesis] Do not try to assign random registers twice..
Oct 29 2020, 5:27 AM · Restricted Project
courbet requested review of D90380: [llvm-exegesis] Do not try to assign random registers twice..
Oct 29 2020, 3:56 AM · Restricted Project

Oct 28 2020

courbet committed rGa098f32a1fc8: [llvm-exegesis][doc] Remove old FIXME. (authored by courbet).
[llvm-exegesis][doc] Remove old FIXME.
Oct 28 2020, 2:53 AM
courbet committed rG7e2ffe7a6358: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats. (authored by courbet).
[llvm-exegesis] Do not silently fail on unknown instruction encoding formats.
Oct 28 2020, 2:07 AM
courbet closed D90289: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats..
Oct 28 2020, 2:07 AM · Restricted Project
courbet requested review of D90289: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats..
Oct 28 2020, 1:30 AM · Restricted Project
courbet committed rG992da89450d6: [llvm-exegesis] Update doc. (authored by courbet).
[llvm-exegesis] Update doc.
Oct 28 2020, 12:44 AM

Sep 25 2020

courbet requested review of D88304: [llvm-exegesis][NFC] Let `ExegesisTarget::randomizeTargetMCOperand`.
Sep 25 2020, 7:34 AM · Restricted Project

Sep 22 2020

courbet added a comment to D88044: [llvm-exegesis][PowerPC] Add more register classes.

This looks good for the llvm-exegesis part. I'm not familiar enough with the PowerPC target to review the rest.

Sep 22 2020, 11:24 PM · Restricted Project

Sep 11 2020

courbet added inline comments to D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 11 2020, 12:19 AM · Restricted Project
courbet accepted D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 11 2020, 12:18 AM · Restricted Project

Sep 9 2020

courbet added inline comments to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Sep 9 2020, 7:01 AM · Restricted Project
courbet accepted D87373: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Sep 9 2020, 6:54 AM · Restricted Project
courbet added inline comments to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Sep 9 2020, 6:51 AM · Restricted Project

Aug 17 2020

courbet added inline comments to D85868: DAG: Don't pass 0 alignment value to allowsMisalignedMemoryAccesses.
Aug 17 2020, 11:58 PM · Restricted Project

Jul 17 2020

courbet committed rG6bddd099ac14: Revert "[llvm-exegesis] Add benchmark latency option on X86 that uses LBR for… (authored by courbet).
Revert "[llvm-exegesis] Add benchmark latency option on X86 that uses LBR for…
Jul 17 2020, 7:55 AM
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

If you're not using llvm-exegesis you can disable this with the LLVM_ENABLE_LIBPFM cmake option.
But I'll revert this until @oontvoo can fix llvm/cmake/modules/FindLibpfm.cmake

Jul 17 2020, 7:49 AM · Restricted Project

Jul 10 2020

courbet added a comment to D83547: [builtins] Optimize the 128-bit division according to "Improved division by invariant integers" paper.

I have no idea what the policy is WRT size for compiler-rt. How big is the diff if you take code size into consideration ?

Jul 10 2020, 5:43 AM · Restricted Project
courbet committed rG68c011aa085a: [builtins] Optimize udivmodti4 for many platforms. (authored by danlark).
[builtins] Optimize udivmodti4 for many platforms.
Jul 10 2020, 1:04 AM
courbet closed D81809: [builtins] Optimize udivmodti4 for many platforms..
Jul 10 2020, 1:03 AM · Restricted Project
courbet accepted D81809: [builtins] Optimize udivmodti4 for many platforms..
Jul 10 2020, 12:45 AM · Restricted Project
courbet added a comment to D81809: [builtins] Optimize udivmodti4 for many platforms..

Sorry for taking that long, this is a dense review. Overall this looks good, and the renaming and splitting actually also improve the readability of the non-x86 part.
I only have style comments.

Jul 10 2020, 12:36 AM · Restricted Project

Jul 9 2020

courbet accepted D83533: [Alignment][NFC] Update Bitcodewriter to use Align.
Jul 9 2020, 11:47 PM · Restricted Project

Jul 8 2020

courbet accepted D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jul 8 2020, 10:59 PM · Restricted Project
courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jul 8 2020, 1:07 AM · Restricted Project

Jul 7 2020

courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Only style comments left

Jul 7 2020, 8:18 AM · Restricted Project
courbet accepted D83202: [Bitfields][NFC] Make sure bitfields are contiguous.
Jul 7 2020, 4:14 AM · Restricted Project
courbet accepted D83027: Add benchmarks for 128 bit division and create a directory for all builtins benchmarks.
Jul 7 2020, 2:41 AM
courbet added a comment to D83192: Fix off by one error in Bitfields.

Can you add a unit test for this ?

I'll add the following test as a separate commit if it LGTY.
Note: I can't use EXPECT_EQ because it takes the arguments by const & and the properties are static constexpr, the compiler complains about undefined reference.

TEST(BitfieldsTest, Properties) {
  using A = Bitfield::Element<bool, 0, 1>;
  EXPECT_TRUE(A::FirstBit == 0U);
  EXPECT_TRUE(A::LastBit == 0U);
  EXPECT_TRUE(A::Shift == 0U);
  EXPECT_TRUE(A::Bits == 1U);

  using B = Bitfield::Element<unsigned, 3, 4>;
  EXPECT_TRUE(B::FirstBit == 3U);
  EXPECT_TRUE(B::LastBit == 6U);
  EXPECT_TRUE(B::Shift == 3U);
  EXPECT_TRUE(B::Bits == 4U);
}
Jul 7 2020, 12:36 AM · Restricted Project

Jul 6 2020

courbet added inline comments to D83202: [Bitfields][NFC] Make sure bitfields are contiguous.
Jul 6 2020, 11:26 PM · Restricted Project
courbet added a comment to D83192: Fix off by one error in Bitfields.

Can you add a unit test for this ?

Jul 6 2020, 11:10 PM · Restricted Project

Jul 3 2020

courbet accepted D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.

Cool ! Only minor comments.

Jul 3 2020, 1:35 AM · Restricted Project
courbet accepted D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.
Jul 3 2020, 1:03 AM · Restricted Project

Jul 2 2020

courbet accepted D82981: [Alignment][NFC] VectorLayout now uses Align internally.
Jul 2 2020, 4:15 AM · Restricted Project
courbet added inline comments to D83027: Add benchmarks for 128 bit division and create a directory for all builtins benchmarks.
Jul 2 2020, 3:10 AM
courbet accepted D82977: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment.
Jul 2 2020, 3:10 AM · Restricted Project

Jul 1 2020

courbet accepted D82962: [Alignment][NFC] Use Align for BPFAbstractMemberAccess::RecordAlignment.
Jul 1 2020, 8:05 AM · Restricted Project
courbet accepted D82958: [Alignment] TargetLowering::hasPairedLoad must use Align for RequiredAlignment.
Jul 1 2020, 7:32 AM · Restricted Project
courbet accepted D82956: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment.
Jul 1 2020, 7:00 AM · Restricted Project
courbet accepted D82939: [Alignment][NFC] Migrate TargetTransformInfo::CreateVariableSizedObject to Align.
Jul 1 2020, 4:17 AM · Restricted Project
courbet accepted D82934: [Alignment][NFC] Migrate MachineFrameInfo::CreateSpillStackObject to Align.
Jul 1 2020, 1:02 AM · Restricted Project

Jun 30 2020

courbet accepted D82894: [Alignment][NFC] Migrate MachineFrameInfo::CreateStackObject to Align.
Jun 30 2020, 11:57 PM · Restricted Project
courbet added inline comments to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.
Jun 30 2020, 11:57 PM · Restricted Project
courbet accepted D81372: [Alignment][NFC] TargetLowering::allowsMemoryAccessForAlignment.
Jun 30 2020, 8:06 AM · Restricted Project
courbet added inline comments to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.
Jun 30 2020, 8:06 AM · Restricted Project
courbet accepted D82850: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemmove to Align.
Jun 30 2020, 3:14 AM · Restricted Project
courbet accepted D82851: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemset to Align.
Jun 30 2020, 3:14 AM · Restricted Project
courbet accepted D82849: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemcpy to Align.
Jun 30 2020, 3:14 AM · Restricted Project
courbet accepted D82749: [Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align.
Jun 30 2020, 12:30 AM · Restricted Project
courbet accepted D82779: [Alignment][NFC] Migrate PPC, X86 and XCore backends to Align.
Jun 30 2020, 12:30 AM · Restricted Project
courbet accepted D82785: [Alignment][NFC] TargetLowering::allowsMemoryAccess.
Jun 30 2020, 12:30 AM · Restricted Project

Jun 29 2020

courbet accepted D82454: [ADT] Add Bitfield utilities - design #3.
Jun 29 2020, 5:54 AM · Restricted Project
courbet accepted D82648: [NFC] Introduce a helper in BasicTTIImpl.h to cast to T.
Jun 29 2020, 5:21 AM · Restricted Project
courbet added inline comments to D82749: [Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align.
Jun 29 2020, 4:49 AM · Restricted Project
courbet accepted D82743: [Alignment][NFC] Migrate AMDGPU backend to Align.
Jun 29 2020, 4:49 AM · Restricted Project
courbet accepted D82752: [Alignment][NFC] migrate DataLayout::getPreferredAlignment.
Jun 29 2020, 4:17 AM · Restricted Project

Jun 26 2020

courbet accepted D82653: [Alignment][NFC] Migrate TTI::isLegalToVectorize{Load,Store}Chain to Align.
Jun 26 2020, 7:03 AM · Restricted Project