Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (273 w, 6 d)

Recent Activity

Today

courbet accepted D103900: [llvm] Add enum iteration to Sequence.
Wed, Jun 23, 6:59 AM · Restricted Project, Restricted Project
courbet accepted D104511: [libc] add benchmarks for memcmp and bzero.
Wed, Jun 23, 5:31 AM · Restricted Project
courbet added inline comments to D103900: [llvm] Add enum iteration to Sequence.
Wed, Jun 23, 2:31 AM · Restricted Project, Restricted Project
courbet added inline comments to D103900: [llvm] Add enum iteration to Sequence.
Wed, Jun 23, 2:12 AM · Restricted Project, Restricted Project

Sun, Jun 20

courbet added inline comments to D104511: [libc] add benchmarks for memcmp and bzero.
Sun, Jun 20, 10:34 PM · Restricted Project

Mon, Jun 14

courbet added a comment to D104226: [libc] Add a set of elementary operations.

LGTM for libc/src/string/memory_utils/elements.h

Mon, Jun 14, 10:42 PM · Restricted Project
courbet added inline comments to D104226: [libc] Add a set of elementary operations.
Mon, Jun 14, 7:42 AM · Restricted Project

Thu, Jun 10

courbet accepted D104018: [clang-tidy] Allow disabling integer narrowing conversions for cppcoreguidelines-narrowing-conversions.
Thu, Jun 10, 3:50 AM · Restricted Project

Mon, Jun 7

courbet accepted D103251: [NFC] Fix semantic discrepancy for MVT::LAST_VALUETYPE.
Mon, Jun 7, 2:46 AM · Restricted Project

Thu, Jun 3

courbet added inline comments to D102760: [llvm] Let SmallVector construct from any Iterable.
Thu, Jun 3, 12:37 AM · Restricted Project, Restricted Project

Mon, May 24

courbet accepted D102522: [llvm-exegesis] Loop unrolling for loop snippet repetitor mode.
Mon, May 24, 11:35 PM · Restricted Project
courbet accepted D102679: [llvm] Make Sequence reverse-iterable.
Mon, May 24, 10:51 PM · Restricted Project, Restricted Project

May 21 2021

courbet added inline comments to D102679: [llvm] Make Sequence reverse-iterable.
May 21 2021, 7:30 AM · Restricted Project, Restricted Project

May 20 2021

courbet added inline comments to D102679: [llvm] Make Sequence reverse-iterable.
May 20 2021, 11:02 AM · Restricted Project, Restricted Project

May 18 2021

courbet added inline comments to D102679: [llvm] Make Sequence reverse-iterable.
May 18 2021, 5:31 AM · Restricted Project, Restricted Project

May 16 2021

courbet added a comment to D102522: [llvm-exegesis] Loop unrolling for loop snippet repetitor mode.

Cool, thanks for the change. I like the approach, only have minor comments.

May 16 2021, 11:25 PM · Restricted Project

May 7 2021

courbet accepted D102056: [llvm][NFC] Remove deprecated TargetFrameLowering and InstrTypes alignment functions.
May 7 2021, 2:37 AM · Restricted Project
courbet accepted D102058: [llvm][NFC] Remove remaining deprecated alignment functions from CodeGen.
May 7 2021, 2:37 AM · Restricted Project

May 5 2021

courbet accepted D101905: [llvm][NFC] Remove deprecated Alignment::None().
May 5 2021, 11:19 PM · Restricted Project
courbet accepted D101906: [llvm][NFC] Remove deprecated DataLayout::getPreferredAlignment functions.
May 5 2021, 11:19 PM · Restricted Project
courbet accepted D101907: [llvm][NFC] Remove deprecated InterleaveGroup::getAlignment() function..
May 5 2021, 11:18 PM · Restricted Project
courbet accepted D101909: [llvm][NFC] Remove SelectionDag alignment deprecated functions.
May 5 2021, 11:18 PM · Restricted Project
courbet accepted D101910: [llvm][NFC] Remove CallingConvLower deprecated alignment functions.
May 5 2021, 11:17 PM · Restricted Project

Apr 19 2021

courbet committed rG9e9f991ac033: [llvm-exegesis] Honor -mcpu in analysis mode. (authored by courbet).
[llvm-exegesis] Honor -mcpu in analysis mode.
Apr 19 2021, 1:44 AM
courbet closed D100743: [llvm-exegesis] Honor -mcpu in analysis mode..
Apr 19 2021, 1:44 AM · Restricted Project
courbet requested review of D100743: [llvm-exegesis] Honor -mcpu in analysis mode..
Apr 19 2021, 12:45 AM · Restricted Project

Mar 29 2021

courbet requested review of D99511: [Verifier][NFC] Refactor operand bundle verification..
Mar 29 2021, 8:22 AM · Restricted Project

Mar 25 2021

courbet requested review of D99341: [WIP][IR] allow `inrange` on non-constant GEP instructions..
Mar 25 2021, 7:39 AM · Restricted Project
courbet updated the diff for D99247: [BasicAA] Teach BasicAA about GEP variable index ranges..

Add more proposals for representing the range data.

Mar 25 2021, 6:28 AM · Restricted Project

Mar 24 2021

courbet updated the diff for D99248: [RFC][CodeGen] Emit range metadata for array subscript..

Forgot to add test file.

Mar 24 2021, 3:56 AM · Restricted Project
courbet requested review of D99248: [RFC][CodeGen] Emit range metadata for array subscript..
Mar 24 2021, 2:13 AM · Restricted Project
courbet requested review of D99247: [BasicAA] Teach BasicAA about GEP variable index ranges..
Mar 24 2021, 2:09 AM · Restricted Project

Mar 22 2021

courbet added a comment to D99022: [IR] Mark assume/annotation as InaccessibleMemOnly.

Thanks @nikic !

Mar 22 2021, 12:05 AM · Restricted Project
courbet abandoned D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..

Retiring this in favor of D99022.

Mar 22 2021, 12:04 AM · Restricted Project

Mar 19 2021

courbet updated the diff for D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..

fix conjugation.

Mar 19 2021, 1:55 AM · Restricted Project
courbet added a comment to D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..

Thi sis similar to

Mar 19 2021, 1:53 AM · Restricted Project
courbet updated the diff for D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..

use switch as suggested

Mar 19 2021, 1:52 AM · Restricted Project
courbet updated the diff for D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..

Rebase on test base to show diff.

Mar 19 2021, 12:52 AM · Restricted Project
courbet committed rG926cca9679fb: [InstCombine] Add unit test with @llvm.annotation. (authored by courbet).
[InstCombine] Add unit test with @llvm.annotation.
Mar 19 2021, 12:50 AM
courbet added a reviewer for D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo.: hfinkel.
Mar 19 2021, 12:42 AM · Restricted Project
courbet requested review of D98925: [BasicAA] Ignore @llvm.annotation when computing ModRefInfo..
Mar 19 2021, 12:39 AM · Restricted Project

Mar 10 2021

courbet added a comment to D97854: [RFC][nsan] A Floating-point numerical sanitizer..

Is there a mechanism to instruct the sanitizer to ignore a specific expression or function? From a cursory reading, I am mildly concerned about a deluge of false positives from primitives that compute exact (or approximate) residuals; these are acting to eliminate or precisely control floating-point errors, but tend to show up as "unstable" in a naive analysis that isn't aware of them.

Mar 10 2021, 10:46 PM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2021

courbet added a comment to D97854: [RFC][nsan] A Floating-point numerical sanitizer..

When bootstrapping LLVM with nsan, there are only a few issues.

Mar 3 2021, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
courbet requested review of D97854: [RFC][nsan] A Floating-point numerical sanitizer..
Mar 3 2021, 6:22 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2021

courbet accepted D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

Nice, thanks. I tried that a couple years back but had ARM buildbot errors that maintainers were not able to expain. Let's hope it goes better this time !

Feb 26 2021, 5:26 AM · Restricted Project
courbet committed rGb16cbd8890a0: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes. (authored by courbet).
[llvm-exegesis][X86] Ignore a few unmeasurable opcodes.
Feb 26 2021, 1:49 AM
courbet closed D90744: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes..
Feb 26 2021, 1:49 AM · Restricted Project

Jan 6 2021

courbet accepted D93457: [libc] Align src buffer instead of dst buffer.
Jan 6 2021, 2:44 AM · Restricted Project

Dec 17 2020

courbet accepted D93210: [libc] revamp memory function benchmark.

Only cosmetic comments.

Dec 17 2020, 4:42 AM · Restricted Project

Dec 16 2020

courbet added inline comments to D93210: [libc] revamp memory function benchmark.
Dec 16 2020, 12:51 AM · Restricted Project

Dec 15 2020

courbet accepted D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 15 2020, 11:00 PM

Dec 14 2020

courbet added a comment to D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..

Thanks for the patch. Apparently both gcc and clang are fine if the attribute is placed before the definition: https://godbolt.org/z/5aTrcb, so we could do without the ifdefs.
(Though gcc does not know about the attribute, but that's also the case with the current version)

Dec 14 2020, 11:29 PM

Dec 1 2020

courbet committed rG735e6c888ec8: [MergeICmps] Fix missing split. (authored by courbet).
[MergeICmps] Fix missing split.
Dec 1 2020, 7:51 AM
courbet closed D92375: [MergeICmps] Fix missing split..
Dec 1 2020, 7:51 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Improve commit message.

Dec 1 2020, 7:43 AM · Restricted Project
courbet added a comment to D92375: [MergeICmps] Fix missing split..

Thanks for the comments.

Dec 1 2020, 6:50 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

...and add a side-effecting instruction at the top.

Dec 1 2020, 6:49 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Make the test more robust to future optimizations as suggested by James.

Dec 1 2020, 6:43 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Simplify the test as suggested by James.

Dec 1 2020, 6:40 AM · Restricted Project
courbet updated the diff for D92375: [MergeICmps] Fix missing split..

Update comment.

Dec 1 2020, 6:23 AM · Restricted Project
courbet added a comment to D92364: [MergeICmps] Disable if a GEP does not reference an Argument.

Thanks for the repro. I think a better fix is D92375 (missing split).

Dec 1 2020, 2:33 AM · Restricted Project
courbet requested review of D92375: [MergeICmps] Fix missing split..
Dec 1 2020, 2:32 AM · Restricted Project

Nov 26 2020

courbet added a comment to D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.

Thanks, comments addressed.

Nov 26 2020, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
courbet updated the diff for D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.

Add to release notes.

Nov 26 2020, 7:17 AM · Restricted Project, Restricted Project, Restricted Project
courbet requested review of D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.
Nov 26 2020, 6:48 AM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2020

courbet added a comment to D91833: [SelectionDAG] Avoid aliasing analysis if the object size is unknown..

Thanks, could you please add a unit test for this ?

Nov 19 2020, 10:54 PM · Restricted Project

Nov 17 2020

courbet added a comment to D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.

LGTM for llvm-exegesis

Nov 17 2020, 6:06 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

courbet added a comment to D90592: [llvm-exegesis] Save target state before running the benchmark..

This was eventually landed as rG8383fddc4fa9b4e61954e5ac93b00719a39d2291

Nov 12 2020, 7:25 AM · Restricted Project

Nov 11 2020

courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

hi @courbet,
our internal buildbots at Azul has failed because of an older assembler. We’ve taken in all commits/reverts/relands w.r.t this change upto Nov 4th.

The specific failure is:
/tmp/cc2lBtEi.s: Assembler messages:
/tmp/cc2lBtEi.s:541: Error: no such instruction: `fxsave64 16(%rax)'
/tmp/cc2lBtEi.s:566: Error: no such instruction: `fxrstor64 16(%rdi)'
/tmp/cc2lBtEi.s:592: Error: no such instruction: `fxrstor64 16(%rdi)'
make[2]: *** [tools/llvm-exegesis/lib/X86/CMakeFiles/LLVMExegesisX86.dir/Target.cpp.o] Error 1

Any suggestions to fix this apart from an upgrade (which seems to be a very invasive change on our machines)?

Nov 11 2020, 11:15 PM · Restricted Project

Nov 4 2020

courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

Looks like this doesn't build on windows: http://45.33.8.238/win/27220/step_4.txt

Thanks, I missed this bot. I'll send a fix.

Nov 4 2020, 4:24 AM · Restricted Project
courbet committed rG9287eb352e6c: [llvm-exegesis] Fix rGaf658d920e2b (authored by courbet).
[llvm-exegesis] Fix rGaf658d920e2b
Nov 4 2020, 4:24 AM
courbet added a comment to D90742: [llvm-exegesis][X86] Save and restore eflags..

Looks like this doesn't build on windows: http://45.33.8.238/win/27220/step_4.txt

Nov 4 2020, 4:20 AM · Restricted Project
courbet requested review of D90744: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes..
Nov 4 2020, 1:47 AM · Restricted Project
courbet committed rGaf658d920e2b: [llvm-exegesis][X86] Save and restore eflags. (authored by courbet).
[llvm-exegesis][X86] Save and restore eflags.
Nov 4 2020, 1:44 AM
courbet closed D90742: [llvm-exegesis][X86] Save and restore eflags..
Nov 4 2020, 1:44 AM · Restricted Project
courbet requested review of D90742: [llvm-exegesis][X86] Save and restore eflags..
Nov 4 2020, 1:17 AM · Restricted Project
courbet committed rG045c3692099a: [llvm-exegesis] Fix unused variable warning. (authored by courbet).
[llvm-exegesis] Fix unused variable warning.
Nov 4 2020, 1:10 AM
courbet added a reverting change for rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark.: rG8383fddc4fa9: Re-land "[llvm-exegesis] Save target state before running the benchmark.".
Nov 4 2020, 12:47 AM
courbet committed rG8383fddc4fa9: Re-land "[llvm-exegesis] Save target state before running the benchmark." (authored by courbet).
Re-land "[llvm-exegesis] Save target state before running the benchmark."
Nov 4 2020, 12:47 AM

Nov 3 2020

courbet added a reverting change for rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark.: rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark..
Nov 3 2020, 11:49 PM
courbet committed rG8cfc872129a9: Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
Revert "Re-land "[llvm-exegesis] Save target state before running the benchmark.
Nov 3 2020, 11:49 PM
courbet added a reverting change for rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.": rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark..
Nov 3 2020, 11:35 PM
courbet committed rGfd13d7ce09af: Re-land "[llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
Re-land "[llvm-exegesis] Save target state before running the benchmark.
Nov 3 2020, 11:35 PM

Nov 2 2020

courbet added a reverting change for rG274de447fe96: [llvm-exegesis] Save target state before running the benchmark.: rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.".
Nov 2 2020, 6:12 AM
courbet committed rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark." (authored by courbet).
Revert "[llvm-exegesis] Save target state before running the benchmark."
Nov 2 2020, 6:12 AM
courbet added a reverting change for D90592: [llvm-exegesis] Save target state before running the benchmark.: rGe128f9cafca4: Revert "[llvm-exegesis] Save target state before running the benchmark.".
Nov 2 2020, 6:12 AM · Restricted Project
courbet committed rG274de447fe96: [llvm-exegesis] Save target state before running the benchmark. (authored by courbet).
[llvm-exegesis] Save target state before running the benchmark.
Nov 2 2020, 6:03 AM
courbet closed D90592: [llvm-exegesis] Save target state before running the benchmark..
Nov 2 2020, 6:03 AM · Restricted Project
courbet updated the diff for D90592: [llvm-exegesis] Save target state before running the benchmark..

Address review comments

Nov 2 2020, 4:40 AM · Restricted Project
courbet added a comment to D90592: [llvm-exegesis] Save target state before running the benchmark..

Thanks, PTAL.

Nov 2 2020, 4:39 AM · Restricted Project
courbet requested review of D90592: [llvm-exegesis] Save target state before running the benchmark..
Nov 2 2020, 1:59 AM · Restricted Project
courbet committed rG7706c3022ead: [llvm-exegesis] Print signal name when the snippet crashed. (authored by courbet).
[llvm-exegesis] Print signal name when the snippet crashed.
Nov 2 2020, 1:42 AM
courbet closed D90453: [llvm-exegesis] Print signal name when the snippet crashed..
Nov 2 2020, 1:42 AM · Restricted Project

Oct 30 2020

courbet requested review of D90453: [llvm-exegesis] Print signal name when the snippet crashed..
Oct 30 2020, 4:02 AM · Restricted Project

Oct 29 2020

courbet committed rG24bf8faabd62: [llvm-exegesis] Do not try to assign random registers twice. (authored by courbet).
[llvm-exegesis] Do not try to assign random registers twice.
Oct 29 2020, 5:28 AM
courbet closed D90380: [llvm-exegesis] Do not try to assign random registers twice..
Oct 29 2020, 5:27 AM · Restricted Project
courbet requested review of D90380: [llvm-exegesis] Do not try to assign random registers twice..
Oct 29 2020, 3:56 AM · Restricted Project

Oct 28 2020

courbet committed rGa098f32a1fc8: [llvm-exegesis][doc] Remove old FIXME. (authored by courbet).
[llvm-exegesis][doc] Remove old FIXME.
Oct 28 2020, 2:53 AM
courbet committed rG7e2ffe7a6358: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats. (authored by courbet).
[llvm-exegesis] Do not silently fail on unknown instruction encoding formats.
Oct 28 2020, 2:07 AM
courbet closed D90289: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats..
Oct 28 2020, 2:07 AM · Restricted Project