Page MenuHomePhabricator

[PATCH] [llvm] [Support] Update license on ConvertUTF.* per upstream license change
Needs ReviewPublic

Authored by mgorny on Aug 18 2019, 3:07 AM.

Details

Summary

According to [1], the author of the code found in ConvertUTF.* has
stated that the code has been relicensed to the standard Unicode license
as found on [2]. Update our copyright header appropriately, following
the same action done by Google breakpad maintainers [3].

Most importantly, the old license was non-free, effectively rendering
the whole LLVM distribution non-free. This is a major problem e.g. for
Debian [4], and has been also reported to LLVM Bugzilla [5]. I have
accidentally missed this license in Gentoo, and adding it will render
the package non-free which is going to cause real pain to some of our
users.

Sylvestre Ledru has already started working on porting LLVM to use
breakpad's version but apparently his work was stalled in regressions.
Since the issue is urgent, I am proposing instead to update the license
without porting other changes.

[1] https://bugs.chromium.org/p/google-breakpad/issues/detail?id=270
[2] https://www.unicode.org/copyright.html
[3] https://chromium.googlesource.com/breakpad/breakpad/+/14bbefbd9600e08d6a34d7250faa8bc9dba2113e
[4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916945
[5] https://bugs.llvm.org/show_bug.cgi?id=32962

Diff Detail

Event Timeline

mgorny created this revision.Aug 18 2019, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2019, 3:07 AM

I don't think we can unilaterally update the license. Especially as the new code is different.
My change need some work (summer doesn't help). The testsuites work, the unit tests on this file don't.

And it isnt really urgent as it has been this way for years now

As I've noted on D64740, the code in breakpad is identical (except for ordering and whitespace changes) to our initial code. All code differences between us and breakpad are our local changes. Therefore, I think we can change the license in place. If you really insist, I can reorder the functions match ordering in breakpad, and do some whitespace changes ;-).

@chandlerc What do you think? thanks!

Some more ping.

sylvestre.ledru resigned from this revision.Jun 18 2020, 3:47 AM

I would like to see that happening but I am not a lawyer and important enough person in the project to make such call.

With my experience with license (ex: iceweasel vs firefox), I am sure that @chandlerc isn't ignoring you, just that he cannot answer about this subject.