- User Since
- Mar 8 2013, 1:12 AM (422 w, 2 d)
Tue, Apr 6
To understand better, we will be fixing a bug from 2015, correct?
Mon, Apr 5
Sun, Apr 4
I am not opposed to this. I am just afraid that we will miss all the deadlines :)
OK, no worries.
I don't think it will regress the situation anyway
Many thanks. it fixed my issues!
It would be great to:
Sat, Apr 3
Thanks for taking the time to reply
Also, please avoid using terms like madness, awful patch, etc when talking about the work of others...
That said, I think most stuff has been done with gcov. So new development may be rare.
Mon, Mar 22
Do we have tests for this?
If so, it would be nice to add some :)
Mar 12 2021
To help with turnaround time, we, at Mozilla, are happy to quickly review your patches
Feb 2 2021
I confirm that it fixed the problem - still occurring on 12
Jan 31 2021
Jan 25 2021
This change doesn't build with gcc 5.3.1.
More details: https://bugs.llvm.org/show_bug.cgi?id=48869
Jan 20 2021
I guess this will be clearly mentioned in the release notes :)
Let's do it then :)
Yeah, my question is more "is that enough for distro?"
I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself?
Dec 22 2020
Thanks for the revert!
Error only on Windows
Dec 16 2020
I love the idea. Many thanks for implementing it!
I think it should go in the release notes.
Dec 14 2020
@serge-sans-paille ok to push this? :)
Dec 13 2020
I think there is something wrong in this patch
It creates a new library called:
Dec 11 2020
@mhq199657 we (Mozilla/Firefox) moved to the Google Coding style. So, we are less interested by this change now.
Dec 4 2020
Thanks for doing that :)
Nov 30 2020
extend the test (thanks serge)
Fix the error message
Nov 28 2020
Nov 27 2020
Nov 18 2020
I am not 100% that it is thanks to this patch but reformatting Firefox code with clang-format 11 significantly improves the readability of the usage
of ternary operators. See: https://phabricator.services.mozilla.com/D90795
Nov 17 2020
Great idea. Do you have an example of what the configuration could look like on a distro?
Nov 7 2020
Sounds great. You might want to ask feedback to other reviews too!
Could you please also update the release notes for 12?
FWIW, I am doing this change already in Debian & Ubuntu ( https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/10/debian/clang-tidy-X.Y.links.in#L2 )
Oct 31 2020
I think it is now fixed
Sorry, I am not a good reviewer for this file
I guess it isn't possible to write a test for this?
Looks good to me
Oct 29 2020
Oct 21 2020
I can reproduce the build issue on apt.llvm.org
ed if you want to approve it ;)
Oct 17 2020
Oct 16 2020
Add the test which was failing + add the previous tests (but disabled)
Oct 15 2020
Oct 13 2020
Oct 12 2020
@JakeMerdichAMD as the regression caused by this change is way more significant than the initial bug, I am planning to revert this patch in the next few days (both in master and 11).
Please let me know if you have any objection.
Oct 8 2020
Oct 7 2020
Sep 21 2020
@MarcusJohnson91 I know it is confusing but we don't use the Mozilla coding style. We are using the Google style.
Sep 20 2020
Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ?
Sep 17 2020
I am sure you are planning to do it but please don't forget the release notes and the documentation.
Sep 16 2020
Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code (fixed with the autofix):
Sep 9 2020
I guess it isn't possible to write tests for this?
Jul 8 2020
Jun 22 2020
Excellent, thanks :)
Jun 19 2020
it breaks the build on Debian stable (and probably some Ubuntu LTS). With sphinx 1.8.4
Could you please revert the change ?
Jun 18 2020
maybe this improvement should be added to the release notes too ?
I would like to see that happening but I am not a lawyer and important enough person in the project to make such call.
works for me
I like "arc land" but I am not opposed to changing the doc
Jun 4 2020
@zequanwu could you please update the release notes? thanks
May 29 2020
May 28 2020
May 18 2020
May 13 2020
Can you point to me how Firefox uses -Xclang -coverage-no-function-names-in-data? Debian code search does not reveal anything.