Page MenuHomePhabricator

jlebar (Justin Lebar)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 8 2015, 10:33 AM (259 w, 1 d)

Google developer working on CUDA for Clang. On IRC as jlebar.

Recent Activity

Sun, Nov 22

jlebar added a comment to D91928: [nvptx] Skip alloca for read-only byval arguments..

In case it's not used in PHI or SELECT and cannot ensure the result is also a pointer to the parameter space, we could skip alloca insertion.

Sun, Nov 22, 2:38 PM · Restricted Project
jlebar added a comment to D91928: [nvptx] Skip alloca for read-only byval arguments..

I don't believe there's any exception to prove deduction [of the readonly attribute] wrong.

Sun, Nov 22, 9:40 AM · Restricted Project
jlebar added a comment to D91928: [nvptx] Skip alloca for read-only byval arguments..

This looks really simple, which is awesome. I am enthusiastic. But I am worried it may not be correct.

Sun, Nov 22, 12:01 AM · Restricted Project

Thu, Nov 19

jlebar accepted D91807: [CUDA] Unbreak CUDA compilation with -std=c++20.

How fun. :)

Thu, Nov 19, 10:22 AM · Restricted Project

Tue, Nov 17

jlebar added a comment to D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters..

I am legit excited about this if we could figure out how to make it work, but I don't have anything to add beyond what tra said.

Tue, Nov 17, 3:24 PM · Restricted Project, Restricted Project

Mon, Nov 9

jlebar added a comment to D85603: IR: Add convergence control operand bundle and intrinsics.

The bottomline seems to be that the proposed formalism achieves the following: <snip>

Mon, Nov 9, 4:49 PM · Restricted Project

Tue, Nov 3

jlebar added a comment to D90409: [HIP] Math Headers to use type promotion.

LGTM. I think the change would make sense for CUDA, too. @jlebar - WDYT?

Tue, Nov 3, 10:45 AM · Restricted Project, Restricted Project

Sun, Nov 1

jlebar added a comment to D85603: IR: Add convergence control operand bundle and intrinsics.

Man, phab doesn't make this easy, does it?

Sun, Nov 1, 9:49 AM · Restricted Project

Wed, Oct 28

jlebar updated subscribers of D85603: IR: Add convergence control operand bundle and intrinsics.

Hi. :) A few people pinged me asking for my feedback here, since I touched the convergent attr way back in the day, for CUDA.

Wed, Oct 28, 11:34 PM · Restricted Project

Oct 22 2020

jlebar accepted D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found.

LGTM modulo emankov's comment.

Oct 22 2020, 10:04 AM · Restricted Project

Oct 14 2020

jlebar committed rGe9ac1869a82a: Preserve param alignment in NVPTXLowerArgs pass. (authored by jlebar).
Preserve param alignment in NVPTXLowerArgs pass.
Oct 14 2020, 11:16 AM
jlebar closed D89404: Preserve param alignment in NVPTXLowerArgs pass..
Oct 14 2020, 11:15 AM · Restricted Project
jlebar updated the summary of D89404: Preserve param alignment in NVPTXLowerArgs pass..
Oct 14 2020, 11:10 AM · Restricted Project
jlebar updated the diff for D89404: Preserve param alignment in NVPTXLowerArgs pass..

Fix bug in test command line, and fix commit message.

Oct 14 2020, 11:09 AM · Restricted Project
jlebar added a comment to D89404: Preserve param alignment in NVPTXLowerArgs pass..

It does not quite match what we do here.

Oct 14 2020, 11:08 AM · Restricted Project
jlebar requested review of D89404: Preserve param alignment in NVPTXLowerArgs pass..
Oct 14 2020, 9:59 AM · Restricted Project

Oct 13 2020

jlebar accepted D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..
Oct 13 2020, 3:31 PM · Restricted Project

Oct 2 2020

jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

Hey, I'm leaving on a vacation tomorrow and didn't have a chance to get to
this review today.

Oct 2 2020, 10:14 PM · Restricted Project

Oct 1 2020

jlebar added a comment to D88668: [CUDA] Add support for 11.1.

It looks like 11.1 doesn't have a version.txt file

Oct 1 2020, 9:18 AM · Restricted Project

Sep 28 2020

jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

It should. I did mention in a previous comment that > Looks like the const-ness check should not be there, either. I need to revise the patch.

Sep 28 2020, 4:38 PM · Restricted Project
jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

OK, now I'm starting to I understand this change..

Sep 28 2020, 12:03 PM · Restricted Project
jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

OK, backing up, what are the semantics of static on __constant__, __device__, and __shared__?

Sep 28 2020, 10:46 AM · Restricted Project

Sep 25 2020

jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

wha... As you know, const doesn't mean anything, that can be const-casted away. And then you'll be able to observe that this nominally-static variable is just a normal variable.

Sep 25 2020, 4:47 PM · Restricted Project

Sep 24 2020

jlebar accepted D88255: [test-suite, CUDA] Compile-time test for builtin variables..
Sep 24 2020, 1:03 PM
jlebar accepted D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars..

I know it comes in a separate change, but can we add a check to the test-suite?

Sep 24 2020, 11:14 AM · Restricted Project

Aug 5 2020

jlebar accepted D85352: [CUDA, test-suite] More test cases for rint() and nearint().
Aug 5 2020, 12:59 PM
jlebar accepted D85349: [CUDA, test-suite] Prevent constant folding of the test inputs..
Aug 5 2020, 12:58 PM

Aug 4 2020

jlebar accepted D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA..

LGTM, and can we write a test in the test-suite?

Aug 4 2020, 12:25 PM · Restricted Project

Jul 15 2020

jlebar added a comment to D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference.

tra and I talked offline and I...think this makes sense.

Jul 15 2020, 4:33 PM · Restricted Project

Mar 1 2020

jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

@RKSimon and others, thank you for the review and comments. Sorry for my delay here; this has changed from being my day job to my weekend hobby, and that made a bigger difference in my responsiveness than I'd like or than I expected.

Mar 1 2020, 12:43 PM · Restricted Project
jlebar updated the diff for D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Update per comments.

Mar 1 2020, 12:40 PM · Restricted Project

Feb 23 2020

jlebar committed rG10a0ec62f671: Replace std::foo with std::foo_t in LLVM. (authored by jlebar).
Replace std::foo with std::foo_t in LLVM.
Feb 23 2020, 11:27 AM

Feb 18 2020

jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 18 2020, 1:30 PM · Restricted Project
jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 18 2020, 1:12 PM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Thank you for the comments!

Feb 18 2020, 1:03 PM · Restricted Project

Feb 12 2020

jlebar closed D74493: Replace std::foo with std::foo_t in LLVM..

Submitted as a4384c756bd8a8190510. I'm working from my wife's machine and accidentally submitted with her name instead of mine. Oops. :)

Feb 12 2020, 6:01 PM · Restricted Project
jlebar added a comment to D74493: Replace std::foo with std::foo_t in LLVM..

Thank you for the reviews!

Feb 12 2020, 4:22 PM · Restricted Project
jlebar abandoned D53414: Add instructions for migrating branches from one git repository to another..
Feb 12 2020, 4:22 PM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

@RKSimon friendly ping

Feb 12 2020, 4:22 PM · Restricted Project
jlebar added a comment to D74515: Add coding standard recommending use of qualifiers in cpp files.

Do we have any nontrivially-long namespaces in LLVM?

Feb 12 2020, 4:04 PM · Restricted Project
jlebar created D74493: Replace std::foo with std::foo_t in LLVM..
Feb 12 2020, 9:10 AM · Restricted Project
jlebar committed rGbc316c21570b: Fix SFINAE in llvm::bit_cast. (authored by jlebar).
Fix SFINAE in llvm::bit_cast.
Feb 12 2020, 8:33 AM
jlebar committed rG17b774181211: Fix compilation of Any.h header. (authored by jlebar).
Fix compilation of Any.h header.
Feb 12 2020, 8:33 AM
jlebar closed D74380: Fix SFINAE in llvm::bit_cast..
Feb 12 2020, 8:33 AM · Restricted Project
jlebar added a comment to D74384: Use std::foo_t rather than std::foo in LLVM..

Looks like this broke building on windows with clang-cl as host compiler in some situations: http://45.33.8.238/win/8160/step_4.txt

Feb 12 2020, 8:14 AM · Restricted Project, Restricted Project

Feb 11 2020

jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Thank you for the reviews!

Feb 11 2020, 11:21 PM · Restricted Project
jlebar committed rG1bd6123b7811: Use std::foo_t rather than std::foo in LLVM. (authored by jlebar).
Use std::foo_t rather than std::foo in LLVM.
Feb 11 2020, 3:17 PM
jlebar closed D74384: Use std::foo_t rather than std::foo in LLVM..
Feb 11 2020, 3:17 PM · Restricted Project, Restricted Project
jlebar committed rGac66c61bf946: Use C++14-style return type deduction in clang. (authored by jlebar).
Use C++14-style return type deduction in clang.
Feb 11 2020, 2:50 PM
jlebar closed D74423: Use C++14-style return type deduction in clang..
Feb 11 2020, 2:49 PM · Restricted Project
jlebar committed rG027eb71696f6: Use std::foo_t rather than std::foo in clang. (authored by jlebar).
Use std::foo_t rather than std::foo in clang.
Feb 11 2020, 10:42 AM
jlebar committed rGf0fd852fcd05: Fix SFINAE in CFG.cpp. (authored by jlebar).
Fix SFINAE in CFG.cpp.
Feb 11 2020, 10:42 AM
jlebar closed D74414: Use std::foo_t rather than std::foo in clang..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar closed D74412: Fix SFINAE in CFG.cpp..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar created D74423: Use C++14-style return type deduction in clang..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Lint: Pre-merge checks

Feb 11 2020, 9:03 AM · Restricted Project
jlebar created D74414: Use std::foo_t rather than std::foo in clang..
Feb 11 2020, 7:50 AM · Restricted Project
jlebar updated the diff for D74412: Fix SFINAE in CFG.cpp..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project
jlebar created D74412: Fix SFINAE in CFG.cpp..
Feb 11 2020, 7:50 AM · Restricted Project
jlebar updated the diff for D74384: Use std::foo_t rather than std::foo in LLVM..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project, Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project
jlebar committed rGfb45968e6285: Use C++14-style return type deduction in LLVM. (authored by jlebar).
Use C++14-style return type deduction in LLVM.
Feb 11 2020, 7:41 AM
jlebar committed rGdd11c8fb0d07: Fix SFINAE in JSON.h constructor. (authored by jlebar).
Fix SFINAE in JSON.h constructor.
Feb 11 2020, 7:41 AM
jlebar closed D74383: Use C++14-style return type deduction in LLVM..
Feb 11 2020, 7:41 AM · Restricted Project
jlebar closed D74381: Fix SFINAE in JSON.h constructor..
Feb 11 2020, 7:41 AM · Restricted Project
jlebar added a comment to D74381: Fix SFINAE in JSON.h constructor..

Thank you for the review!

Feb 11 2020, 7:41 AM · Restricted Project
jlebar added a comment to D74383: Use C++14-style return type deduction in LLVM..

Thank you for the review!

Feb 11 2020, 7:41 AM · Restricted Project
jlebar abandoned D26943: [CodingStandards] Add style guide rule about "if" statements and loops..
Feb 11 2020, 7:32 AM · Restricted Project

Feb 10 2020

jlebar added a reviewer for D74381: Fix SFINAE in JSON.h constructor.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a reviewer for D74383: Use C++14-style return type deduction in LLVM.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a reviewer for D74380: Fix SFINAE in llvm::bit_cast.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a comment to D74384: Use std::foo_t rather than std::foo in LLVM..

Such changes can be risky.

Feb 10 2020, 11:24 PM · Restricted Project, Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?

Feb 10 2020, 10:49 PM · Restricted Project
jlebar updated the diff for D74384: Use std::foo_t rather than std::foo in LLVM..

Rebase to origin/master.

Feb 10 2020, 10:37 PM · Restricted Project, Restricted Project
jlebar created D74384: Use std::foo_t rather than std::foo in LLVM..
Feb 10 2020, 10:23 PM · Restricted Project, Restricted Project
jlebar added a reviewer for D74383: Use C++14-style return type deduction in LLVM.: bkramer.
Feb 10 2020, 9:48 PM · Restricted Project
jlebar created D74383: Use C++14-style return type deduction in LLVM..
Feb 10 2020, 9:48 PM · Restricted Project
jlebar added a reviewer for D74380: Fix SFINAE in llvm::bit_cast.: jfb.
Feb 10 2020, 8:49 PM · Restricted Project
jlebar created D74381: Fix SFINAE in JSON.h constructor..
Feb 10 2020, 8:39 PM · Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Undo overzealous re-clang-formatting.

Feb 10 2020, 8:37 PM · Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Attempt to remove files that should have been ignored.

Feb 10 2020, 8:37 PM · Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

"How did this ever work?" Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?

Feb 10 2020, 8:37 PM · Restricted Project
jlebar created D74380: Fix SFINAE in llvm::bit_cast..
Feb 10 2020, 8:25 PM · Restricted Project
jlebar abandoned D74379: Fix SFINAE in llvm::bit_cast..

arc is not cooperating; I'm going to delete this and create a new review. Sorry for the noise.

Feb 10 2020, 8:25 PM · Restricted Project
jlebar updated the diff for D74379: Fix SFINAE in llvm::bit_cast..

Attempt to remove files which shouldn't be in here.

Feb 10 2020, 8:25 PM · Restricted Project
jlebar added a comment to D74379: Fix SFINAE in llvm::bit_cast..

Hm, thank you, arc, for including files that were not in my commit...

Feb 10 2020, 8:25 PM · Restricted Project
jlebar created D74379: Fix SFINAE in llvm::bit_cast..
Feb 10 2020, 8:25 PM · Restricted Project
jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 10 2020, 10:57 AM · Restricted Project
jlebar updated the diff for D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Fix regressions and add vector test.

Feb 10 2020, 10:55 AM · Restricted Project

Feb 7 2020

jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 7 2020, 10:45 AM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Hi, thank you for looking at this!

Feb 7 2020, 9:04 AM · Restricted Project

Feb 6 2020

jlebar committed rG6d007343deca: Clarify how llvm-mca detects att vs intel syntax. (authored by jlebar).
Clarify how llvm-mca detects att vs intel syntax.
Feb 6 2020, 7:40 PM
jlebar closed D72385: Clarify how llvm-mca detects att vs intel syntax..
Feb 6 2020, 7:40 PM · Restricted Project
jlebar abandoned D72357: Fix llvm-objcopy when directory contains "bar"..

Thank you for the reviews, and I'm sorry I dropped off the face of the earth here! I was messing with my phab settings and I think I somehow disabled all emails. Oops.

Feb 6 2020, 4:14 PM · Restricted Project
jlebar added a comment to D72385: Clarify how llvm-mca detects att vs intel syntax..

Thank you for the review, and I'm sorry for falling off the face of the earth for a few weeks. Somehow I misconfigured either phab or gmail so I wasn't receiving any review emails!

Feb 6 2020, 2:17 PM · Restricted Project
jlebar created D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 6 2020, 1:57 PM · Restricted Project

Jan 7 2020

jlebar created D72385: Clarify how llvm-mca detects att vs intel syntax..
Jan 7 2020, 9:29 PM · Restricted Project
jlebar created D72357: Fix llvm-objcopy when directory contains "bar"..
Jan 7 2020, 12:10 PM · Restricted Project

Nov 8 2019

jlebar added a comment to D69878: Consoldiate internal denormal flushing controls.

AMDGPU wants a distinct control for f32 flushing from f16/f64, and as far as I can tell the same is true for NVPTX (based on the attribute name).

Nov 8 2019, 11:48 AM · Restricted Project

Oct 27 2019

jlebar added a comment to D69493: Add -fconvergent-functions flag.

I'm confused about "The CUDA builtin library is apparently compiled in C++ mode". By...whom, and for what purposes?

Oct 27 2019, 7:36 PM