This is an archive of the discontinued LLVM Phabricator instance.

Differential D64167

[TargetLowering] support BlockAddress as "i" inline asm constraint
ClosedPublic

Authored by nickdesaulniers on Jul 3 2019, 4:12 PM.

Details

Reviewers
ostannard
Commits
rG8728e4570653: [TargetLowering] support BlockAddress as "i" inline asm constraint
rL365664: [TargetLowering] support BlockAddress as "i" inline asm constraint
Summary

This allows passing address of labels to inline assembly "i" input
constraints.

Fixes pr/42502.

Diff Detail

Repository
rL LLVM

Event Timeline

nickdesaulniers created this revision.Jul 3 2019, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 4:12 PM
Herald added subscribers: llvm-commits, hiraditya, javed.absar. · View Herald Transcript
Harbormaster completed remote builds in B34326: Diff 207912.Jul 3 2019, 4:14 PM
nickdesaulniers updated this revision to Diff 207914.Jul 3 2019, 4:19 PM
  • git-clang-format HEAD~
nickdesaulniers added a reviewer: void.Jul 3 2019, 4:19 PM
Harbormaster completed remote builds in B34327: Diff 207914.Jul 3 2019, 4:20 PM
ostannard accepted this revision.Jul 4 2019, 2:22 AM
ostannard added a subscriber: ostannard.

LGTM with one nit.

llvm/test/CodeGen/AArch64/inline-asm-i-constraint-i1.ll
1 ↗(On Diff #207914)

The name of this file is now inaccurate, could you rename it or split the new test into a new file?

This revision is now accepted and ready to land.Jul 4 2019, 2:22 AM
nickdesaulniers updated this revision to Diff 208474.Jul 8 2019, 12:27 PM
  • move unit test to new file
Harbormaster completed remote builds in B34522: Diff 208474.Jul 8 2019, 12:28 PM
nickdesaulniers updated this revision to Diff 208476.Jul 8 2019, 12:28 PM
nickdesaulniers marked an inline comment as done.
  • remove missed change
Harbormaster completed remote builds in B34523: Diff 208476.Jul 8 2019, 12:29 PM
nickdesaulniers added a comment.Jul 8 2019, 2:02 PM

How's that look now, @ostannard ? (Thanks for code review)

fhahn mentioned this in D64101: [LoopUnroll] fix cloning callbr.Jul 8 2019, 2:34 PM
nickdesaulniers added a child revision: D64101: [LoopUnroll] fix cloning callbr.Jul 8 2019, 3:02 PM
nathanchance added a subscriber: nathanchance.Jul 8 2019, 5:47 PM
ostannard accepted this revision.Jul 10 2019, 6:06 AM
nickdesaulniers removed reviewers: echristo, void.Jul 10 2019, 9:56 AM
nickdesaulniers added subscribers: echristo, void.
Closed by commit rL365664: [TargetLowering] support BlockAddress as "i" inline asm constraint (authored by nickdesaulniers). · Explain WhyJul 10 2019, 10:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
CodeGen/
SelectionDAG/
7 lines
test/
CodeGen/
AArch64/
12 lines

Diff 209002

llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Show First 20 Lines • Show All 3,626 Lines • ▼ Show 20 Lines case 'X': // Allows any operand; labels (basic block) use this.
} }
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
case 'i': // Simple Integer or Relocatable Constant case 'i': // Simple Integer or Relocatable Constant
case 'n': // Simple Integer case 'n': // Simple Integer
case 's': { // Relocatable Constant case 's': { // Relocatable Constant
GlobalAddressSDNode *GA; GlobalAddressSDNode *GA;
ConstantSDNode *C; ConstantSDNode *C;
BlockAddressSDNode *BA;
uint64_t Offset = 0; uint64_t Offset = 0;
// Match (GA) or (C) or (GA+C) or (GA-C) or ((GA+C)+C) or (((GA+C)+C)+C), // Match (GA) or (C) or (GA+C) or (GA-C) or ((GA+C)+C) or (((GA+C)+C)+C),
// etc., since getelementpointer is variadic. We can't use // etc., since getelementpointer is variadic. We can't use
// SelectionDAG::FoldSymbolOffset because it expects the GA to be accessible // SelectionDAG::FoldSymbolOffset because it expects the GA to be accessible
// while in this case the GA may be furthest from the root node which is // while in this case the GA may be furthest from the root node which is
// likely an ISD::ADD. // likely an ISD::ADD.
while (1) { while (1) {
Show All 11 Lines while (1) {
BooleanContent BCont = getBooleanContents(MVT::i64); BooleanContent BCont = getBooleanContents(MVT::i64);
ISD::NodeType ExtOpc = IsBool ? getExtendForContent(BCont) ISD::NodeType ExtOpc = IsBool ? getExtendForContent(BCont)
: ISD::SIGN_EXTEND; : ISD::SIGN_EXTEND;
int64_t ExtVal = ExtOpc == ISD::ZERO_EXTEND ? C->getZExtValue() int64_t ExtVal = ExtOpc == ISD::ZERO_EXTEND ? C->getZExtValue()
: C->getSExtValue(); : C->getSExtValue();
Ops.push_back(DAG.getTargetConstant(Offset + ExtVal, Ops.push_back(DAG.getTargetConstant(Offset + ExtVal,
SDLoc(C), MVT::i64)); SDLoc(C), MVT::i64));
return; return;
} else if ((BA = dyn_cast<BlockAddressSDNode>(Op)) &&
ConstraintLetter != 'n') {
Ops.push_back(DAG.getTargetBlockAddress(
BA->getBlockAddress(), BA->getValueType(0),
Offset + BA->getOffset(), BA->getTargetFlags()));
return;
} else { } else {
const unsigned OpCode = Op.getOpcode(); const unsigned OpCode = Op.getOpcode();
if (OpCode == ISD::ADD || OpCode == ISD::SUB) { if (OpCode == ISD::ADD || OpCode == ISD::SUB) {
if ((C = dyn_cast<ConstantSDNode>(Op.getOperand(0)))) if ((C = dyn_cast<ConstantSDNode>(Op.getOperand(0))))
Op = Op.getOperand(1); Op = Op.getOperand(1);
// Subtraction is not commutative. // Subtraction is not commutative.
else if (OpCode == ISD::ADD && else if (OpCode == ISD::ADD &&
(C = dyn_cast<ConstantSDNode>(Op.getOperand(1)))) (C = dyn_cast<ConstantSDNode>(Op.getOperand(1))))
▲ Show 20 Lines • Show All 2,597 Lines • Show Last 20 Lines

llvm/trunk/test/CodeGen/AArch64/inline-asm-blockaddress.ll

; RUN: llc -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s
; CHECK-LABEL: foo:
; CHECK: TEST .Ltmp0
define void @foo() {
entry:
br label %bar
bar:
call void asm sideeffect "#TEST $0", "i,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %bar))
ret void
indirectgoto:
indirectbr i8* undef, [label %bar]
}