This is an archive of the discontinued LLVM Phabricator instance.

[analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)
ClosedPublic

Authored by hubert.reinterpretcast on Jun 6 2019, 7:07 AM.

Details

Summary

The %diff_plist lit substitution invokes diff with a non-portable -I option. The intended effect can be achieved by normalizing the inputs to diff beforehand. Such normalization can be done with grep -Ev, which is also used by other tests.

This patch applies the change (adjusted for review comments) described in http://lists.llvm.org/pipermail/cfe-dev/2019-April/061904.html mechanically to the cases where the output file is piped to %diff_plist via cat.

The changes were applied via a script, except that clang/test/Analysis/NewDelete-path-notes.cpp and clang/test/Analysis/plist-macros-with-expansion.cpp were each adjusted for the line-continuation on the relevant RUN step.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2019, 7:07 AM

Update based on review comments, building from rL362877 and D63041

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2019, 3:34 PM