Page MenuHomePhabricator

jasonliu (Jason Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 1:13 PM (246 w, 5 d)

Recent Activity

Today

jasonliu added inline comments to D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.
Wed, Apr 14, 2:58 PM
jasonliu updated the diff for D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.

Use __builtin_va_copy instead.

Wed, Apr 14, 2:54 PM
jasonliu requested review of D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.
Wed, Apr 14, 2:09 PM

Yesterday

jasonliu updated the diff for D100333: [libc++] Config `pointer_safety` type to be backward compatible on AIX.

Fix failed test case from pre-commit CI.

Tue, Apr 13, 9:02 AM
jasonliu added inline comments to D100333: [libc++] Config `pointer_safety` type to be backward compatible on AIX.
Tue, Apr 13, 8:48 AM

Mon, Apr 12

jasonliu committed rG52e9d80d5db2: [libc++] add `inline` for __open's definition in ifstream and ofstream (authored by jasonliu).
[libc++] add `inline` for __open's definition in ifstream and ofstream
Mon, Apr 12, 12:26 PM
jasonliu closed D99422: [libc++] add `inline` for __open in ifstream and ofstream.
Mon, Apr 12, 12:26 PM · Restricted Project
jasonliu requested review of D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.
Mon, Apr 12, 12:10 PM
jasonliu requested review of D100333: [libc++] Config `pointer_safety` type to be backward compatible on AIX.
Mon, Apr 12, 11:45 AM

Fri, Apr 9

jasonliu committed rGf3d7536b24f1: [libc++] Fix abs and div overload issue for compilers on AIX (authored by jasonliu).
[libc++] Fix abs and div overload issue for compilers on AIX
Fri, Apr 9, 7:48 AM
jasonliu closed D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.
Fri, Apr 9, 7:47 AM · Restricted Project

Thu, Apr 8

jasonliu updated the diff for D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.

Update diff to trigger pre-CI rebuild.

Thu, Apr 8, 3:00 PM · Restricted Project

Wed, Apr 7

jasonliu accepted D99291: [AIX] Support init priority attribute.

LGTM.

Wed, Apr 7, 3:55 PM · Restricted Project

Mon, Apr 5

jasonliu updated subscribers of D99257: [XCOFF] dynamically allocating the section and csect group .

Thanks for working on this version of the patch. It's always good to have something concrete to talk about instead of imaging how it's going to look like when everything is in place.
I'm still not convinced that dynamically allocating csect groups is the way to go though.
As you could see in the patch, the code are more complicated with dynamic allocation, and less efficient(doing more loopings to find the correct CsectGroup).
Also, we now lose control of how the CsectGroup are going to layout inside of a section, and how each section is going to layout in the object file (It now comes in a first come first serve order I believe).
This could bring some practical issues for us. For example, we may prefer to have layouts like: text -> data -> bss -> tdata -> tbss -> dwarf raw datas. But now, I think it's possible that we start having text -> data -> tdata -> bss -> tbss -> dwarf raw datas, which is not quite right when you have tdata cut in between of normal datas.
And I don't see a lot of benefit of having a single vector to contain DWARF sections and csect section. In D97184, we actually handles DWARF sections and csect sections quite differently (i.e. a large block of if/else statement for dwarf and csects).
I would still prefer only dynamically allocating DWARF raw datas, and have pre-defined csect sections. It's less of an issue to dynamically allocating DWARF raw datas because we do not really care the layout between different dwarf raw datas (as long as they are at the end of the object files).

Mon, Apr 5, 3:12 PM · Restricted Project

Thu, Apr 1

jasonliu added inline comments to D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.
Thu, Apr 1, 4:17 PM · Restricted Project
jasonliu updated the diff for D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.

Remove extra conditions because we only intended to target the headers for clang compilers.

Thu, Apr 1, 4:10 PM · Restricted Project
jasonliu requested review of D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.
Thu, Apr 1, 1:36 PM · Restricted Project
jasonliu added a comment to D99422: [libc++] add `inline` for __open in ifstream and ofstream.

@ldionne Hi Louis, what do you think about this patch? Do you have any ABI implication concern?

Thu, Apr 1, 9:27 AM · Restricted Project

Fri, Mar 26

jasonliu added inline comments to D99422: [libc++] add `inline` for __open in ifstream and ofstream.
Fri, Mar 26, 11:11 AM · Restricted Project
jasonliu updated the diff for D99422: [libc++] add `inline` for __open in ifstream and ofstream.

Making basic_filebuf's __open consistent with other __open.

Fri, Mar 26, 11:05 AM · Restricted Project
jasonliu added inline comments to D99422: [libc++] add `inline` for __open in ifstream and ofstream.
Fri, Mar 26, 9:59 AM · Restricted Project
jasonliu updated the summary of D99422: [libc++] add `inline` for __open in ifstream and ofstream.
Fri, Mar 26, 9:39 AM · Restricted Project
jasonliu requested review of D99422: [libc++] add `inline` for __open in ifstream and ofstream.
Fri, Mar 26, 9:38 AM · Restricted Project

Wed, Mar 24

jasonliu committed rG09a84d304776: [libc++] Match declaration for non-member function std::swap(std… (authored by jasonliu).
[libc++] Match declaration for non-member function std::swap(std…
Wed, Mar 24, 3:34 PM
jasonliu closed D99102: [libc++] Match declaration for non-member function std::swap(std::packaged_task) with what standard specify.
Wed, Mar 24, 3:34 PM · Restricted Project
jasonliu committed rG158026301b48: [libc++][AIX] Initial patch to unblock the libc++ build on AIX (authored by jasonliu).
[libc++][AIX] Initial patch to unblock the libc++ build on AIX
Wed, Mar 24, 3:15 PM
jasonliu closed D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Wed, Mar 24, 3:15 PM · Restricted Project, Restricted Project
jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

@hubert.reinterpretcast Does the freelocale approach look good to you?

Wed, Mar 24, 1:46 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Use freelocale instead to avoid using thread local on Z.

Wed, Mar 24, 1:44 PM · Restricted Project, Restricted Project

Tue, Mar 23

jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Add back setlocale and use __ prefix in case of user macro expansion.

Tue, Mar 23, 3:17 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Use thread_local for newlocale variable.

Tue, Mar 23, 1:34 PM · Restricted Project, Restricted Project
jasonliu added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Tue, Mar 23, 11:28 AM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Use "C" locale when NULL is passed.

Tue, Mar 23, 11:25 AM · Restricted Project, Restricted Project

Mon, Mar 22

jasonliu updated the diff for D99102: [libc++] Match declaration for non-member function std::swap(std::packaged_task) with what standard specify.

Got it. Make sense. I removed the test case in case we want to have the declaration be more like what standard have in the text.

Mon, Mar 22, 2:08 PM · Restricted Project
jasonliu requested review of D99102: [libc++] Match declaration for non-member function std::swap(std::packaged_task) with what standard specify.
Mon, Mar 22, 12:20 PM · Restricted Project
jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Ping for reviews from AIX's perspective. @xingxue @daltenty @hubert.reinterpretcast @Xiangling_L

Mon, Mar 22, 10:14 AM · Restricted Project, Restricted Project

Fri, Mar 19

jasonliu added inline comments to D97184: [XCOFF] support DWARF for XCOFF for object output.
Fri, Mar 19, 2:23 PM · Restricted Project
jasonliu added inline comments to D97184: [XCOFF] support DWARF for XCOFF for object output.
Fri, Mar 19, 2:05 PM · Restricted Project
jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

This LGTM but I would really really like to have a pre-commit node set up for this platform if we are going to support it properly.

Fri, Mar 19, 7:21 AM · Restricted Project, Restricted Project

Wed, Mar 17

jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Are all those people whose names I don't recognize AIX people? Any of them want to chime in with a "yes, this looks appropriate for our target"?

Wed, Mar 17, 1:57 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Rebase so that buildbot could build.

Wed, Mar 17, 1:05 PM · Restricted Project, Restricted Project
jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

@Quuxplusone While waiting for the second reviewer, I added an extra change since you approved: do not build cxa_thread_atexit.cpp on AIX.
Could you take a quick look to see if that's okay?

Wed, Mar 17, 12:41 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Added do not build cxa_thread_atexit.cpp for libcxxabi on AIX.

Wed, Mar 17, 12:39 PM · Restricted Project, Restricted Project
jasonliu added inline comments to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Wed, Mar 17, 9:00 AM · Restricted Project

Tue, Mar 16

jasonliu added a comment to D97184: [XCOFF] support DWARF for XCOFF for object output.

FYI, I decide to review this patch before D97049 because I wouldn't know if the NFC make sense without the context of this patch.

Tue, Mar 16, 1:46 PM · Restricted Project
jasonliu added inline comments to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Tue, Mar 16, 7:02 AM · Restricted Project
jasonliu added inline comments to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Tue, Mar 16, 6:55 AM · Restricted Project

Mar 15 2021

jasonliu accepted D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

I think what we usually do for test case is to upstream some pre-compiled binaries for testing purpose. But that's not the way community preferred anyway because those binaries are baked, and might be hard to reproduce later. Given this patch is small and pretty self-explanatory, I'm okay with skipping the test and let D97184 to "test" it.
FYI @hubert.reinterpretcast in case he think we should still upstream a pre-compiled binary for testing.
Otherwise, the patch LGTM.

Mar 15 2021, 2:16 PM · Restricted Project
jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Thanks @Quuxplusone for the review.
Ping for a second reviewer in libc++ review group.

Mar 15 2021, 11:34 AM · Restricted Project, Restricted Project
jasonliu updated the diff for D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Address Arthur's comment.

Mar 15 2021, 11:32 AM · Restricted Project, Restricted Project

Mar 12 2021

jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

Gentle ping.

Mar 12 2021, 6:07 AM · Restricted Project, Restricted Project

Mar 4 2021

jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 7:21 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 6:39 PM · debug-info, Restricted Project
jasonliu accepted D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

LGTM if the nit comment is addressed
There are two items that we need to follow up after this patch:

  1. The corner case/bug in https://reviews.llvm.org/D95518#inline-919030
  2. The possibility of addressing the FIXME for https://reviews.llvm.org/D95518#inline-918884
Mar 4 2021, 10:01 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 9:23 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 7:12 AM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 6:57 AM · debug-info, Restricted Project

Mar 3 2021

jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 3 2021, 5:56 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 3 2021, 10:39 AM · debug-info, Restricted Project

Mar 2 2021

jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 2 2021, 11:26 AM · debug-info, Restricted Project

Mar 1 2021

jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 1 2021, 7:49 PM · debug-info, Restricted Project
jasonliu added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 1 2021, 9:46 AM · debug-info, Restricted Project

Feb 26 2021

jasonliu added a comment to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

It would be cool if this builder got added to the precommit CI. Any plans on that?

Feb 26 2021, 4:23 PM · Restricted Project, Restricted Project
jasonliu requested review of D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Feb 26 2021, 8:24 AM · Restricted Project, Restricted Project

Feb 9 2021

jasonliu accepted D96184: [AIX][TLS] Generate TLS variables in assembly files.

LGTM with minor nit.

Feb 9 2021, 7:26 AM · Restricted Project, Restricted Project

Jan 12 2021

jasonliu accepted D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

LGTM with minor nits.

Jan 12 2021, 4:01 PM · Restricted Project

Jan 11 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 11 2021, 4:23 PM · Restricted Project

Jan 6 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 6 2021, 2:40 PM · Restricted Project

Dec 22 2020

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Dec 22 2020, 12:04 PM · Restricted Project
jasonliu added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Dec 22 2020, 8:37 AM · Restricted Project

Dec 10 2020

jasonliu accepted D92398: [AIX][XCOFF] emit traceback table for function in aix.

Thanks. LGTM.
Please allow some time for @hubert.reinterpretcast to go over again before you land.

Dec 10 2020, 10:27 AM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 8:44 AM · Restricted Project
jasonliu added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 10 2020, 7:09 AM · Restricted Project

Dec 9 2020

jasonliu updated the diff for D92766: [XCOFF][AIX] Emit EH information in traceback table.

Rebased on the latest parent.

Dec 9 2020, 7:59 PM · Restricted Project
jasonliu added a comment to D92766: [XCOFF][AIX] Emit EH information in traceback table.

ping.

Dec 9 2020, 2:58 PM · Restricted Project

Dec 8 2020

jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 8 2020, 2:35 PM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 8 2020, 2:24 PM · Restricted Project
jasonliu added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 8 2020, 1:53 PM · Restricted Project
jasonliu updated the diff for D92766: [XCOFF][AIX] Emit EH information in traceback table.

Address comments.

Dec 8 2020, 10:38 AM · Restricted Project
jasonliu added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 8 2020, 10:25 AM · Restricted Project

Dec 7 2020

jasonliu added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 7 2020, 3:17 PM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 7 2020, 3:10 PM · Restricted Project
jasonliu added inline comments to D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 7 2020, 11:20 AM · Restricted Project
jasonliu requested review of D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 7 2020, 7:49 AM · Restricted Project

Dec 4 2020

jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 4 2020, 2:49 PM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 4 2020, 12:56 PM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 4 2020, 12:45 PM · Restricted Project

Dec 3 2020

jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 3 2020, 12:05 PM · Restricted Project
jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 3 2020, 7:14 AM · Restricted Project

Dec 2 2020

jasonliu added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 2 2020, 1:03 PM · Restricted Project
jasonliu closed D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.

Manually closing this because I spelled the Differential Revision wrong.

Dec 2 2020, 12:32 PM · Restricted Project
jasonliu committed rG2c63e7604c87: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128… (authored by jasonliu).
[XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128…
Dec 2 2020, 12:04 PM
jasonliu committed rGa65d8c5d720d: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX (authored by jasonliu).
[XCOFF][AIX] Generate LSDA data and compact unwind section on AIX
Dec 2 2020, 10:43 AM
jasonliu closed D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Dec 2 2020, 10:43 AM · Restricted Project, Restricted Project
jasonliu updated the diff for D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.

Address comments and rebase.

Dec 2 2020, 7:31 AM · Restricted Project

Dec 1 2020

jasonliu added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Dec 1 2020, 1:34 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.

Address comments.

Dec 1 2020, 1:33 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Dec 1 2020, 12:51 PM · Restricted Project
jasonliu updated the diff for D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.

Address comments.

Dec 1 2020, 12:45 PM · Restricted Project
jasonliu added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Dec 1 2020, 11:29 AM · Restricted Project