Page MenuHomePhabricator

daltenty (David Tenty)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2019, 2:54 PM (80 w, 4 d)

Recent Activity

Today

daltenty accepted D89492: [compiler-rt] Enable building builtins using top-level CMake file.

LGTM, with slight adjustment. Though I will note that this requires a clean build because CMake will complain about the change in source directory in cache:

Mon, Oct 19, 3:11 PM · Restricted Project, Restricted Project

Thu, Oct 15

daltenty added a comment to D89492: [compiler-rt] Enable building builtins using top-level CMake file.

This is an alternative to D70744. I'm not a fan of introducing compiler-rt/builtins as a new top-level CMake, so I was trying to come up with an alternative and this is what I came up with, let me know what you think.

Thu, Oct 15, 5:41 PM · Restricted Project, Restricted Project
daltenty accepted D70744: [compiler-rt] Split the builtins CMake build to a separate file.

LGTM, this should still be good to land (with just the minor updates)

Thu, Oct 15, 8:47 AM · Restricted Project, Restricted Project

Tue, Oct 13

daltenty committed rG19856c598289: [NFC][compiler-rt] Add ppc32 to the list of arch (authored by daltenty).
[NFC][compiler-rt] Add ppc32 to the list of arch
Tue, Oct 13, 8:32 PM
daltenty added inline comments to D70744: [compiler-rt] Split the builtins CMake build to a separate file.
Tue, Oct 13, 2:21 PM · Restricted Project, Restricted Project
daltenty added reviewers for D70744: [compiler-rt] Split the builtins CMake build to a separate file: daltenty, hubert.reinterpretcast.
Tue, Oct 13, 1:19 PM · Restricted Project, Restricted Project
daltenty abandoned D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.

See D70744 which is trying to achieve the same, but instead it builds crt together with builtins. When I started working on that change, I also considered the approached used in this change and I briefly discussed it with @beanz, but there was a concern that adding more stages is going to increase already long build time even further.

@phosek Thanks, I think it makes a lot of sense to keep it all together in a single stage. It also avoids duplicating a lot of the config which this approach does. I'm not opposed to abandoning this revision if you'd prefer to revive D70744 instead then?

@phosek Gentle ping on whether we are keeping this patch around, or if you'd like to update D70744 (since it's already approved) instead. I can merge the approach of D70744 into here if you'd prefer to abandon that one instead.

I plan to land D70744.

Tue, Oct 13, 1:18 PM · Restricted Project, Restricted Project
daltenty planned changes to D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.
Tue, Oct 13, 11:26 AM · Restricted Project, Restricted Project
daltenty added a comment to D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.

See D70744 which is trying to achieve the same, but instead it builds crt together with builtins. When I started working on that change, I also considered the approached used in this change and I briefly discussed it with @beanz, but there was a concern that adding more stages is going to increase already long build time even further.

@phosek Thanks, I think it makes a lot of sense to keep it all together in a single stage. It also avoids duplicating a lot of the config which this approach does. I'm not opposed to abandoning this revision if you'd prefer to revive D70744 instead then?

Tue, Oct 13, 9:22 AM · Restricted Project, Restricted Project

Fri, Oct 9

daltenty retitled D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro from [CMake][ExecutionEngine] Upgrade HAVE_EHTABLES_SUPPORT to a real config.h macro to [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
Fri, Oct 9, 1:17 PM · Restricted Project
daltenty retitled D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro from [CMake][ExecutionEngine] Upgrade HAVE_EHTABLES to a real config.h macro to [CMake][ExecutionEngine] Upgrade HAVE_EHTABLES_SUPPORT to a real config.h macro.
Fri, Oct 9, 1:17 PM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
  • Add a newline
Fri, Oct 9, 1:04 PM · Restricted Project
daltenty retitled D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro from [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX to [CMake][ExecutionEngine] Upgrade HAVE_EHTABLES to a real config.h macro.
Fri, Oct 9, 1:02 PM · Restricted Project
daltenty updated the diff for D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
  • Upgrade HAVE_EHTABLE_SUPPORT to a real config.h macro
Fri, Oct 9, 12:46 PM · Restricted Project

Wed, Oct 7

daltenty added a comment to D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.

See D70744 which is trying to achieve the same, but instead it builds crt together with builtins. When I started working on that change, I also considered the approached used in this change and I briefly discussed it with @beanz, but there was a concern that adding more stages is going to increase already long build time even further.

Wed, Oct 7, 10:07 AM · Restricted Project, Restricted Project

Tue, Oct 6

daltenty requested review of D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.
Tue, Oct 6, 3:29 PM · Restricted Project, Restricted Project
daltenty accepted D87451: add new option -mignore-xcoff-visibility.

LGTM, other minor nit

Tue, Oct 6, 1:14 PM · Restricted Project, Restricted Project
daltenty updated the summary of D87451: add new option -mignore-xcoff-visibility.
Tue, Oct 6, 1:07 PM · Restricted Project, Restricted Project
daltenty added inline comments to D87451: add new option -mignore-xcoff-visibility.
Tue, Oct 6, 1:06 PM · Restricted Project, Restricted Project
daltenty added inline comments to D87451: add new option -mignore-xcoff-visibility.
Tue, Oct 6, 1:00 PM · Restricted Project, Restricted Project
daltenty updated the summary of D87451: add new option -mignore-xcoff-visibility.
Tue, Oct 6, 11:47 AM · Restricted Project, Restricted Project
daltenty updated the summary of D87451: add new option -mignore-xcoff-visibility.
Tue, Oct 6, 11:46 AM · Restricted Project, Restricted Project
daltenty retitled D87451: add new option -mignore-xcoff-visibility from add new option ignore-xcoff-visibility to add new option -mignore-xcoff-visibility.
Tue, Oct 6, 11:45 AM · Restricted Project, Restricted Project

Fri, Oct 2

daltenty added inline comments to D87451: add new option -mignore-xcoff-visibility.
Fri, Oct 2, 10:11 AM · Restricted Project, Restricted Project

Thu, Oct 1

daltenty accepted D88627: [runtimes] Remove TOOLCHAIN_TOOLS specialization.

LGTM! Thanks for the clarification.

Thu, Oct 1, 9:49 AM · Restricted Project
daltenty added a comment to D88627: [runtimes] Remove TOOLCHAIN_TOOLS specialization.

This actually isn't exclusively a revert of D85329 "[AIX] Try to not use LLVM tools while building runtimes" as the title seems to suggest. Before that patch there were already explicit TOOLCHAIN_TOOLS specified in the call to llvm_ExternalProject_Add in the runtimes build, which already suppressed the target-specific tool selection as mention in the description here.

Thu, Oct 1, 8:27 AM · Restricted Project
daltenty committed rG5665ec4e182d: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake (authored by daltenty).
[compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake
Thu, Oct 1, 6:45 AM
daltenty closed D88608: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake.
Thu, Oct 1, 6:45 AM · Restricted Project

Wed, Sep 30

daltenty requested review of D88608: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake.
Wed, Sep 30, 1:01 PM · Restricted Project
daltenty committed rGafc277b0ed0d: [AIX][Clang][Driver] Link libm in c++ mode (authored by daltenty).
[AIX][Clang][Driver] Link libm in c++ mode
Wed, Sep 30, 11:02 AM
daltenty closed D88500: [AIX][Clang][Driver] Link libm in c++ mode.
Wed, Sep 30, 11:02 AM · Restricted Project
daltenty accepted D88339: [XCOFF] Enable -fdata-sections on AIX.

LGTM, thanks

Wed, Sep 30, 9:09 AM · Restricted Project

Tue, Sep 29

daltenty updated the diff for D88500: [AIX][Clang][Driver] Link libm in c++ mode.
  • Make dependant on just c++ mode
  • Add missing colons
Tue, Sep 29, 1:56 PM · Restricted Project
daltenty retitled D88500: [AIX][Clang][Driver] Link libm in c++ mode from [AIX][Clang][Driver] Link libm when we would libc++ to [AIX][Clang][Driver] Link libm in c++ mode.
Tue, Sep 29, 1:55 PM · Restricted Project
daltenty updated the diff for D88500: [AIX][Clang][Driver] Link libm in c++ mode.
  • Add blank line
Tue, Sep 29, 1:49 PM · Restricted Project
daltenty updated the diff for D88500: [AIX][Clang][Driver] Link libm in c++ mode.
  • Remove deps comment
Tue, Sep 29, 1:48 PM · Restricted Project
daltenty retitled D88500: [AIX][Clang][Driver] Link libm in c++ mode from [AIX][Clang][Driver] Link libm along with libc++ to [AIX][Clang][Driver] Link libm when we would libc++.
Tue, Sep 29, 1:46 PM · Restricted Project
daltenty requested review of D88500: [AIX][Clang][Driver] Link libm in c++ mode.
Tue, Sep 29, 9:56 AM · Restricted Project
daltenty added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Tue, Sep 29, 8:58 AM · Restricted Project
daltenty accepted D80953: [AIX] asm output: use character literals in byte lists for strings.

LGTM, thanks!

Tue, Sep 29, 8:07 AM · Restricted Project

Mon, Sep 28

daltenty committed rGee80615b5c1c: [clang][driver][AIX] Set compiler-rt as default rtlib (authored by daltenty).
[clang][driver][AIX] Set compiler-rt as default rtlib
Mon, Sep 28, 4:46 PM
daltenty closed D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.
Mon, Sep 28, 4:46 PM · Restricted Project
daltenty updated the diff for D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.
  • Remove blankline
  • Fix path seperators in second test as well
Mon, Sep 28, 3:58 PM · Restricted Project
daltenty added a comment to D88157: [CMake] Make sure _cmake_system_name has a default.

This broke our macOS builders because now llvm-libtool-darwin tool is being used by default which leads to a build failure:

D88449 should address this issue.

Mon, Sep 28, 3:45 PM · Restricted Project
daltenty committed rG25affb04aab7: [CMake][AIX] Limit tools in external project build (authored by daltenty).
[CMake][AIX] Limit tools in external project build
Mon, Sep 28, 2:00 PM
daltenty closed D88310: [CMake][AIX] Limit tools in external project build.
Mon, Sep 28, 2:00 PM · Restricted Project
daltenty added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Mon, Sep 28, 7:52 AM · Restricted Project
daltenty updated the diff for D88310: [CMake][AIX] Limit tools in external project build.
  • Remove stray llvm-lipo from list
Mon, Sep 28, 6:17 AM · Restricted Project

Fri, Sep 25

daltenty updated the diff for D88310: [CMake][AIX] Limit tools in external project build.
  • Address comments
Fri, Sep 25, 1:12 PM · Restricted Project
daltenty added a reviewer for D88310: [CMake][AIX] Limit tools in external project build: stevewan.
Fri, Sep 25, 8:50 AM · Restricted Project
daltenty committed rGc74da051b868: [CMake] Make sure _cmake_system_name has a default (authored by daltenty).
[CMake] Make sure _cmake_system_name has a default
Fri, Sep 25, 8:33 AM
daltenty closed D88157: [CMake] Make sure _cmake_system_name has a default.
Fri, Sep 25, 8:33 AM · Restricted Project
daltenty requested review of D88310: [CMake][AIX] Limit tools in external project build.
Fri, Sep 25, 8:21 AM · Restricted Project
daltenty committed rGe03dd978d015: [AIX] Try to not use LLVM tools while building runtimes (authored by daltenty).
[AIX] Try to not use LLVM tools while building runtimes
Fri, Sep 25, 7:55 AM

Thu, Sep 24

daltenty added inline comments to D87451: add new option -mignore-xcoff-visibility.
Thu, Sep 24, 2:18 PM · Restricted Project, Restricted Project
daltenty committed rG4b8cb665a13b: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX (authored by daltenty).
[CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX
Thu, Sep 24, 1:37 PM
daltenty closed D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX.
Thu, Sep 24, 1:37 PM · Restricted Project
daltenty updated the diff for D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX.
  • Adjust comments
Thu, Sep 24, 11:29 AM · Restricted Project
daltenty updated the diff for D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.
  • Fix formating
  • Fix typos
  • Replace pattern with windows-friendly directory seperators
Thu, Sep 24, 7:47 AM · Restricted Project

Wed, Sep 23

daltenty requested review of D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.
Wed, Sep 23, 2:11 PM · Restricted Project
daltenty retitled D88157: [CMake] Make sure _cmake_system_name has a default from [CMake] Make sure _cmake_system_name gets set to [CMake] Make sure _cmake_system_name has a default.
Wed, Sep 23, 10:47 AM · Restricted Project
daltenty updated the diff for D88157: [CMake] Make sure _cmake_system_name has a default.
  • Update comment
Wed, Sep 23, 10:42 AM · Restricted Project
daltenty requested review of D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX.
Wed, Sep 23, 10:22 AM · Restricted Project
daltenty requested review of D88157: [CMake] Make sure _cmake_system_name has a default.
Wed, Sep 23, 9:01 AM · Restricted Project
daltenty accepted D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

LGTM, thanks.

Wed, Sep 23, 7:03 AM · Restricted Project

Tue, Sep 22

daltenty added inline comments to D87451: add new option -mignore-xcoff-visibility.
Tue, Sep 22, 3:51 PM · Restricted Project, Restricted Project
daltenty committed rGc45596147938: [compiler-rt][AIX] Add CMake support for 32-bit Power builds (authored by daltenty).
[compiler-rt][AIX] Add CMake support for 32-bit Power builds
Tue, Sep 22, 1:09 PM
daltenty closed D87383: [compiler-rt][AIX] Add CMake support for 32-bit Power builds.
Tue, Sep 22, 1:09 PM · Restricted Project
daltenty committed rG89074bdc813a: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode (authored by daltenty).
[AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode
Tue, Sep 22, 8:11 AM
daltenty closed D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
Tue, Sep 22, 8:11 AM · Restricted Project
daltenty committed rGe8fb4eba4fb6: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode (authored by daltenty).
[AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode
Tue, Sep 22, 6:55 AM
daltenty closed D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Tue, Sep 22, 6:55 AM · Restricted Project

Mon, Sep 21

daltenty updated the diff for D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
  • Check absence in C cases
  • Add a note about crti in the nostdlib++ case
Mon, Sep 21, 2:57 PM · Restricted Project
daltenty committed rGd8540427419e: [AIX][Clang][Driver] Add handling of shared option (authored by daltenty).
[AIX][Clang][Driver] Add handling of shared option
Mon, Sep 21, 11:03 AM
daltenty closed D87914: [AIX][Clang][Driver] Add handling of shared option.
Mon, Sep 21, 11:03 AM · Restricted Project
daltenty committed rG699089f2a970: [AIX][Clang][Driver] Add handling of nostartfiles option (authored by daltenty).
[AIX][Clang][Driver] Add handling of nostartfiles option
Mon, Sep 21, 7:43 AM
daltenty closed D87904: [AIX][Clang][Driver] Add handling of nostartfiles option.
Mon, Sep 21, 7:42 AM · Restricted Project

Sep 18 2020

daltenty added reviewers for D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode: stevewan, hubert.reinterpretcast, xingxue.
Sep 18 2020, 12:02 PM · Restricted Project
daltenty requested review of D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Sep 18 2020, 11:59 AM · Restricted Project
daltenty added reviewers for D87914: [AIX][Clang][Driver] Add handling of shared option: Xiangling_L, hubert.reinterpretcast, xingxue.
Sep 18 2020, 9:14 AM · Restricted Project
daltenty requested review of D87914: [AIX][Clang][Driver] Add handling of shared option.
Sep 18 2020, 9:10 AM · Restricted Project
daltenty committed rG5d1f8395be94: [AIX] Enable large code model when building with clang (authored by daltenty).
[AIX] Enable large code model when building with clang
Sep 18 2020, 8:06 AM
daltenty added reviewers for D87904: [AIX][Clang][Driver] Add handling of nostartfiles option: stevewan, Xiangling_L, hubert.reinterpretcast.
Sep 18 2020, 7:20 AM · Restricted Project
daltenty requested review of D87904: [AIX][Clang][Driver] Add handling of nostartfiles option.
Sep 18 2020, 7:18 AM · Restricted Project
daltenty added a comment to D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.

Do we want to take advantage of this patch to move those checks into the cmake configure so we don't need to duplicate the logic in 2 files as @sfertile mentioned previously?

Sep 18 2020, 7:04 AM · Restricted Project

Sep 17 2020

daltenty updated the diff for D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
  • Fix whitespace and indentation
Sep 17 2020, 10:39 AM · Restricted Project
daltenty added a comment to D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.

since we will be building both 32-bit and 64-bit compiler-rt builtins
from a single configuration.

@daltenty, from the limited context of this patch, this sounds questionable in terms of avoiding silent errors now and in the future. If the idea is to configure once and then run twice in the same build tree, then some things may get cached either in CMake or in generated headers, etc.

Sep 17 2020, 10:15 AM · Restricted Project

Sep 9 2020

daltenty requested review of D87383: [compiler-rt][AIX] Add CMake support for 32-bit Power builds.
Sep 9 2020, 8:01 AM · Restricted Project

Sep 8 2020

daltenty updated the diff for D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
  • Adjust so we don't alter the MVS case
Sep 8 2020, 7:08 AM · Restricted Project

Sep 4 2020

daltenty accepted D87122: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py.

LGTM

Sep 4 2020, 3:22 PM · Restricted Project
daltenty updated the diff for D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
  • Add AR flags to the builtins CMake too since it may be used as a toplevel by the runtimes build
Sep 4 2020, 8:19 AM · Restricted Project

Sep 3 2020

daltenty requested review of D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
Sep 3 2020, 3:05 PM · Restricted Project
daltenty requested review of D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
Sep 3 2020, 2:54 PM · Restricted Project

Aug 25 2020

daltenty committed rGf8454d60b829: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require… (authored by daltenty).
[AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require…
Aug 25 2020, 8:36 AM
daltenty closed D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Aug 25 2020, 8:35 AM · Restricted Project

Aug 14 2020

daltenty updated the diff for D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
  • Fix comment.
Aug 14 2020, 6:59 AM · Restricted Project
daltenty retitled D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX from [AIX][compiler-rt] Don't add ppc builtin implementations that require __int128 on AIX to [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Aug 14 2020, 6:58 AM · Restricted Project
daltenty requested review of D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.
Aug 14 2020, 6:55 AM · Restricted Project

Aug 11 2020

daltenty added a comment to D85329: [AIX] Try to not use LLVM tools while building runtimes.

Fixed variable expansion syntax in TOOLCHAIN_TOOLS

Aug 11 2020, 1:18 PM · Restricted Project

Aug 10 2020

daltenty committed rG50dd75c8e0b8: [AIX] Try to not use LLVM tools while building runtimes (authored by daltenty).
[AIX] Try to not use LLVM tools while building runtimes
Aug 10 2020, 1:12 PM