This is an archive of the discontinued LLVM Phabricator instance.

Revert "Plug-in PlatformNetBSD initializer and terminator"
ClosedPublic

Authored by sivachandra on Nov 19 2015, 2:59 PM.

Diff Detail

Event Timeline

sivachandra retitled this revision from to Revert "Plug-in PlatformNetBSD initializer and terminator".
sivachandra updated this object.
sivachandra added reviewers: emaste, krytarowski.
sivachandra added a subscriber: lldb-commits.
This revision was automatically updated to reflect the committed changes.
krytarowski edited edge metadata.Nov 19 2015, 5:47 PM

Sorry for problems, I will investigate it.

Actually, I do not have time today to do a better job with digging and have to resort to reverting.

Could you please reference a hyperlink to the breakage? Have we got some mailing list to monitor it? Jumping over logs in waterfall isn't much convenient.

Agreed, when a CL is reverted due to a buildbot breakage, please include a
link to the failing bot in the commit message of the revert.

labath added a subscriber: labath.Nov 20 2015, 12:27 AM

If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame emails, as the tests are not passing 100% reliably (yet). We could add you to the opt-in list which we receive, but you'll probably regret that soon ;).

If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame emails, as the tests are not passing 100% reliably (yet). We could add you to the opt-in list which we receive, but you'll probably regret that soon ;).

Thank you, I was looking rather for build problems.. I will need to get Linux to try it out.

At first thought I don't see relevance of NetBSD platform code to trigger asserts in the aux path.

The problem is that in PlatformNetBSD::Initialize you call
Platform::SetHostPlatform unconditionally. You want to
call Platform::SetHostPlatform only if we are running on NetBSD so you have
to surround it with some conditional compilation (see example in
PlatformLinux::Initialize)

The problem is that in PlatformNetBSD::Initialize you call
Platform::SetHostPlatform unconditionally. You want to
call Platform::SetHostPlatform only if we are running on NetBSD so you have
to surround it with some conditional compilation (see example in
PlatformLinux::Initialize)

Thank you! You are right about it!

I've pasted a diff to address this regression as http://reviews.llvm.org/D14876

Please readd NetBSD platform connectors again and see what will happen.

This commit will possible break Xcode too.. but I cannot do anything with it. I will leave it to MacOSX owners.