Page MenuHomePhabricator

sivachandra (Siva Chandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:30 AM (325 w, 3 d)

Recent Activity

Thu, Jan 21

sivachandra updated subscribers of D95118: [CMake][libc] Distinguish compiler and run failures.
Thu, Jan 21, 10:17 AM · Restricted Project
sivachandra accepted D95118: [CMake][libc] Distinguish compiler and run failures.
Thu, Jan 21, 10:17 AM · Restricted Project

Wed, Jan 20

sivachandra requested review of D95054: Add a libc aarch64 worker and a debug builder running on it..
Wed, Jan 20, 9:03 AM
sivachandra accepted D95006: [libc][NFC] add "LlvmLibc" as a prefix to all test names.
Wed, Jan 20, 8:45 AM · Restricted Project

Tue, Jan 19

sivachandra committed rG7bd3702b6404: [libc] Extend the current fenv functions to aarch64. (authored by sivachandra).
[libc] Extend the current fenv functions to aarch64.
Tue, Jan 19, 12:48 PM
sivachandra closed D94947: [libc] Extend the current fenv functions to aarch64..
Tue, Jan 19, 12:48 PM · Restricted Project

Mon, Jan 18

sivachandra requested review of D94947: [libc] Extend the current fenv functions to aarch64..
Mon, Jan 18, 10:09 PM · Restricted Project
sivachandra committed rGffb254978cf4: [libc][NFC][Obvious] Add a missing dep. (authored by sivachandra).
[libc][NFC][Obvious] Add a missing dep.
Mon, Jan 18, 10:05 PM
sivachandra accepted D94760: [libc][NFC] remove dependency on non standard ssize_t.
Mon, Jan 18, 9:56 PM · Restricted Project
sivachandra committed rGbfbbb62b22f8: [libc][NFC] Use ASSERT_EQ instead of EXPECT_EQ in fenv/exception_status_test (authored by sivachandra).
[libc][NFC] Use ASSERT_EQ instead of EXPECT_EQ in fenv/exception_status_test
Mon, Jan 18, 9:41 PM

Thu, Jan 14

sivachandra accepted D94692: [libc] Allow customization of memcpy via flags..

Few inline nits.

Thu, Jan 14, 9:10 AM · Restricted Project

Wed, Jan 13

sivachandra accepted D94642: [libc] Use #undef isascii in specific header.

I am to blame for this. I did consider the approach you are suggesting, and also few other less ideal approaches. What you are proposing is the most appropriate way I would think but I did not like it previously for a few reasons.

Wed, Jan 13, 10:03 PM · Restricted Project
sivachandra accepted D93195: [libc] Add memmove implementation..
Wed, Jan 13, 8:41 PM · Restricted Project
sivachandra accepted D94634: [libc][NFC] change isblank and iscntrl from implicit casting.
Wed, Jan 13, 2:06 PM · Restricted Project
sivachandra accepted D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Wed, Jan 13, 1:10 PM · Restricted Project
sivachandra added inline comments to D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Wed, Jan 13, 12:06 PM · Restricted Project

Tue, Jan 12

sivachandra committed rG0c8466c0015e: [libc][NFC] Use more specific comparison macros in LdExpTest.h. (authored by sivachandra).
[libc][NFC] Use more specific comparison macros in LdExpTest.h.
Tue, Jan 12, 4:14 PM
sivachandra accepted D94558: [libc] add isascii and toascii implementations.
Tue, Jan 12, 3:02 PM · Restricted Project
sivachandra added a comment to D93195: [libc] Add memmove implementation..

LGTM, can you please wait for @sivachandra answer about using assert in code before submitting? Thx!

Tue, Jan 12, 2:42 PM · Restricted Project

Mon, Jan 11

sivachandra committed rGaefeb5f136e7: [libc][NFC] Make __support/common.h an in tree header. (authored by sivachandra).
[libc][NFC] Make __support/common.h an in tree header.
Mon, Jan 11, 1:11 PM
sivachandra closed D94445: [libc][NFC] Make __support/common.h an in tree header..
Mon, Jan 11, 1:11 PM · Restricted Project
sivachandra requested review of D94445: [libc][NFC] Make __support/common.h an in tree header..
Mon, Jan 11, 1:04 PM · Restricted Project

Fri, Jan 8

sivachandra accepted D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

Accepting now so that we can start our 3 step approach to arrive at the final state @mcgrathr proposed.

Fri, Jan 8, 3:37 PM · Restricted Project
sivachandra added inline comments to D94195: [libc] Switch to use a macro which does not insert a section for every libc function..
Fri, Jan 8, 3:20 PM · Restricted Project

Thu, Jan 7

sivachandra added inline comments to D94195: [libc] Switch to use a macro which does not insert a section for every libc function..
Thu, Jan 7, 4:36 PM · Restricted Project

Wed, Jan 6

sivachandra added a comment to D93195: [libc] Add memmove implementation..

Sorry for the delay. And yes, you did the right thing, @gchatelet is the best reviewer for this. Overall, this LGTM, but I prefer @gchatelet to approve it.

Wed, Jan 6, 7:25 PM · Restricted Project
sivachandra committed rGf9e858f5fd74: [libc] Use a wrapper for rand instead of calling std::rand in fma tests. (authored by sivachandra).
[libc] Use a wrapper for rand instead of calling std::rand in fma tests.
Wed, Jan 6, 3:08 PM
sivachandra closed D94198: [libc] Use a wrapper for rand instead of calling std::rand in fma tests..
Wed, Jan 6, 3:08 PM · Restricted Project
sivachandra added inline comments to D94195: [libc] Switch to use a macro which does not insert a section for every libc function..
Wed, Jan 6, 2:51 PM · Restricted Project
sivachandra requested review of D94198: [libc] Use a wrapper for rand instead of calling std::rand in fma tests..
Wed, Jan 6, 2:43 PM · Restricted Project
sivachandra accepted D94018: [libc] Add implementation of fmaf..
Wed, Jan 6, 9:23 AM · Restricted Project

Tue, Jan 5

sivachandra committed rG7f7b0dc4e15f: [libc] Add implementations of nextafter[f|l] functions. (authored by sivachandra).
[libc] Add implementations of nextafter[f|l] functions.
Tue, Jan 5, 10:33 PM
sivachandra closed D94109: [libc] Add implementations of nextafter[f|l] functions..
Tue, Jan 5, 10:32 PM · Restricted Project
sivachandra committed rG993d8ac5cb93: [libc] Add implementations of nearbyint[f|l]. (authored by sivachandra).
[libc] Add implementations of nearbyint[f|l].
Tue, Jan 5, 9:51 PM
sivachandra closed D94112: [libc] Add implementations of nearbyint[f|l]..
Tue, Jan 5, 9:51 PM · Restricted Project
sivachandra updated the diff for D94109: [libc] Add implementations of nextafter[f|l] functions..

Address comments.

Tue, Jan 5, 6:05 PM · Restricted Project
sivachandra updated the diff for D94109: [libc] Add implementations of nextafter[f|l] functions..

Add nextafter* to the list of aarch64 entrypoints.

Tue, Jan 5, 12:52 PM · Restricted Project
sivachandra requested review of D94112: [libc] Add implementations of nearbyint[f|l]..
Tue, Jan 5, 12:51 PM · Restricted Project
sivachandra updated the diff for D94109: [libc] Add implementations of nextafter[f|l] functions..

Add test source file missed previously.

Tue, Jan 5, 12:34 PM · Restricted Project
sivachandra updated the diff for D94109: [libc] Add implementations of nextafter[f|l] functions..

Add a TODO about raising floating point exceptions in a later pass.

Tue, Jan 5, 12:06 PM · Restricted Project
sivachandra requested review of D94109: [libc] Add implementations of nextafter[f|l] functions..
Tue, Jan 5, 12:03 PM · Restricted Project
sivachandra added inline comments to D94018: [libc] Add implementation of fmaf..
Tue, Jan 5, 11:57 AM · Restricted Project

Wed, Dec 30

sivachandra committed rGcc07d5251144: [libc][NFC] Use ASSERT_FP_EQ to compare nan values in tests. (authored by sivachandra).
[libc][NFC] Use ASSERT_FP_EQ to compare nan values in tests.
Wed, Dec 30, 1:07 PM

Tue, Dec 29

sivachandra committed rGff6fd3855244: [libc] Add implementations of rounding functions which depend rounding mode. (authored by sivachandra).
[libc] Add implementations of rounding functions which depend rounding mode.
Tue, Dec 29, 10:22 PM
sivachandra closed D93889: [libc] Add implementations of rounding functions which depend rounding mode..
Tue, Dec 29, 10:22 PM · Restricted Project
sivachandra requested review of D93889: [libc] Add implementations of rounding functions which depend rounding mode..
Tue, Dec 29, 12:28 AM · Restricted Project

Dec 18 2020

sivachandra added a reverting change for rG352cba2441c6: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h: rG2d9ae1d21789: [libc][NFC] Use `#include <math.h>` in utils/FPUtil/ManipulationFunctions.h..
Dec 18 2020, 12:07 AM
sivachandra committed rG2d9ae1d21789: [libc][NFC] Use `#include <math.h>` in utils/FPUtil/ManipulationFunctions.h. (authored by sivachandra).
[libc][NFC] Use `#include <math.h>` in utils/FPUtil/ManipulationFunctions.h.
Dec 18 2020, 12:07 AM

Dec 17 2020

sivachandra committed rGd599ed49b355: [libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests. (authored by sivachandra).
[libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.
Dec 17 2020, 11:19 PM
sivachandra committed rGe1a5b234ef94: [libc][Obvious] Fix typo is wrappergen unittest. (authored by sivachandra).
[libc][Obvious] Fix typo is wrappergen unittest.
Dec 17 2020, 9:15 AM
sivachandra committed rGbf03eba1f99b: [libc] Refactor WrapperGen to make the flow cleaner. (authored by sivachandra).
[libc] Refactor WrapperGen to make the flow cleaner.
Dec 17 2020, 8:57 AM
sivachandra closed D93417: [libc] Refactor WrapperGen to make the flow cleaner..
Dec 17 2020, 8:57 AM · Restricted Project
sivachandra added a comment to D93417: [libc] Refactor WrapperGen to make the flow cleaner..

Addressed comments.

Dec 17 2020, 8:56 AM · Restricted Project
sivachandra updated the diff for D93417: [libc] Refactor WrapperGen to make the flow cleaner..

Fix nits.

Dec 17 2020, 8:55 AM · Restricted Project
sivachandra accepted D93463: [libc] Add python3 to libc buildbot depedencies..
Dec 17 2020, 8:50 AM · Restricted Project
sivachandra added a comment to D93210: [libc] revamp memory function benchmark.

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

Dec 17 2020, 8:21 AM · Restricted Project

Dec 16 2020

sivachandra requested review of D93417: [libc] Refactor WrapperGen to make the flow cleaner..
Dec 16 2020, 1:07 PM · Restricted Project

Dec 15 2020

sivachandra committed rG0524da67b448: [libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests. (authored by sivachandra).
[libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.
Dec 15 2020, 11:50 PM
sivachandra committed rGf66cf13d5d0b: [libc][NFC] Rename global `nan` in tests to `aNaN`. (authored by sivachandra).
[libc][NFC] Rename global `nan` in tests to `aNaN`.
Dec 15 2020, 10:40 PM
sivachandra committed rGcee1e7d14f46: [libc][NFC][Obvious] Remove few unnecessary #include directives in tests. (authored by sivachandra).
[libc][NFC][Obvious] Remove few unnecessary #include directives in tests.
Dec 15 2020, 9:57 PM

Dec 14 2020

sivachandra committed rGf0cd6aa614f4: [libc] Add remainder[f|l] and remquo[f|l] to the list of aarch64 entrypoints. (authored by sivachandra).
[libc] Add remainder[f|l] and remquo[f|l] to the list of aarch64 entrypoints.
Dec 14 2020, 6:07 PM
sivachandra committed rGb1067a9b3c8e: [libc][NFC] Skip adding dummy targets for skipped unit tests. (authored by sivachandra).
[libc][NFC] Skip adding dummy targets for skipped unit tests.
Dec 14 2020, 5:53 PM
sivachandra committed rGb266c818e7cb: [libc][Obvious] Mark functions in DummyFEnv.h as static inline. (authored by sivachandra).
[libc][Obvious] Mark functions in DummyFEnv.h as static inline.
Dec 14 2020, 5:14 PM
sivachandra committed rG9ad2091e78eb: [libc][Obvious] Include <fenv.h> from DummyFenv.h. (authored by sivachandra).
[libc][Obvious] Include <fenv.h> from DummyFenv.h.
Dec 14 2020, 8:52 AM
sivachandra added inline comments to D82134: [libc] Add strcmp implementation..
Dec 14 2020, 7:35 AM · Restricted Project

Dec 11 2020

sivachandra committed rG9ab6c1a99f82: [libc] Let wrappergen pick LLVM libc mangled name from aliasee file. (authored by sivachandra).
[libc] Let wrappergen pick LLVM libc mangled name from aliasee file.
Dec 11 2020, 2:33 PM
sivachandra closed D93142: [libc] Let wrappergen pick LLVM libc mangled name from aliasee file..
Dec 11 2020, 2:33 PM · Restricted Project
sivachandra updated the summary of D93142: [libc] Let wrappergen pick LLVM libc mangled name from aliasee file..
Dec 11 2020, 2:23 PM · Restricted Project
sivachandra requested review of D93142: [libc] Let wrappergen pick LLVM libc mangled name from aliasee file..
Dec 11 2020, 2:15 PM · Restricted Project
sivachandra committed rG7aeb3804c46c: [libc] Add implementations of lround[f|l] and llround[f|l]. (authored by sivachandra).
[libc] Add implementations of lround[f|l] and llround[f|l].
Dec 11 2020, 11:13 AM
sivachandra closed D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..
Dec 11 2020, 11:12 AM · Restricted Project

Dec 10 2020

sivachandra updated the diff for D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..

Return max integer or min integer value on overflow.

Dec 10 2020, 2:41 PM · Restricted Project
sivachandra added a reviewer for D93009: [libc] Add memcmp implementation.: gchatelet.
Dec 10 2020, 1:08 AM · Restricted Project
sivachandra updated subscribers of D93009: [libc] Add memcmp implementation..

This simple implementation is probably OK to start with. But, I will add @gchatelet as he might also be having plans to add optimized versions of memcmp.

Dec 10 2020, 1:08 AM · Restricted Project
sivachandra updated the diff for D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..

Add an explicit overflow test.

Dec 10 2020, 1:07 AM · Restricted Project
sivachandra updated the diff for D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..

Remove aarch64 entrypoints as we do not yet have exception support for aarch64.

Dec 10 2020, 12:22 AM · Restricted Project
sivachandra requested review of D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..
Dec 10 2020, 12:18 AM · Restricted Project
sivachandra accepted D92626: [libc] Add [l|ll]abs implementation..
Dec 10 2020, 12:17 AM · Restricted Project

Dec 8 2020

sivachandra committed rGab3cbe4bc0d9: [libc] Raise x87 exceptions by synchronizing with "fwait". (authored by sivachandra).
[libc] Raise x87 exceptions by synchronizing with "fwait".
Dec 8 2020, 1:17 PM
sivachandra closed D92821: [libc] Raise x87 exceptions by synchronizing with "fwait"..
Dec 8 2020, 1:16 PM · Restricted Project
sivachandra updated the diff for D92821: [libc] Raise x87 exceptions by synchronizing with "fwait"..

Fix the comment as suggested in the review comment.

Dec 8 2020, 12:45 PM · Restricted Project
sivachandra requested review of D92821: [libc] Raise x87 exceptions by synchronizing with "fwait"..
Dec 8 2020, 12:27 AM · Restricted Project

Dec 4 2020

sivachandra added a comment to D92626: [libc] Add [l|ll]abs implementation..

Forgot to mention couple of nits.

Dec 4 2020, 10:31 AM · Restricted Project
sivachandra accepted D92626: [libc] Add [l|ll]abs implementation..

Thanks for the patch. Feel free to do labs and llabs as well. You can drive all of them off of a C++ template implementation.

Dec 4 2020, 10:31 AM · Restricted Project

Dec 3 2020

sivachandra accepted D92137: [libc] add tests to WrapperGen.

I think we can chisel this out to be a little more cleaner but we can do it in a later pass.

Dec 3 2020, 3:15 PM · Restricted Project
sivachandra committed rG3a375125b01c: [libc][NFC] Remove dependence on xmmintrin.h to read/write MXCSR. (authored by sivachandra).
[libc][NFC] Remove dependence on xmmintrin.h to read/write MXCSR.
Dec 3 2020, 1:50 PM
sivachandra committed rG4fff2a7e8964: [libc] Add simple x86_64 floating point exception and rounding mode support. (authored by sivachandra).
[libc] Add simple x86_64 floating point exception and rounding mode support.
Dec 3 2020, 12:55 PM
sivachandra closed D92546: [libc] Add simple x86_64 floating point exception and rounding mode support..
Dec 3 2020, 12:55 PM · Restricted Project
sivachandra requested review of D92546: [libc] Add simple x86_64 floating point exception and rounding mode support..
Dec 3 2020, 12:02 AM · Restricted Project

Dec 2 2020

sivachandra committed rG19c3894f9436: [libc] Fix couple of corner cases in remquo. (authored by sivachandra).
[libc] Fix couple of corner cases in remquo.
Dec 2 2020, 11:49 AM
sivachandra closed D92353: [libc] Fix couple of corner cases in remquo..
Dec 2 2020, 11:49 AM · Restricted Project
sivachandra added inline comments to D92137: [libc] add tests to WrapperGen.
Dec 2 2020, 8:28 AM · Restricted Project

Nov 30 2020

sivachandra requested review of D92353: [libc] Fix couple of corner cases in remquo..
Nov 30 2020, 4:08 PM · Restricted Project
sivachandra added inline comments to D92137: [libc] add tests to WrapperGen.
Nov 30 2020, 4:05 PM · Restricted Project
sivachandra accepted D91831: [libc] Add implementation of hypot..

Just realized I missed selecting accept.

Nov 30 2020, 3:49 PM · Restricted Project
sivachandra added inline comments to D92137: [libc] add tests to WrapperGen.
Nov 30 2020, 12:50 PM · Restricted Project
sivachandra accepted D91551: Initial commit of mktime..
Nov 30 2020, 10:26 AM · Restricted Project
sivachandra added a comment to D91551: Initial commit of mktime..

Mostly LGTM. I have left a few nits along with a not-a-nit comment.

Nov 30 2020, 7:55 AM · Restricted Project

Nov 29 2020

sivachandra added a reviewer for D92236: [LIBC] Add optimized memcpy routine for AArch64: gchatelet.
Nov 29 2020, 8:48 PM · Restricted Project
sivachandra updated subscribers of D92236: [LIBC] Add optimized memcpy routine for AArch64.

Thanks for the patch. I am adding @gchatelet as a reviewer as he is the current owner/maintainer of the mem* functions.

Nov 29 2020, 8:48 PM · Restricted Project