Page MenuHomePhabricator

sivachandra (Siva Chandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:30 AM (371 w, 1 d)

Recent Activity

Today

sivachandra committed rGa5a79f69d626: [libc] Add a .clang-tidy file for the toplevel libc directory. (authored by sivachandra).
[libc] Add a .clang-tidy file for the toplevel libc directory.
Wed, Dec 8, 4:20 PM
sivachandra closed D115405: [libc] Add a .clang-tidy file for the toplevel libc directory..
Wed, Dec 8, 4:19 PM · Restricted Project
sivachandra updated the diff for D115405: [libc] Add a .clang-tidy file for the toplevel libc directory..

Address comment.

Wed, Dec 8, 4:10 PM · Restricted Project
sivachandra requested review of D115405: [libc] Add a .clang-tidy file for the toplevel libc directory..
Wed, Dec 8, 3:50 PM · Restricted Project
sivachandra committed rG45927444e7ba: [libc][Obvious] Fix variable naming in the generic sqrt implementations. (authored by sivachandra).
[libc][Obvious] Fix variable naming in the generic sqrt implementations.
Wed, Dec 8, 12:02 PM

Mon, Dec 6

sivachandra accepted D114301: [libc] update tidy rules to fix variable formatting.
Mon, Dec 6, 10:06 PM · Restricted Project
sivachandra added inline comments to D114301: [libc] update tidy rules to fix variable formatting.
Mon, Dec 6, 3:01 PM · Restricted Project
sivachandra accepted D114302: [libc] apply new lint rules.

Accepting now. With a change this large, I am sure some of the corners will go in unpolished. We can fix them up as we notice in follow up patches. As long as we have the correct clang-tidy rules checked in, we are good to go.

Mon, Dec 6, 2:23 PM · Restricted Project

Fri, Dec 3

sivachandra added inline comments to D115082: [libc][NFC] refactor math implementations.
Fri, Dec 3, 8:00 PM · Restricted Project
sivachandra accepted D115034: [libc] Select FPUtils implementations via code instead of build.

Please wait for lntue as he is also planning some refactoring around FMA.h.

Fri, Dec 3, 5:19 AM · Restricted Project
sivachandra accepted D114726: [libc] Fix bugs with negative and mixed normal/denormal inputs in hypot implementation..
Fri, Dec 3, 5:12 AM · Restricted Project
sivachandra added a reviewer for D115034: [libc] Select FPUtils implementations via code instead of build: lntue.
Fri, Dec 3, 5:09 AM · Restricted Project

Thu, Dec 2

sivachandra accepted D114878: [libc] Fix a bug in MPFRUtils making ULP values off by 2^(-mantissaWidth)..

Thanks for catching! My mistake.

Thu, Dec 2, 12:57 AM · Restricted Project

Wed, Dec 1

sivachandra added a reviewer for D114637: [libc] Optimized version of memmove: sivachandra.
Wed, Dec 1, 11:08 AM · Restricted Project
sivachandra added inline comments to D114637: [libc] Optimized version of memmove.
Wed, Dec 1, 11:08 AM · Restricted Project

Tue, Nov 30

sivachandra added a comment to D114432: [libc] Add a reasonably optimized version for bcmp.

This is broken for aarch64: https://lab.llvm.org/buildbot/#/builders/138/builds/14620.
In the case of aarch64, it looks like _64 is defined only for memset.

Tue, Nov 30, 11:20 PM · Restricted Project

Mon, Nov 29

sivachandra added a comment to D114712: [libc] Bazel overlay for libc.

Overall LGTM but one question: Will the file libc/BUILD.bazel interfere with downstream BUILD files?

Mon, Nov 29, 8:59 AM · Restricted Project
sivachandra accepted D114694: [libc] Add memmove benchmarks.
Mon, Nov 29, 8:54 AM · Restricted Project
sivachandra added a comment to D114302: [libc] apply new lint rules.

In general looks good. Please ping after updating the commit message and fixing the broken tests.

Mon, Nov 29, 8:50 AM · Restricted Project
sivachandra accepted D114432: [libc] Add a reasonably optimized version for bcmp.

No objections from my side.

Mon, Nov 29, 8:43 AM · Restricted Project

Mon, Nov 22

sivachandra added inline comments to D114300: [libc] Make string entrypoints mutualy exclusive..
Mon, Nov 22, 12:36 PM · Restricted Project
sivachandra updated the diff for D114300: [libc] Make string entrypoints mutualy exclusive..

Address comments.

Mon, Nov 22, 10:23 AM · Restricted Project

Fri, Nov 19

sivachandra requested review of D114300: [libc] Make string entrypoints mutualy exclusive..
Fri, Nov 19, 4:47 PM · Restricted Project
sivachandra committed rGd9bbad277c44: [libc][Obvious][NFC] A bunch of cosmetic cleanup. (authored by sivachandra).
[libc][Obvious][NFC] A bunch of cosmetic cleanup.
Fri, Nov 19, 9:04 AM
sivachandra added a comment to D114236: [libc] Fix 64-bit ARM support and header includes.

Thanks for catching the build problems with exhaustive tests. They have bit rotted a bit because we don't run them on any bot.

Fri, Nov 19, 8:02 AM · Restricted Project

Tue, Nov 16

sivachandra added a comment to D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party.

Oh! Huh, missed that. Probably my ninja check-all didn’t build the
benchmarks. I’ll patch shortly. Sorry for the lapse.

Tue, Nov 16, 4:36 PM · Restricted Project, Restricted Project, Restricted Project
sivachandra committed rG39e9f5d3685f: [libc][NFC][Obvious] Fix the benchmarks after the switch to llvm/third-party (authored by sivachandra).
[libc][NFC][Obvious] Fix the benchmarks after the switch to llvm/third-party
Tue, Nov 16, 2:32 PM
sivachandra added a comment to D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party.

FYI: The libcxx copy and llvm/utils copy were not identical. So, the libc benchmarks are currently broken because of that. I have added an inline comment to show the single difference we are seeing. We can fix forward.

Tue, Nov 16, 2:11 PM · Restricted Project, Restricted Project, Restricted Project
sivachandra accepted D113946: [libc][clang-tidy] fix namespace check for externals.

For libc requirements, LGTM. Please wait for @aaron.ballman for stamping the clang-tidy parts.

Tue, Nov 16, 11:38 AM · Restricted Project, Restricted Project

Mon, Nov 15

sivachandra added inline comments to D113946: [libc][clang-tidy] fix namespace check for externals.
Mon, Nov 15, 10:29 PM · Restricted Project, Restricted Project

Fri, Nov 12

sivachandra accepted D113710: [libc] add basic strtold implementation.
Fri, Nov 12, 4:54 PM · Restricted Project
sivachandra accepted D113790: [libc] fix strtof/d/ld NaN parsing.

There is a wide-spread violation of "no braces for single statement blocks."

Fri, Nov 12, 4:39 PM · Restricted Project

Wed, Nov 10

sivachandra accepted D113626: [libc] tweak strtof errno behavior.
Wed, Nov 10, 8:34 PM · Restricted Project
sivachandra accepted D113625: [libc] clean up FPUtil long doubles.
Wed, Nov 10, 8:33 PM · Restricted Project

Nov 8 2021

sivachandra accepted D113260: [libc][benchmark] add memmove to size distribution, also update other distributions.

Add a new line to all the .csv files if it is OK?

Nov 8 2021, 3:43 PM · Restricted Project

Nov 4 2021

sivachandra added inline comments to D113036: [libc] refactor atof string parsing.
Nov 4 2021, 11:58 PM · Restricted Project

Nov 3 2021

sivachandra added a comment to D113097: [libc][NFC] Allow memcpy to be inlined.

Any reason why you have chosen .inl suffix instead of treating them as normal header files? IDEs and other tools are used to .h files (for example Phabricator's UI does not do syntax highlighting).

Nov 3 2021, 12:41 PM · Restricted Project
sivachandra accepted D113061: [libc][NFC] rename str_conv_utils to str_to_integer.
Nov 3 2021, 12:12 AM · Restricted Project
sivachandra accepted D111913: [libc] add stpcpy and stpncpy.
Nov 3 2021, 12:05 AM · Restricted Project

Oct 29 2021

sivachandra accepted D112846: [libc] add strndup.

The license headers are messed up because of clang-tidy may be. But, LGTM otherwise.

Oct 29 2021, 2:59 PM · Restricted Project
sivachandra accepted D112818: [libc] Add more robust compile time architecture detection.

Thanks for the nice cleanup.

Oct 29 2021, 10:44 AM · Restricted Project
sivachandra committed rG6c3f53c7ba3c: [libc][NFC] Move test related pieces from FPUtil to util/UnitTest. (authored by sivachandra).
[libc][NFC] Move test related pieces from FPUtil to util/UnitTest.
Oct 29 2021, 8:37 AM
sivachandra closed D112673: [libc][NFC] Move test related pieces from FPUtil to util/UnitTest..
Oct 29 2021, 8:37 AM · Restricted Project

Oct 28 2021

sivachandra accepted D112580: [libc] add fast path to string to float conversion.
Oct 28 2021, 11:44 PM · Restricted Project
sivachandra committed rGf362aea42d29: [libc][NFC] Move utils/CPP to src/__support/CPP. (authored by sivachandra).
[libc][NFC] Move utils/CPP to src/__support/CPP.
Oct 28 2021, 8:50 AM
sivachandra closed D112653: [libc][NFC] Move utils/CPP to src/__support/CPP..
Oct 28 2021, 8:50 AM · Restricted Project

Oct 27 2021

sivachandra added inline comments to D112580: [libc] add fast path to string to float conversion.
Oct 27 2021, 11:39 PM · Restricted Project
sivachandra updated the diff for D112653: [libc][NFC] Move utils/CPP to src/__support/CPP..

Fix header guards.

Oct 27 2021, 8:41 PM · Restricted Project
sivachandra updated the diff for D112673: [libc][NFC] Move test related pieces from FPUtil to util/UnitTest..

Fix header guards.

Oct 27 2021, 8:37 PM · Restricted Project
sivachandra requested review of D112673: [libc][NFC] Move test related pieces from FPUtil to util/UnitTest..
Oct 27 2021, 4:02 PM · Restricted Project
sivachandra retitled D112653: [libc][NFC] Move utils/CPP to src/__support/CPP. from [libc] Move utils/CPP to src/__support/CPP. to [libc][NFC] Move utils/CPP to src/__support/CPP..
Oct 27 2021, 12:41 PM · Restricted Project
sivachandra requested review of D112653: [libc][NFC] Move utils/CPP to src/__support/CPP..
Oct 27 2021, 12:39 PM · Restricted Project

Oct 26 2021

sivachandra accepted D112104: [libc] add malloc funcs as external entrypoints.
Oct 26 2021, 11:21 AM · Restricted Project

Oct 25 2021

sivachandra accepted D111584: [libc] add strdup implementation.
Oct 25 2021, 9:38 PM · Restricted Project
sivachandra added a comment to D112104: [libc] add malloc funcs as external entrypoints.

This is almost what I had in mind. It is still "almost" because of a question I left inline.

Oct 25 2021, 9:36 PM · Restricted Project

Oct 21 2021

sivachandra accepted D112176: [libc] fix strtol returning the wrong length.
Oct 21 2021, 9:13 PM · Restricted Project
sivachandra added a comment to D112104: [libc] add malloc funcs as external entrypoints.

I think I remember the original plan in this case was to use redirectors. We have add_redirector_object, but I don't think it has ever been used.

Oct 21 2021, 8:48 AM · Restricted Project

Oct 20 2021

sivachandra added inline comments to D112176: [libc] fix strtol returning the wrong length.
Oct 20 2021, 11:13 PM · Restricted Project
sivachandra added a comment to D112104: [libc] add malloc funcs as external entrypoints.

While this is OK logically, I would like to take a step back and design the external entrypoint concept in a more cleaner fashion. With this change as is, there will be an external entrypoint rule and there is also an EXT_DEPS option to add_entrypoint_library. We should unify these. What I mean is the following steps:

Oct 20 2021, 10:23 PM · Restricted Project
sivachandra added a comment to D112188: [libc] add strtoq and strtouq.

strtoq and strtouq are deprecated functions from FreeBSD. Should we add them at all?

Oct 20 2021, 9:28 PM · Restricted Project
sivachandra added inline comments to D112176: [libc] fix strtol returning the wrong length.
Oct 20 2021, 1:53 PM · Restricted Project

Oct 19 2021

sivachandra added a comment to D111584: [libc] add strdup implementation.

Can we separate the CMake and allocator changes into a different patch? Rest of the patch is OK but will accept after we separate.

Oct 19 2021, 3:09 PM · Restricted Project

Oct 17 2021

sivachandra added inline comments to D111583: [libc] Add strncat and fix strcat.
Oct 17 2021, 10:23 PM · Restricted Project
sivachandra added inline comments to D111913: [libc] add stpcpy and stpncpy.
Oct 17 2021, 10:13 PM · Restricted Project
sivachandra added inline comments to D111584: [libc] add strdup implementation.
Oct 17 2021, 9:52 PM · Restricted Project

Oct 4 2021

sivachandra accepted D110454: [libc][NFC] Add supporting class for atof implementation.
Oct 4 2021, 12:35 PM · Restricted Project
sivachandra accepted D110454: [libc][NFC] Add supporting class for atof implementation.
Oct 4 2021, 10:52 AM · Restricted Project

Sep 28 2021

sivachandra accepted D110643: [libc] Add support for 128 bit ints in limits.h.

LGTM

Sep 28 2021, 4:41 PM · Restricted Project
sivachandra committed rG8379fc4a53cf: [libc] Add implementations of the C standard condition variable functions. (authored by sivachandra).
[libc] Add implementations of the C standard condition variable functions.
Sep 28 2021, 2:19 PM
sivachandra closed D108948: [libc] Add implementations of the C standard condition variable functions..
Sep 28 2021, 2:19 PM · Restricted Project
sivachandra accepted D110643: [libc] Add support for 128 bit ints in limits.h.
Sep 28 2021, 2:09 PM · Restricted Project
sivachandra added inline comments to D108948: [libc] Add implementations of the C standard condition variable functions..
Sep 28 2021, 1:30 PM · Restricted Project
sivachandra accepted D110643: [libc] Add support for 128 bit ints in limits.h.
Sep 28 2021, 1:13 PM · Restricted Project
sivachandra added inline comments to D110643: [libc] Add support for 128 bit ints in limits.h.
Sep 28 2021, 11:40 AM · Restricted Project
sivachandra committed rG5c3c716bb1f5: [libc] Add FE_DFL_ENV and handle it in fesetenv. (authored by sivachandra).
[libc] Add FE_DFL_ENV and handle it in fesetenv.
Sep 28 2021, 11:10 AM
sivachandra closed D110611: [libc] Add FE_DFL_ENV and handle it in fesetenv..
Sep 28 2021, 11:10 AM · Restricted Project
sivachandra accepted D110581: [libc][NFC] Make strchr and strrchr more consistent.
Sep 28 2021, 10:11 AM · Restricted Project

Sep 27 2021

sivachandra requested review of D110611: [libc] Add FE_DFL_ENV and handle it in fesetenv..
Sep 27 2021, 11:54 PM · Restricted Project
sivachandra added inline comments to D110581: [libc][NFC] Make strchr and strrchr more consistent.
Sep 27 2021, 10:29 PM · Restricted Project
sivachandra added inline comments to D110581: [libc][NFC] Make strchr and strrchr more consistent.
Sep 27 2021, 10:26 PM · Restricted Project

Sep 24 2021

sivachandra committed rG5eb6b8272931: [libc] Add an implementation of qsort. (authored by sivachandra).
[libc] Add an implementation of qsort.
Sep 24 2021, 12:23 PM
sivachandra closed D110382: [libc] Add an implementation of qsort..
Sep 24 2021, 12:23 PM · Restricted Project
sivachandra updated the diff for D110382: [libc] Add an implementation of qsort..

Move internal pieces into an internal namespace.

Sep 24 2021, 12:17 PM · Restricted Project

Sep 23 2021

sivachandra updated the diff for D110382: [libc] Add an implementation of qsort..

Add couple of more tests.

Sep 23 2021, 11:04 PM · Restricted Project
sivachandra requested review of D110382: [libc] Add an implementation of qsort..
Sep 23 2021, 10:48 PM · Restricted Project

Sep 22 2021

sivachandra committed rG32a50078657d: [libc] Add an implementation of bsearch. (authored by sivachandra).
[libc] Add an implementation of bsearch.
Sep 22 2021, 9:37 AM
sivachandra closed D110222: [libc] Add an implementation of bsearch..
Sep 22 2021, 9:37 AM · Restricted Project
sivachandra added inline comments to D110222: [libc] Add an implementation of bsearch..
Sep 22 2021, 9:10 AM · Restricted Project
sivachandra updated the diff for D110222: [libc] Add an implementation of bsearch..

Remove a copy-paste error.

Sep 22 2021, 9:06 AM · Restricted Project

Sep 21 2021

sivachandra requested review of D110222: [libc] Add an implementation of bsearch..
Sep 21 2021, 11:23 PM · Restricted Project

Sep 19 2021

sivachandra committed rGf5b8f1247cd9: [libc][obvious] Add inttypes.h and stdlib.h as deps to *div functions. (authored by sivachandra).
[libc][obvious] Add inttypes.h and stdlib.h as deps to *div functions.
Sep 19 2021, 10:56 PM
sivachandra committed rG5252aa2981ba: [libc][obvious] Make *abs and *div functions buildable in default mode. (authored by sivachandra).
[libc][obvious] Make *abs and *div functions buildable in default mode.
Sep 19 2021, 10:46 PM
sivachandra committed rG74670e79b0a0: [libc] Add implementations of div, ldiv, lldiv and imaxdiv. (authored by sivachandra).
[libc] Add implementations of div, ldiv, lldiv and imaxdiv.
Sep 19 2021, 9:52 PM
sivachandra closed D109952: [libc] Add implementations of div, ldiv, lldiv and imaxdiv..
Sep 19 2021, 9:51 PM · Restricted Project
sivachandra updated the diff for D109952: [libc] Add implementations of div, ldiv, lldiv and imaxdiv..

Address comments

Sep 19 2021, 9:50 PM · Restricted Project

Sep 17 2021

sivachandra retitled D109952: [libc] Add implementations of div, ldiv, lldiv and imaxdiv. from [libc] Add implementation s of div, ldiv, lldiv and imaxdiv. to [libc] Add implementations of div, ldiv, lldiv and imaxdiv..
Sep 17 2021, 12:44 AM · Restricted Project
sivachandra requested review of D109952: [libc] Add implementations of div, ldiv, lldiv and imaxdiv..
Sep 17 2021, 12:39 AM · Restricted Project

Sep 16 2021

sivachandra added a comment to D109261: [libc] add atof, strtof and strtod.

Just did a quick pass. Will do a detailed review when it is final.

Sep 16 2021, 11:51 PM · Restricted Project

Sep 10 2021

sivachandra committed rG0da5ac1a7537: [libc] Add extension functions fedisableexcept, feenableexcept and fegetexcept. (authored by sivachandra).
[libc] Add extension functions fedisableexcept, feenableexcept and fegetexcept.
Sep 10 2021, 11:45 AM
sivachandra closed D109613: [libc] Add extension functions fedisableexcept, feenableexcept and fegetexcept..
Sep 10 2021, 11:45 AM · Restricted Project