- User Since
- May 26 2014, 12:49 PM (335 w, 2 h)
Tue, Oct 13
Tue, Oct 6
Mon, Oct 5
Sun, Oct 4
Sep 22 2020
That's.... Pretty strange. I was pretty sure I landed it. Feel free to
do this on my behalf. Sorry about that.
Aug 3 2020
I went ahead and committed this. Let's see if I break anything, it's been a long time since I've committed a patch and I haven't committed anything since the git switchover :D
Perhaps now you ;-)
I'm not sure the first branch in the new code adds any value.
The first branch is important because lit_tools_path is up to the individual local config to define. In other words, if the user does not specifically write config.lit_tools_path = Foo/Bar then this will be undefined and they'll get strange errors. In all LLVM cases, the configs do this, and this knowledge has been propagated across all LLVM lit configs by way of copy/paste. But it's a silent / undocumented requirement that caused me some confusion until I tracked it down. So it seems better to be resilient in the case of it not being there.
Jul 23 2020
Jul 22 2020
Mar 6 2020
If the current listed reviewers on this patch are not the best people for reviewing this, would one of them please suggest a more appropriate reviewer so we can get some traction on this?
Jan 27 2020
Adding a ping since it's been a week with no additional feedback for the author.
Dec 6 2019
Dec 2 2019
Nov 22 2019
Addressed suggestions from @Eugene.Zelenko
Nov 21 2019
- Updated documentation for this check
- Incorporated additional suggestions from @aaron.ballman
- Fixed an invalid transformation that was generated when binding a member function and the second argument of bind (the object pointer) was a placeholder. Test is added for this case as well.
- Fixed an invalid transformation that was generated when a placeholder index was entirely skipped, as in the call std::bind(add, 0, _2); In this case we need to generate an unused placeholder in the first position of the resulting lambda's parameter list.
- Added a clang-tidy option PermissiveParameterList which appends auto&&... to the end of every lambda's placeholder list. This is necessary in some situations to prevent clang-tidy from applying a fixit that causes the code to no longer compile.
Nov 19 2019
Forgot to remove spurious llvm:: namespace qualifications.
Updated with suggestions from @aaron.ballman
Nov 18 2019
Nov 17 2019
I have a more comprehensive version of this patch that I'll upload separately.
Nov 12 2019
Does this change crash recovery semantics in any meaningful way? Will we still be able to get stack traces on all platforms when the compiler crashes?
Nov 6 2019
Minor cleanup -- moved isFixitSupported logic to its own function.
Nov 5 2019
Oct 10 2019
In Windows you just write a Python script to do this, and this works everywhere, not just on one platform or the other, so bash isn't even necessary and Python is easy to write so I wouldn't really say it's "even harder". If you google for run-clang-format.py you'll find a script that actually branches out and does this in parallel. There's a lot of logic and smarts you could bake into an external tool which can then be used for many different programs, not just clang-format.
Planning to commit this this afternoon unless someone has objections.
Oct 9 2019
Rebased this onto tip of trunk. I'm *finally* going to submit this.
Oct 7 2019
Sep 24 2019
What's the status of this patch, out of curiosity? It doesn't seem there were any objections to the original idea, just that nobody with ownership over clang-format is still actively participating in the review.
Sep 4 2019
Aug 26 2019
Finally got around to trying to commit this.
Aug 19 2019
Ugh nevermind, you can't because of the binary files. Fineeeeee.
I know it's super lame to request this, but would one of you mind submitting on my behalf? I don't have SVN installed and it seems like git llvm push still requires it (unless there is a more modern workflow that doesn't require SVN anymore). If I find myself submitting more and more patches then I'll bite the bullet.
Aug 13 2019
No objections from me on the wording of the layering portion
Jul 16 2019
Apr 29 2019
Apr 19 2019
I just built against trunk with VS 2019 and ran into this exact issue. llvm-tblgen had no command line options. Are more fixes still in the pipeline or was this thought to be sufficient?
Apr 12 2019
Apr 11 2019
Apr 10 2019
Apr 9 2019
Apr 8 2019
Apr 5 2019
Apr 3 2019
Also remove LLDBTriggerable.py
Add the scheduler back but remove the android builder only.