Object: add IMAGE_FILE_MACHINE_ARM64

[martell]

Summary

Object: add IMAGE_FILE_MACHINE_ARM64

The official specifications state that the value of ARM64 to be 0xAA64
(as per the Microsoft Portable Executable and Common Object Format Specification v8.3).

[majnemer]

It would be nice to add a is64Bit(COFF::MachineTypes) method to COFFObjectFile.h and use it to implement COFFParser::is64Bit and COFFObjectFile::getBytesInAddress.

[martell]

In D11511#212285, @majnemer wrote:

It would be nice to add a is64Bit(COFF::MachineTypes) method to COFFObjectFile.h and use it to implement COFFParser::is64Bit and COFFObjectFile::getBytesInAddress.

Yes I agree that would make sense, I would however like to create that change in a separate differential rather than combining them

[rnk]

Seems like a reasonable test commit

[compnerd]

The change seems fine, but Im not sure what the point of this is. Microsoft has not yet fully provided AArch64 support. This means that anything that we do will be purely speculative.

[martell]

In D11511#213218, @compnerd wrote:

The change seems fine, but Im not sure what the point of this is.

Originally this was just going to be a test commit.

Microsoft has not yet fully provided AArch64 support. This means that anything that we do will be purely speculative.

Yes this is true but we can add support for it in objdump and readobj so that llvm can at least recognize import library files.
End users have a habit of mistakenly using i686 libraries with x86_64 and I feel they will do the same with aarch64 and arm once it is released.
It might be useful to lld if we want to print out a decent error message when they do this.

llvm/trunk/docs/yaml2obj.rst

mapping:
         type: map
         mapping:
           Machine: [ {type: str, enum:
                                  [ IMAGE_FILE_MACHINE_UNKNOWN
                                  , IMAGE_FILE_MACHINE_AM33
                                  , IMAGE_FILE_MACHINE_AMD64
                                  , IMAGE_FILE_MACHINE_ARM
                                  , IMAGE_FILE_MACHINE_ARMNT
+                                 , IMAGE_FILE_MACHINE_ARM64
                                  , IMAGE_FILE_MACHINE_EBC
                                  , IMAGE_FILE_MACHINE_I386
                                  , IMAGE_FILE_MACHINE_IA64
                                  , IMAGE_FILE_MACHINE_M32R
                                  , IMAGE_FILE_MACHINE_MIPS16
                                  , IMAGE_FILE_MACHINE_MIPSFPU
                                  , IMAGE_FILE_MACHINE_MIPSFPU16
                                  , IMAGE_FILE_MACHINE_POWERPC

llvm/trunk/include/llvm/Support/COFF.h

namespace COFF {
   enum MachineTypes {
     MT_Invalid = 0xffff,
 
     IMAGE_FILE_MACHINE_UNKNOWN   = 0x0,
     IMAGE_FILE_MACHINE_AM33      = 0x13,
     IMAGE_FILE_MACHINE_AMD64     = 0x8664,
     IMAGE_FILE_MACHINE_ARM       = 0x1C0,
     IMAGE_FILE_MACHINE_ARMNT     = 0x1C4,
+    IMAGE_FILE_MACHINE_ARM64     = 0xAA64,
     IMAGE_FILE_MACHINE_EBC       = 0xEBC,
     IMAGE_FILE_MACHINE_I386      = 0x14C,
     IMAGE_FILE_MACHINE_IA64      = 0x200,
     IMAGE_FILE_MACHINE_M32R      = 0x9041,
     IMAGE_FILE_MACHINE_MIPS16    = 0x266,
     IMAGE_FILE_MACHINE_MIPSFPU   = 0x366,
     IMAGE_FILE_MACHINE_MIPSFPU16 = 0x466,
     IMAGE_FILE_MACHINE_POWERPC   = 0x1F0,

llvm/trunk/lib/Object/COFFObjectFile.cpp

 StringRef COFFObjectFile::getFileFormatName() const {
   switch(getMachine()) {
   case COFF::IMAGE_FILE_MACHINE_I386:
     return "COFF-i386";
   case COFF::IMAGE_FILE_MACHINE_AMD64:
     return "COFF-x86-64";
   case COFF::IMAGE_FILE_MACHINE_ARMNT:
     return "COFF-ARM";
+  case COFF::IMAGE_FILE_MACHINE_ARM64:
+    return "COFF-ARM64";
   default:
     return "COFF-<unknown arch>";
   }
 }
 
 unsigned COFFObjectFile::getArch() const {
   switch (getMachine()) {
   case COFF::IMAGE_FILE_MACHINE_I386:
     return Triple::x86;
   case COFF::IMAGE_FILE_MACHINE_AMD64:
     return Triple::x86_64;
   case COFF::IMAGE_FILE_MACHINE_ARMNT:
     return Triple::thumb;
+  case COFF::IMAGE_FILE_MACHINE_ARM64:
+    return Triple::aarch64;
   default:
     return Triple::UnknownArch;
   }
 }
 
 iterator_range<import_directory_iterator>
 COFFObjectFile::import_directories() const {
   return make_range(import_directory_begin(), import_directory_end());

llvm/trunk/lib/Object/COFFYAML.cpp

 
 void ScalarEnumerationTraits<COFF::MachineTypes>::enumeration(
     IO &IO, COFF::MachineTypes &Value) {
   ECase(IMAGE_FILE_MACHINE_UNKNOWN);
   ECase(IMAGE_FILE_MACHINE_AM33);
   ECase(IMAGE_FILE_MACHINE_AMD64);
   ECase(IMAGE_FILE_MACHINE_ARM);
   ECase(IMAGE_FILE_MACHINE_ARMNT);
+  ECase(IMAGE_FILE_MACHINE_ARM64);
   ECase(IMAGE_FILE_MACHINE_EBC);
   ECase(IMAGE_FILE_MACHINE_I386);
   ECase(IMAGE_FILE_MACHINE_IA64);
   ECase(IMAGE_FILE_MACHINE_M32R);
   ECase(IMAGE_FILE_MACHINE_MIPS16);
   ECase(IMAGE_FILE_MACHINE_MIPSFPU);
   ECase(IMAGE_FILE_MACHINE_MIPSFPU16);
   ECase(IMAGE_FILE_MACHINE_POWERPC);