Page MenuHomePhabricator

[mlir][spirv] Define spv.ImageDrefGather operation
ClosedPublic

Authored by Weiwei-2021 on Thu, Apr 8, 10:31 AM.

Details

Summary

This patch doesn't support the optional operands of ImageDrefGather. The support of optional operands will be implemented later.

co-authered-by: Alan Liu <alanliu.yf@gmail.com>

Diff Detail

Event Timeline

Weiwei-2021 created this revision.Thu, Apr 8, 10:31 AM
Weiwei-2021 requested review of this revision.Thu, Apr 8, 10:31 AM
antiagainst accepted this revision.Thu, Apr 8, 10:56 AM

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
3618

s/dyn_cast/cast/ as it is already guaranteed by ODS-generated checks.

3624

Check for resultType == NULL is not needed here. (Also typically we don't compare with == NULL which is C like. MLIR code typically just do !resultType.)

This revision is now accepted and ready to land.Thu, Apr 8, 10:56 AM

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

Thank you for reviewing. Also thanks for helping me land patches all the time. I will fix the two issues and land the patch by myself. :)

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

Thank you for reviewing. Also thanks for helping me land patches all the time. I will fix the two issues and land the patch by myself. :)

SG. Just land after fixing them. No need for re-reviewing. :)

This revision was automatically updated to reflect the committed changes.