[Statepoint] Factor-out utility function to get non-foldable area of STATEPOINT like instructions. NFC

[skatkov]

Summary

The patch is posted to agree on API.

[skatkov]

llvm/include/llvm/CodeGen/TargetInstrInfo.h

1073

to be honest, not happy with the name.
Actually I also want to use this function to determine what operands are ok to use both stack and register...
Any suggestions for the name?

[reames]

Naming suggestions, but likely to converge to LGTM on next iteration.

llvm/lib/CodeGen/TargetInstrInfo.cpp

511

Minor, move the assert above the variable declarations.

[reames]

For unclear reasons, phab dropped a long inline comment from my previous review. Rewritten here.

The comment and naming was confusing to me. I'd suggest the following changes.

1. Restrict the API and naming to patchpoint, stackmap, and statepoint explicitly.
2. Be clear about the fact that operands are "potentially foldable", not "guaranteed foldable".

A suggested name and comment: getPatchpointUnfoldableRange.

For a patchpoint, stackmap, or statepoint intrinsic, return the range of operands which can't be folded into stack references. These instructions are unique in that stack references for some operands have the same execution cost (e.g. none) as the unfolded register forms. The ranged return is guaranteed to include all operands which can't be folded at zero cost.

[skatkov]

Handled Philip's omments.

Philip, thank you for your phrasing suggestions.

[reames]

LGTM

llvm/include/llvm/CodeGen/TargetInstrInfo.h

public:
   /// subb (%esp), ...
   ///
   /// Ideally, we'd like the target implementation of foldMemoryOperand() to
   /// reject subregs - but since this behavior used to be enforced in the
   /// target-independent code, moving this responsibility to the targets
   /// has the potential of causing nasty silent breakage in out-of-tree targets.
   virtual bool isSubregFoldable() const { return false; }
 
+  /// For given MI instruction returns the range of operands indices. Outside
+  /// of this range [first, second) memory operands are foldable.
+  /// The answer is conservative. Returning range might contain foldable memory
+  /// operands while operands outside of range does not contain non-foldable
+  /// memory operands.
+  virtual std::pair<unsigned, unsigned>
+  getNonFoldableRange(const MachineInstr &MI) const;
+
   /// Attempt to fold a load or store of the specified stack
   /// slot into the specified machine instruction for the specified operand(s).
   /// If this is possible, a new instruction is returned with the specified
   /// operand folded, otherwise NULL is returned.
   /// The new instruction is inserted before MI, and the client is responsible
   /// for removing the old instruction.
   /// If VRM is passed, the assigned physregs can be inspected by target to
   /// decide on using an opcode (note that those assignments can still change).

llvm/lib/CodeGen/TargetInstrInfo.cpp

if (RC->hasSubClassEq(MRI.getRegClass(LiveReg)))
     return RC;
 
   // FIXME: Allow folding when register classes are memory compatible.
   return nullptr;
 }
 
 MCInst TargetInstrInfo::getNop() const { llvm_unreachable("Not implemented"); }
 
-static MachineInstr *foldPatchpoint(MachineFunction &MF, MachineInstr &MI,
-                                    ArrayRef<unsigned> Ops, int FrameIndex,
-                                    const TargetInstrInfo &TII) {
+std::pair<unsigned, unsigned>
+TargetInstrInfo::getNonFoldableRange(const MachineInstr &MI) const {
   unsigned StartIdx = 0;
   unsigned NumDefs = 0;
   switch (MI.getOpcode()) {
   case TargetOpcode::STACKMAP: {
     // StackMapLiveValues are foldable
     StartIdx = StackMapOpers(&MI).getVarIdx();
     break;
   }
   case TargetOpcode::PATCHPOINT: {
     // For PatchPoint, the call args are not foldable (even if reported in the
     // stackmap e.g. via anyregcc).
     StartIdx = PatchPointOpers(&MI).getVarIdx();
     break;
   }
   case TargetOpcode::STATEPOINT: {
     // For statepoints, fold deopt and gc arguments, but not call arguments.
     StartIdx = StatepointOpers(&MI).getVarIdx();
     NumDefs = MI.getNumDefs();
     break;
   }
   default:
-    llvm_unreachable("unexpected stackmap opcode");
+    StartIdx = MI.getNumOperands();
+    break;
   }
+  return std::make_pair(NumDefs, StartIdx);
+}
+
+static MachineInstr *foldPatchpoint(MachineFunction &MF, MachineInstr &MI,
+                                    ArrayRef<unsigned> Ops, int FrameIndex,
+                                    const TargetInstrInfo &TII) {
+  unsigned StartIdx = 0;
+  unsigned NumDefs = 0;
+  assert((MI.getOpcode() == TargetOpcode::STACKMAP ||
+          MI.getOpcode() == TargetOpcode::PATCHPOINT ||
+          MI.getOpcode() == TargetOpcode::STATEPOINT) &&
+         "Unexpected stackmap opcode");
+  std::tie(NumDefs, StartIdx) = TII.getNonFoldableRange(MI);
 
   unsigned DefToFoldIdx = MI.getNumOperands();
 
   // Return false if any operands requested for folding are not foldable (not
   // part of the stackmap's live values).
   for (unsigned Op : Ops) {
     if (Op < NumDefs) {
       assert(DefToFoldIdx == MI.getNumOperands() && "Folding multiple defs");