This is an archive of the discontinued LLVM Phabricator instance.

[Coroutines, test] Fix use of var defined in CHECK-NOT
ClosedPublic

Authored by thopre on Apr 4 2021, 12:26 AM.

Details

Summary

LLVM test Transforms/Coroutine/coro-split-sink-lifetime-O2.ll tries to
check for the absence of a sequence of instructions with several
CHECK-NOT with one of those directives using a variable defined in
another. However CHECK-NOT are checked independently so that is using a
variable defined in a pattern that should not occur in the input.

This commit simplifies the CHECK-NOT block to only check for the
presence of any lifetime start marker since that is effectively what
the test was testing at the moment.

Diff Detail

Event Timeline

thopre created this revision.Apr 4 2021, 12:26 AM
thopre requested review of this revision.Apr 4 2021, 12:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2021, 12:26 AM
This revision is now accepted and ready to land.Apr 6 2021, 7:52 PM
This revision was automatically updated to reflect the committed changes.