[OPENMP]Fix PR49777: Clang should not try to specialize orphaned directives in device codegen.
AbandonedPublic
Actions

Authored by ABataev on Apr 1 2021, 12:47 PM.

Details

Reviewers

Summary

Compiler supports generic code emission, but in some cases may
erroneously consider the function context as SPMD context or Non-SPMD
parallel context. Need to clear/restore context upon entrance/exit
to/from function to avoid incorrect codegen.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	590 ms	x64 windows > lld.MachO::reproduce.s Script: -- : 'RUN: at line 3'; rm -rf C:\ws\w32-1\llvm-project\premerge-checks\build\tools\lld\test\MachO\Output\reproduce.s.tmp.dir

Event Timeline

ABataev created this revision.Apr 1 2021, 12:47 PM

Herald added subscribers: guansong, yaxunl. · View Herald TranscriptApr 1 2021, 12:47 PM

ABataev requested review of this revision.Apr 1 2021, 12:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 12:47 PM

Herald added a subscriber: sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B96791: Diff 334800.Apr 1 2021, 1:39 PM

Rebase

Harbormaster completed remote builds in B99184: Diff 338122.Fri, Apr 16, 9:17 AM

Rebase

Harbormaster completed remote builds in B101218: Diff 340909.Tue, Apr 27, 1:05 PM

The bug has been fixed by D95976 already, I'll update the bug report now.
Also, the tracking of Generic/SPMD mode in clang is about to be finally removed, new code depending on that is short-lived.

ABataev abandoned this revision.Wed, Apr 28, 4:44 AM