This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Remove XFAIL LIBCXX-WINDOWS-FIXME from time.clock.file/now.pass.cpp
ClosedPublic

Authored by mstorsjo on Mar 31 2021, 11:01 PM.

Details

Summary

This doesn't fail when _LIBCPP_HAS_NO_INT128 is defined consistently
in both CMAKE_CXX_FLAGS and LIBCXX_TEST_COMPILER_FLAGS; the XFAIL was
added based on early CI testruns where that flag was missing in
LIBCXX_TEST_COMPILER_FLAGS.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 31 2021, 11:01 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2021, 11:01 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
curdeius accepted this revision as: curdeius.Mar 31 2021, 11:50 PM
curdeius added a subscriber: curdeius.

LGTM.
Ceterum autem censeo, Windows'em esse testendam, we should have Windows CI. :)

ldionne accepted this revision.Apr 1 2021, 6:51 AM
This revision is now accepted and ready to land.Apr 1 2021, 6:51 AM
This revision was landed with ongoing or failed builds.Apr 1 2021, 11:25 AM
This revision was automatically updated to reflect the committed changes.