Page MenuHomePhabricator

[lldb-vscode] Use LLVM's ScopeExit to ensure we always terminate the debugger
ClosedPublic

Authored by JDevlieghere on Mar 31 2021, 9:29 PM.

Details

Summary

Make sure we always terminate the debugger by using a RAII object.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Mar 31 2021, 9:29 PM
JDevlieghere created this revision.
wallace accepted this revision.Mar 31 2021, 9:32 PM
This revision is now accepted and ready to land.Mar 31 2021, 9:32 PM
This revision was landed with ongoing or failed builds.Mar 31 2021, 9:42 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2021, 9:42 PM

@wallace - minor inconvenience, but approving a patch in Phabricator without any textual comment does not result in an email to the list, making it look like a patch is being committed without approval - could you include some text in your Phab approvals, as it makes it a bit easier when doing post-commit/process review?

@JDevlieghere Is it worth having a C++ RAII object that calls initialize in the ctor and terminate in the dtor? (maybe even removing the init/terminate free functions, and making them only accessible through an RAII object if that's suitable) What do the other uses of init/terminate look like/could they benefit from such refactoring?